From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com
 [209.85.212.180]) by dpdk.org (Postfix) with ESMTP id D4456C5FA
 for <dev@dpdk.org>; Thu, 18 Jun 2015 14:30:46 +0200 (CEST)
Received: by wiga1 with SMTP id a1so169699822wig.0
 for <dev@dpdk.org>; Thu, 18 Jun 2015 05:30:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=/+ewGOkEEgMq42WhPl1jMPAtvki5QZvahOmJ45NFhkk=;
 b=FReczeZHWWpCRCNPgkOfO8MQGg/f95W+JdUheOTXSVmhZM6Vfz8k+hJG5DkZYsb0xv
 FM/N0mYruAXnPRL8PU/+/4lwZHjHD3pw2iiKWlP8eFZfRJSzUsp30oAnNqBrTCCayu9M
 FAivB3MZDWiizzAmn6xx8tZgMNStATZXkPUFLnsec4RLF5fQqsmHmpSyVq9C8Nqzolsj
 2YmxZnuwCfkgsuNbytJMz/Rt9VOmVLZakI0Fzm/Vzo6/ub1GdilfAL2Fz8cEoASa4V6Y
 Vsv3ZNpimgsaCi0VmQIBl4PmvPI3n5OrAP45fguburXk3vVI1Il1OdsRFpUi3Oe4S4dv
 Rd5g==
X-Gm-Message-State: ALoCoQmap9lZzcYCNErwfjmpSA+c4pM3WKFEtZVPnQnJFum3rgyIM1lNTgweX2gT1Bo+5tKwvjdh
X-Received: by 10.194.234.40 with SMTP id ub8mr6410492wjc.21.1434630646713;
 Thu, 18 Jun 2015 05:30:46 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id o6sm31238236wiz.24.2015.06.18.05.30.45
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 18 Jun 2015 05:30:45 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Pawel Wodkowski <pawelx.wodkowski@intel.com>
Date: Thu, 18 Jun 2015 14:29:44 +0200
Message-ID: <4427464.uLsMqpVbGa@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <1434552528-3576-6-git-send-email-maciejx.t.gajdzica@intel.com>
References: <1434552528-3576-1-git-send-email-maciejx.t.gajdzica@intel.com>
 <1434552528-3576-6-git-send-email-maciejx.t.gajdzica@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 5/6] cfgfile: fixed calling free for each
	section in rte_cfgfile_close
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2015 12:30:47 -0000

2015-06-17 16:48, Maciej Gajdzica:
> From: Pawel Wodkowski <pawelx.wodkowski@intel.com>
> 
> Signed-off-by: Pawel Wodkowski <pawelx.wodkowski@intel.com>

What is fixed exactly? What was the problem?

> @@ -60,6 +60,15 @@ struct rte_cfgfile {
>   * for new entries do we add in */
>  #define CFG_ALLOC_ENTRY_BATCH 16
>  
> +/* Helpers */
> +
> +#define _skip_spaceses(str) ({  \
> +	__typeof__(str) p = (str);  \
> +	while (isspace(*p))         \
> +		p++;                    \
> +	p;                          \
> +})

This macro is not used in this patch nor related.
Is "spaceses" a typo?

> @@ -523,7 +530,7 @@ const char *
>  rte_cfgfile_get_entry(struct rte_cfgfile *cfg, const char *sectionname,
>  		const char *entryname)
>  {
> -	int i;
> +	size_t i;

Why this change? seems not related to free.