From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13827A32A2 for ; Thu, 24 Oct 2019 18:30:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D67F61EB5E; Thu, 24 Oct 2019 18:30:34 +0200 (CEST) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by dpdk.org (Postfix) with ESMTP id 258291EB5A for ; Thu, 24 Oct 2019 18:30:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id F36AB564; Thu, 24 Oct 2019 12:30:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 24 Oct 2019 12:30:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=4gR+/dA7wVr34aDwUXhYHJQ+IriedZRK8IaGaRuztJ8=; b=isuD8LOXk1oS LTz+/OsOLDs2v5mUUWOJ5Q5Nicp9qwnHJD1+DC6JBrTux0GRrRJYx0i18yfO+e1J dJKEjC++ZbP+hG6DSZ6VdABJ9+bTKcj1h69PXnpqKKvumiZnswicHgSNSb3JOyrV Y/u8jTPk0hjn/BzZWlP97byHRTC5mJk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=4gR+/dA7wVr34aDwUXhYHJQ+IriedZRK8IaGaRuzt J8=; b=Ux6X6Hq7xzg6f/PqcTQn7aoEEler8QJEL2Vm6hu84VY9lYdq78190hr7E 1Ne+CJw7z0f139C9M4QOPXuUqU+gu0Ig/EPeHD6MKGqkhfbcvGDpSyYmp3i4+wO3 6z+5XOqcnCCcqTte2CgtIycVJPviinwjJxr8a1WcpTH0RqUgmqdZYwKQol8n5cR7 EhjOcZXXmzkfoXTQ8Mhk5pon0Twl5/LYoWYWumy4B9YJkfLBvLO5+s9nxxlVebxF tIPOrOUp92UyGCgPv+fk2JvovHipvR8ZDeQOrp/OyvJxnO86AV8BJPaOI4S6iyQT YVAa3Rk/7d2cX17NAWPJxakrXNO1Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrledugddutdduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkjghfggfgtgesthfure dttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshes mhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurf grrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecu vehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 28EB880060; Thu, 24 Oct 2019 12:30:30 -0400 (EDT) From: Thomas Monjalon To: david.marchand@redhat.com Cc: dev@dpdk.org, anaotoly.burakov@intel.com, stephen@networkplumber.org, ktraynor@redhat.com Date: Thu, 24 Oct 2019 18:30:29 +0200 Message-ID: <4428801.DX9tkajkud@xps> In-Reply-To: <1571856864-8779-9-git-send-email-david.marchand@redhat.com> References: <1571736761-32134-1-git-send-email-david.marchand@redhat.com> <1571856864-8779-1-git-send-email-david.marchand@redhat.com> <1571856864-8779-9-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 08/12] log: hide internal log structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 23/10/2019 20:54, David Marchand: > No need to expose rte_logs, hide it and remove it from the current ABI. > > Signed-off-by: David Marchand > Acked-by: Stephen Hemminger [...] > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > -struct rte_log_dynamic_type; > - > -/** The rte_log structure. */ > -struct rte_logs { > - uint32_t type; /**< Bitfield with enabled logs. */ > - uint32_t level; /**< Log level. */ > - FILE *file; /**< Output file set by rte_openlog_stream, or NULL. */ > - size_t dynamic_types_len; > - struct rte_log_dynamic_type *dynamic_types; > -}; I like this kind of change, but the FILE stream is available only through the new experimental function. It is against the famous Mr Traynor rule: we cannot deprecate or remove an old stable symbol if the replacement is experimental.