From: Alfredo Cardigliano <cardigliano@ntop.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Anoob Joseph <anoobj@marvell.com>,
Raslan Darawsheh <rasland@mellanox.com>,
Xueming Zhang <xuemingx.zhang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/ionic: ignore missing field initializers warning
Date: Tue, 21 Jan 2020 11:01:51 +0100 [thread overview]
Message-ID: <442B0C2E-A122-40C2-AA90-9F87E125557A@ntop.org> (raw)
In-Reply-To: <20200121095802.3942052-1-ferruh.yigit@intel.com>
> On 21 Jan 2020, at 10:58, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> The compiler warning is:
> from .../drivers/net/ionic/ionic_dev.c:7:
> .../drivers/net/ionic/ionic_if.h:202:5: note: ‘rsvd’ declared here
> u8 rsvd[62];
> ^
>
> This has been observed with gcc 4.8.5, newer 9+ compiler are not giving
> this warning.
>
> Warning is a reminder to the user that there are some fields in the
> struct not initialized with the default value.
> But the C standard clarifies that in that case the field value will be
> zero and code is aware of this behavior, so no initializing to a default
> value is intentional and it is safe to ignore this compiler warning.
>
> Adding '-Wno-missing-field-initializers' compiler flag to disable the
> warning.
>
> Reported-by: Anoob Joseph <anoobj@marvell.com>
> Reported-by: Raslan Darawsheh <rasland@mellanox.com>
> Reported-by: Xueming Zhang <xuemingx.zhang@intel.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> v2:
> * add flag to ionic_lif.c too
> ---
> drivers/net/ionic/Makefile | 3 +++
> drivers/net/ionic/meson.build | 9 +++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/drivers/net/ionic/Makefile b/drivers/net/ionic/Makefile
> index f74ac2d34..bfbe15e27 100644
> --- a/drivers/net/ionic/Makefile
> +++ b/drivers/net/ionic/Makefile
> @@ -31,4 +31,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_IONIC_PMD) += ionic_ethdev.c
> SRCS-$(CONFIG_RTE_LIBRTE_IONIC_PMD) += ionic_lif.c
> SRCS-$(CONFIG_RTE_LIBRTE_IONIC_PMD) += ionic_main.c
>
> +CFLAGS_ionic_dev.o += -Wno-missing-field-initializers
> +CFLAGS_ionic_lif.o += -Wno-missing-field-initializers
> +
> include $(RTE_SDK)/mk/rte.lib.mk
> diff --git a/drivers/net/ionic/meson.build b/drivers/net/ionic/meson.build
> index dee8a3608..06b776018 100644
> --- a/drivers/net/ionic/meson.build
> +++ b/drivers/net/ionic/meson.build
> @@ -11,3 +11,12 @@ sources = files(
> 'ionic_main.c'
> )
>
> +error_cflags = [
> + '-Wno-missing-field-initializers',
> +]
> +
> +foreach flag: error_cflags
> + if cc.has_argument(flag)
> + c_args += flag
> + endif
> +endforeach
> --
> 2.24.1
This looks good to me.
Alfredo
next prev parent reply other threads:[~2020-01-21 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 9:41 [dpdk-dev] [PATCH] " Ferruh Yigit
2020-01-21 9:58 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2020-01-21 10:01 ` Alfredo Cardigliano [this message]
2020-01-21 13:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=442B0C2E-A122-40C2-AA90-9F87E125557A@ntop.org \
--to=cardigliano@ntop.org \
--cc=anoobj@marvell.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=rasland@mellanox.com \
--cc=xuemingx.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).