From: Thomas Monjalon <thomas@monjalon.net>
To: "Yang, Yi Y" <yi.y.yang@intel.com>
Cc: dev@dpdk.org, "Van Haaren, Harry" <harry.van.haaren@intel.com>,
nelio.laranjeiro@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2] service: fix build error "ids uninitialized in rte_service_map_lcore_set"
Date: Thu, 21 Sep 2017 14:41:46 +0200 [thread overview]
Message-ID: <4430088.xROSz6HfYO@xps> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA650FA8738@IRSMSX101.ger.corp.intel.com>
21/09/2017 13:55, Van Haaren, Harry:
> > From: Yang, Yi Y
> > Sent: Thursday, September 21, 2017 2:51 AM
> > To: dev@dpdk.org
> > Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; Yang, Yi Y
> > <yi.y.yang@intel.com>
> > Subject: [PATCH v2] service: fix build error "ids uninitialized in
> > rte_service_map_lcore_set"
> >
> > v1->v2
> > - Change title to more descriptive one
> > - Add issue reproduce information to git log body
> >
> > On current master tree, normal DPDK make will result in
> > the below error:
> >
> > error: ‘ids[0]’ may be used uninitialized in this
> > function [-Werror=maybe-uninitialized]
> > ret = rte_service_map_lcore_set(i, ids[lcore_iter], 1);
> >
> > It can be reproduced very easily on Fedora 21 with
> > gcc-4.9.2-6.fc21.x86_64.
Fixes: 21698354c832 ("service: introduce service cores concept")
Cc: stable@dpdk.org
> > It is fixed after applied this patch.
> >
> > Signed-off-by: Yi Yang <yi.y.yang@intel.com>
>
> +CC Thomas, please pull this asap, as it causes build issues on various GCC/OS versions.
Most of compilers do not raise an error.
It seems specific to gcc 4.9.
Nelio reported the same error with gcc 4.9.
Changing the title to "service: fix build with gcc 4.9"
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks
prev parent reply other threads:[~2017-09-21 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 1:50 Yi Yang
2017-09-21 11:55 ` Van Haaren, Harry
2017-09-21 12:41 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4430088.xROSz6HfYO@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=yi.y.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).