Re: [dpdk-dev] [RFC PATCH v1] config/arm: fix clang cross part number

[Thomas Monjalon <thomas@monjalon.net>]

08/02/2021 17:46, Juraj Linkeš:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 08/02/2021 15:46, Juraj Linkeš:
> > > I accidentally submitted this as an RFC patch. Please consider this to be a
> > regular patch.
> > >
> > > With that said, Thomas, would it be possible to get this into the release?
> > 
> > Yes
> > 
> > For the sake of understanding, is it an issue due to a missing rebase?
> > Or was it a miss in the testing of the patch?
> > 
> > 
> 
> It is an issue of not accounting for changes brought by patches before rebase, so yes, an improper rebase.

OK so it is the second time we miss a rebase for the arm config rework.
I should be more cautious.
You can help me by notifying such dependency in advance when sending patches.
Thanks and sorry for the trouble.



> > > > -----Original Message-----
> > > > From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > > Sent: Monday, February 8, 2021 3:44 PM
> > > > To: bruce.richardson@intel.com; thomas@monjalon.net;
> > > > Ruifeng.Wang@arm.com; Honnappa.Nagarahalli@arm.com;
> > > > jerinjacobk@gmail.com; ferruh.yigit@intel.com
> > > > Cc: dev@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > > Subject: [RFC PATCH v1] config/arm: fix clang cross part number
> > > >
> > > > Rename the 'default' part number in clang cross-file to fix the following
> > issue:
> > > > config/arm/meson.build:238:2: ERROR:  Problem encountered:
> > > > Unsupported part number default of implementer generic. Please add
> > > > support for it or use the generic (-Dmachine=generic) build.
> > > >
> > > > Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> > > >
> > > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > > ---
> > > >  config/arm/arm64_armv8_linux_clang_ubuntu1804 | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> > > > b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> > > > index 8d8cc50ea4..57095c1304 100644
> > > > --- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> > > > +++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> > > > @@ -15,6 +15,6 @@ endian = 'little'
> > > >
> > > >  [properties]
> > > >  implementer_id = 'generic'
> > > > -part_number = 'default'
> > > > +part_number = 'generic'
> > > >  c_args = ['-target', 'aarch64-linux-gnu', '--sysroot',
> > > > '/usr/aarch64-linux-gnu'] c_link_args = ['-target',
> > > > 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-toolchain=/usr']
> > > > --
> > > > 2.20.1