From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <nelio.laranjeiro@6wind.com>
Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com [74.125.82.68])
 by dpdk.org (Postfix) with ESMTP id B62481B202
 for <dev@dpdk.org>; Thu, 19 Oct 2017 14:51:51 +0200 (CEST)
Received: by mail-wm0-f68.google.com with SMTP id l68so16173051wmd.5
 for <dev@dpdk.org>; Thu, 19 Oct 2017 05:51:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:in-reply-to:references
 :in-reply-to:references;
 bh=SUADeibJ+VjLbkCqbq23cKXFMuFUeab/xHtGLvwsoRM=;
 b=zXv74d1rGo4xJsI3FlObcT40xL2SrOF8M4uS3sOOSIr2sfYyvJxrQnxCJQKt5Qke2s
 ZSmMzEpnDodd+9+md6Y+n4FEszvBm5w3yXFsOMHB3JTnSt4WYCsBt9C07E/wTecp1Xhy
 ck131rnSJ8mnsbZJWU8r/nWGzxvYLjZl60TSODdRh0hEh3m5tLV0eVzHGgFaD1xATA+8
 SwD9zuKkTpKyyLMu8Sg1N9h8e3Pty6ezc1OBkWSLXRnh3NnTQOsfCyuhBnkdl780SsmX
 kd8cMe8IlLykq1m+mzvNqQIVAQ6brHS+ypvn/WLYN9Mfd9d9TKx1ikHWJL4hYhuCsCPM
 /EQw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to
 :references:in-reply-to:references;
 bh=SUADeibJ+VjLbkCqbq23cKXFMuFUeab/xHtGLvwsoRM=;
 b=sicufdh0P28a3BYIiAHatddToStDM80+9uctV/PX7y7RpsJJyOB48y2BZq9FcdLVbl
 hlHrgiQAP8Xdw7DpZiG89Ups2Eybkm7cRDA/nutPHj1iHKX1Qk+6mDPpQZeyXoI/SroO
 NEtRJMl6+YWL4krfEqB0+Fm/SpWR3gua78GQomya+GLsQ5yN8eNZAamPqFA1MGb0pbdZ
 6twFZ2zTUqL+fNkkP9en0agzlz8uTlrM1pVC4t85nI+5gX3zhQEf//1HW5o78TphwoWm
 YPwVJE/nPwUz5sRzpWx+8GriUVGb/FnIKsVynzJ9tLLAVDYgDuQQQgc1Tiq0Ou1dkUZg
 0dQA==
X-Gm-Message-State: AMCzsaUeup2ORsxmb5T8phVRVfTXtmjFHQr9xgjx9ulKqnJoH3TOna/K
 h7LegSKlb2wapRuvrQOPpbYPk3WuEQ==
X-Google-Smtp-Source: ABhQp+RggvyF38Z0lLnm4tJk5qBMVufqJXfu2pAGkR1lqz/uQFSW+Lb7+GP/6B6HZ7+KfTZlBUcnrQ==
X-Received: by 10.28.14.195 with SMTP id 186mr1615061wmo.56.1508417511314;
 Thu, 19 Oct 2017 05:51:51 -0700 (PDT)
Received: from laranjeiro-vm.dev.6wind.com.
 (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78])
 by smtp.gmail.com with ESMTPSA id 69sm1024189wmp.11.2017.10.19.05.51.50
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 19 Oct 2017 05:51:50 -0700 (PDT)
From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
To: dev@dpdk.org
Cc: Yongseok Koh <yskoh@mellanox.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>
Date: Thu, 19 Oct 2017 14:51:29 +0200
Message-Id: <44443dcef386d4b36424cf3ba46eae8e7e078912.1508417257.git.nelio.laranjeiro@6wind.com>
X-Mailer: git-send-email 2.11.0
In-Reply-To: <cover.1508417257.git.nelio.laranjeiro@6wind.com>
References: <cover.1508417257.git.nelio.laranjeiro@6wind.com>
In-Reply-To: <cover.1508417257.git.nelio.laranjeiro@6wind.com>
References: <cover.1508417257.git.nelio.laranjeiro@6wind.com>
Subject: [dpdk-dev] [PATCH 1/6] net/mlx5: fix segfault on flow creation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Oct 2017 12:51:51 -0000

When ports are stopped, the hash Rx queue should not be created.

Fixes: 8086cf08b2f0 ("net/mlx5: handle RSS hash configuration in RSS flow")

Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Acked-by: Yongseok Koh <yskoh@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 440bda9a1..452fde588 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -1743,6 +1743,8 @@ priv_flow_create_action_queue_rss(struct priv *priv,
 		flow->frxq[i].ibv_attr = parser->queue[i].ibv_attr;
 		parser->queue[i].ibv_attr = NULL;
 		hash_fields = hash_rxq_init[i].hash_fields;
+		if (!priv->dev->data->dev_started)
+			continue;
 		flow->frxq[i].hrxq =
 			mlx5_priv_hrxq_get(priv,
 					   parser->rss_conf.rss_key,
-- 
2.11.0