From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 5D21D29C8 for ; Wed, 9 Mar 2016 10:33:49 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id l68so184145389wml.0 for ; Wed, 09 Mar 2016 01:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=W7t1KzZNy5ksS+1ApeYcduSGDDaLO5Y8n3kyk8KFQ1c=; b=IOMtbqjlySbMu+qMSt14WkxkdOrDzY+4mHdb+i+1HUuAT9aeWPUjC8zX2+NhL3rkQJ 3fxJPZ5AlMURZxiS88rZTwSemy/pZy+eChoc5wraRrCu1/Q7hHPeXVPifOEN+r2akVTq XY5LM+AvrsqCsJ9mBQCuXEqayTpPg0AjTxTlZF1gpG7hmI0tS0T5o19fqzlEoXBBD1st tgOk7N/428iZ85avCOpOAMAGcmU52fxuvTvD7uhbOwMFKuYpyYQhioI371gSKUL42mjb YzDGs2Z9CnPBEq2S6sFHcUEc3gSb8Syhy1KredJsElh4SRzuPKpnIth0wlSmVt7tsBk7 0rLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=W7t1KzZNy5ksS+1ApeYcduSGDDaLO5Y8n3kyk8KFQ1c=; b=Beh4wcWOaEZ4LFqqqMpAGbuq7DaouFlSYWqsdwjyQjgYTXP5EV+Ys4DE7j42D/hakr V+Je6xcmCtQaRAybGDHEQeyc8Djs0FsbA4xTvbR/+JVwiOyb97DFeOAoqTNA3DXncB1F rRteiMCbPK0zU8w3bua/cunmARCLRCvzNYy+1MB0hOzZaqRTx+D4/4H0Z/PBPumXQ+Rk 5uIztbJBbzhSaJtJSQdWEhChuSoURQdXPks37eIO5iSOkxU6xgCKtG7CIOtO8+KzSF0+ WWVCqlYMuRCOUUZSKizrIsYD1TF15X2++JyV0WE/3iall0YEI19+1WbouWrM7uqUtFru aCjA== X-Gm-Message-State: AD7BkJJrRFxi/H+SkbCZgK30f4kuJYaI6FnuWVr+JrH7ERmsJpIEaeLFzMiazHlDLl5is/Rz X-Received: by 10.194.60.44 with SMTP id e12mr33371221wjr.137.1457516029207; Wed, 09 Mar 2016 01:33:49 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id o128sm7410572wmb.19.2016.03.09.01.33.48 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Mar 2016 01:33:48 -0800 (PST) From: Thomas Monjalon To: "Lu, Wenzhuo" Date: Wed, 09 Mar 2016 10:32:09 +0100 Message-ID: <4446254.25Q6ds7RWu@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC0909034391B9@shsmsx102.ccr.corp.intel.com> References: <1452496044-17524-1-git-send-email-wenzhuo.lu@intel.com> <35564540.2poe2s7h25@xps13> <6A0DE07E22DDAD4C9103DF62FEBC0909034391B9@shsmsx102.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v7 1/5] lib/librte_ether: change function name of tunnel port config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 09:33:49 -0000 2016-03-09 01:25, Lu, Wenzhuo: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-03-09 00:53, Lu, Wenzhuo: > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > 2016-03-04 10:35, Wenzhuo Lu: > > > > > The names of function for tunnel port configuration are not accurate. > > > > > They're tunnel_add/del, better change them to tunnel_port_add/del. > > > > > > > > As a lot of ethdev API, it is really badly documented. > > > > > > > > Please explain why this renaming and let's try to reword the > > > > doxygen: > > > > * Add UDP tunneling port of an Ethernet device for filtering a > > > > specific > > > > * tunneling packet by UDP port number. > > > > > > As we discussed before, these APIs only change the UDP port value of the > > tunnel. > > > But according to their names, seems like they're trying to add/delete a whole > > tunnel. > > > The names don't tell us what the functions really do, so we want to change the > > names. > > > > Neither the comment nor the name explain what means filtering here. > > I think we should explain more. > > We add a port number and a protocol type. What is it made for? > > Prot_type means the tunnel type, VxLAN, GENEVE.., actually it's rte_eth_tunnel_type. > Udp_port means the UDP port value used for the specific type of tunnel. > I'll add some comments in the structure. OK but we really need you explain in the doxygen what the NIC is expected to do with these informations. I think it's so clear in your head that you don't think the users don't understand what the tunnel offloading means.