From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF93DA04A2; Sun, 23 Jan 2022 18:28:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 785A442796; Sun, 23 Jan 2022 18:28:40 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 24BCA40040 for ; Sun, 23 Jan 2022 18:28:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642958918; x=1674494918; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=X2mOcP5e4IsoxLGdPixUpRxJbvaRNZDlExW0y5nZ1+k=; b=R7kE/rdPOC5pZ3ScoQKM2PR+H2aORZPl7iASDOyxVh+c/tccCzzAM250 5sXR50LnqiPpxZDDpevGSlnp1PY45tJ0je5exDfWCmMJv4D02YQ4YOL7E PlZO9junWzNbxkDAWE1JKzQgHWv1FdUVeGNsIUIbTY+1KcFGB5tMVbe3K WaGA6IfvDy6EzhiotyjR3Is8Uzh5jLhvwpvaYWQ+zsZwAbQmBU9bLOcEl Aa+/2zsSJ/HwU8vyxqEFGqr1oYMeyFMfPUBmGJgc8/CqOFCyIka3pZXnR GfoYMhk0tLIpdVjdVX0S8MuWKHs57wFfek/sM2IrObk8VkDn0rV+tW7tN Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10235"; a="306628408" X-IronPort-AV: E=Sophos;i="5.88,310,1635231600"; d="scan'208";a="306628408" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jan 2022 09:28:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,310,1635231600"; d="scan'208";a="627243830" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga004.jf.intel.com with ESMTP; 23 Jan 2022 09:28:36 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 23 Jan 2022 09:28:36 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 23 Jan 2022 09:28:35 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Sun, 23 Jan 2022 09:28:35 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Sun, 23 Jan 2022 09:28:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAb3/1E2DUw0QCp0CxFOWlWOWCMWfYcLJnpYDph5JPbk/pFqnIJ/lA3roZIGJu19chcFeFyr+/lQPW0hu/+Lh5sjVmCyBcYqeu9NbJ0T3yECJl3t37/t3rEH6dKv+oJvpXvtiWakJsIyST2HBYypSYeKb7L2vV5p7diPGvTQ4tDmHpqsBKRp/UrUApCJ/6piwoHOCDTYAoQytOncwESZcnd2v9LSd29a+OcTuRCwqqmu+6S2lObDIysqEkPAk/Rf2qZFKyEOxh4hf69eznmpDhcmaTxAmmkJN0zPViLmW/P63V7UPLgDgk+8QIFYj+bJQao2mTJp4h9Qq3e0h/SzlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eQje+6+aIJfgrgHGu8x6fkcacwUJ+8oxphvRVbWTx9I=; b=h7D8AuITfIw3yTJozjBQVJ6CkCSdsSPhwmSTot0mOOGuUJNB4HBZ/jAH02mJdxwiDANRs5eC1kxJ93O3P8nxY4kdOtDawpJnDGq9EuoEwIHei6kQdv51xWWENDNyVz0DWAW2r6bpGIwfNIKDGvlQZ93nTFRLXq97EqFGzjc/wWEwnGSDFrOc+Hi3vKlefNchkSzZepxihiazwAI3Fe3/j5qPpTetwELWSBaschcjNKnX/JHc2xkHXM7mVxUlfSsuED6azFFfnP+ngurmtMGELaYP1hxwlMa/IQAg9XPGnEmf19ifVbaLcFU0tVt2tYHaNeGaxKyxiLtryo+K94CxJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) by SJ0PR11MB4989.namprd11.prod.outlook.com (2603:10b6:a03:2d9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Sun, 23 Jan 2022 17:28:33 +0000 Received: from MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::2cc6:3020:6ac6:1500]) by MWHPR11MB0062.namprd11.prod.outlook.com ([fe80::2cc6:3020:6ac6:1500%4]) with mapi id 15.20.4909.017; Sun, 23 Jan 2022 17:28:33 +0000 Message-ID: <4450079b-672e-1816-25b9-864c42c2b667@intel.com> Date: Sun, 23 Jan 2022 22:58:13 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] devtools/cocci: update cocci for ethdev namespace Content-Language: en-US To: Ferruh Yigit , References: <20211208114518.3892599-1-aman.deep.singh@intel.com> From: "Singh, Aman Deep" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PN0PR01CA0019.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:4e::17) To MWHPR11MB0062.namprd11.prod.outlook.com (2603:10b6:301:67::34) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 142b0ed1-8b30-4140-5faa-08d9de95c7c5 X-MS-TrafficTypeDiagnostic: SJ0PR11MB4989:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RXBcTekeRbZu4gwd3FDFbOsce0Xa09TVl0kO/nJu1eDaMFN2F4WR7uKeGuSOWVPTnVDmicu37rWn9qGN+mHZ3e51sG61fwCioSiBw3WxqcN3shYb7w9nurWHarsRq/E7lJGlpMyuW3jIGlUKf2TOQwiP8b106Jjd6gusaVLejX5YWYZCLehERbg39puDgyYTgQou049L98vHLWRYDzMzWJ/zuFK4X/TAZKfGxNSTXryL11cxI0UvoFMecuedGeXZZxK6Muighrh74X6JtpDFsQlXDhHXsx/wVrRDED5YBaA49X7v8Xx5mW0+iXPb/6IuWrxikyVGvcibwXDEsKz7W73QQheh2c2mCkZgCdmHPt/MaJ9tyDT0BMa3oSoCrY9vL5I70C9vLYPz05z9vSIuykYyoUm+xtHyQDBcSYVT6UVEuvfqa6YJ48DdkHCx7V6/JM91vPcveRliuTiqV2r1qLLzy5AcIcOEHxfJsve1Y2JiolqYtXONzQgYPOsMPy1fq6hiyr/ftb+vO3OkArk+qYnwdmfcQ17w0hl1BIdd8k0gPj3p2ZgKWLk3f5i58XOeg6Q+xSU1nL7J7l9dYGWpu7Antv+WjPL+jKaOBniplqozHI3DqehGwm16RlkHXy7sbY5zXA4mSAxTjNO5HpEH6sxmLb9R4HNfwW/E7JQaRwyrTI/Xv/Z4QmFTHkzRI9VQ8aRaqj0dRPd7QFOe4qtkKiOOkfIZ6QjX+6WjIyXn1gFKna+l1sH2r85sPa8flD54 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB0062.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2616005)(31696002)(5660300002)(316002)(36756003)(6486002)(508600001)(6512007)(66556008)(66476007)(66946007)(15650500001)(8936002)(186003)(6666004)(8676002)(26005)(31686004)(82960400001)(53546011)(6506007)(2906002)(38100700002)(83380400001)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEpvZTM2OHMvRHdSaG15UzJoVVpxWmE2RUtFVTAyRkJidEtzSmx0Z1BTd1F3?= =?utf-8?B?NllkaUMrcWE1S3BKaUJ0OFRFRE9BZ1VXQmFPKzdGN1o3MGNwQTJvNVhNd3pW?= =?utf-8?B?RHVxdDYyaXYyekJPL0tXbkQrVmZoemptMnNrdGxkNTBCWWZtYjdMZGlDWkFL?= =?utf-8?B?eElBcm9LbkZNSTV5enpCODA3L3R1a1hTalN1VEE1M05KS0dUenpxdWE2Z0dM?= =?utf-8?B?UVRlTG83WWRPeE1ZNzBVUHplVDBCaXZKQ0Rjc3hhTlFpVHE1Q1MwT25aNm9Z?= =?utf-8?B?YnVsMkJYenQ1M2o1aCs5UGZvSGFwUFA3UmUrc2Z4L3pLaXBGalFWSU4raURv?= =?utf-8?B?R2xyMnBTVXgvZzg1R21IcmttendvejVHWnord0NjOWFEL3g1SU1tS2RrTlZw?= =?utf-8?B?SXFFeWV2S0tkaWk4Q28xNVdaTjlxcUppc2hZVHpwanhJekFhUmIxMWRacTcy?= =?utf-8?B?eWJNb21rT1FJM2VNY1lNL1M4RkV5TmRsMDlITXhuZHg2MzZsYUljaUJWaUwr?= =?utf-8?B?WCt1cjBacWZZS0VzRG5GT1R4VVoxK3Q0cFFRdFV6eE5NcytjZGRNWGxDdVJu?= =?utf-8?B?VU9IK1M5SkdWZEZFaXNmdGdKNlpYZ21UMzEvUzFLLzQwSUppVEkrTkJVTk1o?= =?utf-8?B?TjlyejhPUmQ2UGhqZ2RQSEY3ZGRpam1XS3pkWGhLbmlCMDVZajNhWWF6QklF?= =?utf-8?B?Y0RsTnVkN25RTmdJbXJSTG5sTWpPY1dBc1pFNk4vemJJL1JkZGhnS2Z6TTAv?= =?utf-8?B?bWJMUGppZDFjbWl4M1JPa1RUSllrM0wybTJNWlcxeEZObFNVQ1ZPelhXS1R6?= =?utf-8?B?UENhZm5mQmhwd3JLZlFsY094cE1uRHMvV01tMnJBNnFoVGtuQW83ZlpWOXdB?= =?utf-8?B?bDc4U3VLSmVqOE9TVkNXNlV1Y3JpRmh5dGZSUkdhTDVsWDBxY0k2OS9Gb2pq?= =?utf-8?B?NUxHdGtOWHhLUVVDSktpaEZGbStmZnNmL2NoeVBzbXJreDZOZ3ZnS0NBK2l4?= =?utf-8?B?eU9KeVNXVjVjUnk2dkxjUjgvVTdLVmZSWjZkS01SNG5UMU8ydTZGb2x1K09V?= =?utf-8?B?RjIxS3BpZWVXaGpEL01FZFI3U1Y1SHIrZk1ObHk2L0k5UUtFK1lPdThlL0xk?= =?utf-8?B?aTJmV0EzUE9yYUhXYXBKd2xONmZZdHl3NzRsUVYrNmx2R0Y3V3UrM2VoaGRR?= =?utf-8?B?cno1d2lMUW5BNDBBSm9zTFN5MUswaWJzdmhqK2pFWm4yd1NGazk4VUlBYVJs?= =?utf-8?B?MU9qc2tjS1BMSTJuZDhMcytSVm1ibGp1RDNjdnVmMmxEeWR0cFhpSGVSaFkx?= =?utf-8?B?MmNtMjBBejdLMTJkOWNkeS94dTQwb1k1eDRGaXJLNHFjTWVxY01abDF6bkxK?= =?utf-8?B?Y2RJUjE1Tm9oaUxRa2FmaTRWZU44bk04NzFPTzAwZ0Jjc2oyenRtVFQxdDZC?= =?utf-8?B?YzBBNWI3dWMySUtjNklJSisyZWorOWF4RXJSSVlxeXplMHlzOTdRWXo2a0ZM?= =?utf-8?B?aDdCQXFGd2dUS1Y4b1RUOWppUGpTR09xN3lObWtWR3V2cnI1VEo0NWpKbVRh?= =?utf-8?B?RHBPTTQ2aXNMWGpIYlFnMEVzSVBoSUdjV0V2d3A0NWNFeWFlRkJjcEkwanAv?= =?utf-8?B?WjkrMnBqOXJ5MUVOYnlZbXppY2laS1kzeUdLU24yUSt4VitRcFRZaEtsa0hV?= =?utf-8?B?ZDY2MXk4cXUyZ2xoS1pqNUcxTVcvRHBiR0xjeWNKRGlvMG1qSXc0dUNVUnVm?= =?utf-8?B?MXJIYlRTUjMrK2UrZlRLbWVaVGRQcDF5SVV6T05UNitGMjhObm1tSDRjSEF0?= =?utf-8?B?MEtVR3lvRng5RWYwc1FZc285ZnluS1FvWHhPRjBqTXMvODF4Y3ZtbDlvSVk3?= =?utf-8?B?UXJONmIvNUZ6d09MQk5IdGdacTFnZVIrQlE4VnU2UjBHL25PQUNCMzFBck15?= =?utf-8?B?NHNVdTRBbFYzaTdrUjYzZld2WHJrMHlFcmJzQUlTSDRQWHp0RjNDSnRpcXMv?= =?utf-8?B?WkNPV2hvbWNZZ2hMUXdGYXpFVWRscXBHMnJRbFNOQURPa1pydTlvODY0S2hp?= =?utf-8?B?NjdDUUxWeG5DbHhUUGQrMFAxMmMxcGhkRko0TUlJKzN0bDVnYVlDUUMyNnlK?= =?utf-8?B?ZTIzbys2RnlnamNVSHFiamdGVXAvbHUwSG82OFhkOTNLZld0bGQxNXpCT041?= =?utf-8?B?YktuNG5PZ2lLZHJFYjlQMHJYTkI5MkFtNEtsclJpK2NUejl6bEw1VUlneVN4?= =?utf-8?Q?k2wfYP5krxo0kj+KnYHrrOa4MM2akBlR/fZhcXSTv4=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 142b0ed1-8b30-4140-5faa-08d9de95c7c5 X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB0062.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2022 17:28:33.6480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QE8Erdco46z9YPtKdZKqfHgf1jAlozzvo6OAMMTMjgVL+hwwRBWIfTdJqRSMHxnrQOJEdyjAB5FFYa8qkJOboB5F0NxFTLnKZC3E7QefkHk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4989 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/10/2021 6:48 PM, Ferruh Yigit wrote: > On 12/8/2021 11:45 AM, Aman Singh wrote: >> Added two specific execptions for ETH_SPEED_10G >> and ETH_SPEED_25G to avoid there name change. >> >> Signed-off-by: Aman Singh >> --- >>   devtools/cocci/namespace_ethdev.cocci | 3 ++- >>   1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/devtools/cocci/namespace_ethdev.cocci >> b/devtools/cocci/namespace_ethdev.cocci >> index d5de41e117..3afa1fb386 100644 >> --- a/devtools/cocci/namespace_ethdev.cocci >> +++ b/devtools/cocci/namespace_ethdev.cocci >> @@ -16,7 +16,8 @@ exception_matches = >> ["ETH_VLAN_FILTER_CLASSIFY","ETH_VLAN_FILTER_ANY", >>   "RTE_FDIR_NO","RTE_FDIR_REPORT","ETH_MAX_RX_CLIENTS_E1H", >> "ETH_MAX_AGGREGATION_QUEUES_E1","ETH_RSS_ENGINE_NUM","ETH_NUM_MAC_FILTERS", >> "ETH_MAX_NUM_RX_QUEUES_PER_VF_QUAD","ETH_RSS_IND_TABLE_ENTRIES_NUM", >> -"ETH_RSS_KEY_SIZE_REGS","ETH_NUM_STATISTIC_COUNTERS","ETH_SPEED_"] >> +"ETH_RSS_KEY_SIZE_REGS","ETH_NUM_STATISTIC_COUNTERS","ETH_SPEED_10G", >> +"ETH_SPEED_25G"] >>     if any(x in I for x in exception_matches): >>           coccinelle .J= I; >> > > Thanks Aman, > > I confirm 'ETH_SPEED_NUM_*' issue is resolved. > > > There are a few more quirks, can you please check if they are fixable, > if so they can be in v2 of this patch: > > 1) 'ETH_TUNNEL_FILTER_' ones seems not updated, like: > ETH_TUNNEL_FILTER_OMAC -> RTE_ETH_TUNNEL_FILTER_OMAC > ETH_TUNNEL_FILTER_OIP  -> RTE_ETH_TUNNEL_FILTER_OIP > > But need to be careful some of the already has RTE_ prefix, like: > RTE_TUNNEL_FILTER_IMAC_IVLAN > RTE_TUNNEL_FILTER_IMAC_IVLAN_TENID > ... > Will add 'ETH_TUNNEL_FILTER_' in V2 > > 2) Script seems not updating the ones with macro defines with line > continuation, there are a few different instance of them, if it is > easy we can update script, else they can be ignored. Samples: > > drivers/net/ice/ice_ethdev.c: >        #define ICE_RSS_HF_ALL ( \ >                ETH_RSS_IPV4 | \ >                ETH_RSS_IPV6 | \ >                ETH_RSS_NONFRAG_IPV4_UDP | \ >                ETH_RSS_NONFRAG_IPV6_UDP | \ >                ETH_RSS_NONFRAG_IPV4_TCP | \ >                ETH_RSS_NONFRAG_IPV6_TCP | \ >                ETH_RSS_NONFRAG_IPV4_SCTP | \ >                ETH_RSS_NONFRAG_IPV6_SCTP | \ >                ETH_RSS_FRAG_IPV4 | \ >                ETH_RSS_FRAG_IPV6) > > drivers/net/hns3/hns3_rxtx.c: >        #define HNS3_DEV_TX_CSKUM_TSO_OFFLOAD_MASK (\ >                        DEV_TX_OFFLOAD_IPV4_CKSUM | \ >                        DEV_TX_OFFLOAD_TCP_CKSUM | \ >                        DEV_TX_OFFLOAD_UDP_CKSUM | \ >                        DEV_TX_OFFLOAD_SCTP_CKSUM | \ >                        DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | \ >                        DEV_TX_OFFLOAD_OUTER_UDP_CKSUM | \ >                        DEV_TX_OFFLOAD_TCP_TSO | \ >                        DEV_TX_OFFLOAD_VXLAN_TNL_TSO | \ >                        DEV_TX_OFFLOAD_GRE_TNL_TSO | \ >                        DEV_TX_OFFLOAD_GENEVE_TNL_TSO) > These are '# defines' so script will not modify these. As no rule present for these. > > 3) in bonding (eth_bond_private.h), > RTE_RETA_GROUP_SIZE & ETH_RSS_RETA_SIZE_512 seems not updated, > bonding on its own doesn't matter much, but may be good to investigate > why it is not updated, what is missed. > Will add 'ETH_RSS_RETA_SIZE' in v2. For RTE_RETA_GROUP_SIZEI saw only one #define instance. > > 4) Similarly, in 'mlx5/mlx5_rxq.c', ETH_MQ_RX_RSS seems not updated, > not much matter on its own, but may be good to investigate ETH_MQ_ is there in search pattern. Will check. > > > 5) This is optional but script updates old 'ETH_MIRROR_*' too, but > those macros are removed from latest upstream, so may be excluded. Removed 'ETH_MIRROR_' in v2