From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7863BA052B; Wed, 29 Jul 2020 15:19:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A49A337B7; Wed, 29 Jul 2020 15:19:23 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 4E48523D; Wed, 29 Jul 2020 15:19:21 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CEF715C0096; Wed, 29 Jul 2020 09:19:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 29 Jul 2020 09:19:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= I84wtJydR0IX3EE1ZlOFBa4njgMKz5rIcYhlyzogIHA=; b=XNpiCgTtPfZvUc+H BF2fNV8DNKLpl1Jz71kSEBCy/1rvigWUSdksxM1mVKr0DzG3BLTVb96jr3ByFJG3 BuDBZw9CX+6s606S2wXbYl6s2TF9s+YM4iFOVruJpPett02RoDyUjStuRiGbDbqv SYAgFEgFVYOrqGwG5G6FLcNpHOgLiX0pBqlCyxgjjaOMY2yg4f1L4gmKkRZGA+mw l72So2NfeJ70uCIFK0y6BlTxAFJJTi3xygccTozLo6QZrNHkL4e4HNj9QzxV4Xo2 SsTdi2R2tGLgoAtNvzY+aOHa9P4wWQILuzcEKzhn7IgjeEGvwmom44OirlNMPYN7 +T8iFw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=I84wtJydR0IX3EE1ZlOFBa4njgMKz5rIcYhlyzogI HA=; b=SMDvVFX/+moyq2IcoCXVRRy1ApTSDNd19qUQWKNShH1hFJ5tIg9RTxxb7 Y90ahSxr3z00xreF56aq+to0JxpTZo5TSeSzSzP/qy4VEdtbb0idyxn/CEMtshXH GuEtGZNscrEuT9vZbt/dwMeyHV48oSJylQveTPHy/cwWzEfegN0PkS6IjLDPvq8q bJ6ICjFaLp5BIKMlS8Hfnq7SvNdZz4QlcTUr9hd1FgMs6sKjg8TtIixTWWk1fuBb 9K29PUr5MI6WtGnQ+lnfRQy7KRnggkEBqgXySajy9TKSlNBoIyhvQENBzup42Ct5 7d1UNE0vQxLkZH9mIOZkYlCK7JRug== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrieeggdeifecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CAEB630600DC; Wed, 29 Jul 2020 09:19:17 -0400 (EDT) From: Thomas Monjalon To: "Trahe, Fiona" , "Dybkowski, AdamX" , Akhil Goyal Cc: "dev@dpdk.org" , "stable@dpdk.org" Date: Wed, 29 Jul 2020 15:19:16 +0200 Message-ID: <4451101.0yOHXH3JGe@thomas> In-Reply-To: References: <20200724094010.1025-1-adamx.dybkowski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] common/qat: fix uninitialized variable bug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/07/2020 21:19, Akhil Goyal: > > > > > > [Adam] The ret variable value (signed) is not returned directly, please check the > > rest of this function in src > > > code. This is just checked to calculate how many ops were enqueued. And if all > > checks skip (meaning the > > > op was not processed by sym crypto, asym crypto nor compression), we > > should note the user that the > > > actual op was NOT enqueued. That's why ret is set to -1. > > [Fiona] ok. makes sense thanks. In that case > > Acked-by: Fiona Trahe > > Cc: stable@dpdk.org > > Applied to dpdk-next-crypto This patch should not have been merged. The explanation is missing. This is the commit log: "This patch fixes the uninitialized variable bug in QAT PMD." We don't even know what is the consequence and the scope. That's not acceptable for a fix.