From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D624A04DC; Tue, 20 Oct 2020 17:20:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE097AA24; Tue, 20 Oct 2020 17:20:40 +0200 (CEST) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) by dpdk.org (Postfix) with ESMTP id BD349A9F3 for ; Tue, 20 Oct 2020 17:20:39 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailnew.west.internal (Postfix) with ESMTP id D1011B67; Tue, 20 Oct 2020 11:20:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 20 Oct 2020 11:20:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 1W2smg/1ISnbY/2S31biGbmlZ05jQNu2X3FSiy0FIps=; b=o691XMGNEcZdwyVA mFJFv3MpzvTABcoYA39gVJ0vJQRacW9z42U9yBXKr9DQptZu1vmHpwRmlH7wWJuw IHm+Zm/qB/1rDQwavlxPgzECS737IO/qIFmTb+5NQc+57W+5y1FSb/wfi26TksPL HTe/tJn+H/JLLKv8J4z8Nr+qQ9fJzuPxL9/u9owx2oi3dPl1HexwWtcpKqzruKa2 XyhE4P7KtW16PjTfgm3RhP03gcFlN90Ofs5uZ0OQ8ULoT4pBS0blSCxSWhY0hWrQ kWgg3gaM3t5AP2iPwrosNz8MHlAUp+111UnC/od19alaXfaaXoTPNSahZRAY3WAi c6scAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1W2smg/1ISnbY/2S31biGbmlZ05jQNu2X3FSiy0FI ps=; b=X/i/GVhLODoG7P6MsqssPYdSE3+YQyHhWKXylrM5EwuMAh7LILId9GpdX cnMYqjzf0+V9DsOH5rT83j5U7g5vVPAXkGUcaOoDjSoco7AE0se6fq24Hbf3NV3i DdmYSZAcZ+Som4taH+N+ac6AB/EuKJLe72XhIGlYpX9Gk17CmAHoCL5TEPW2exY9 uJdogC0jzGFolch7NZKghOwrGQJY5TWyBUGhzovn5A+ABG0+G92cBdzgycMArMj7 f8ri8aExwRm+1MD7N5vGPnmxcRIIaHsXaQXBHqpLgx7VLgd96ZWJJ1kLLLj3y5sa QWcFxMAx8Vq/ekH5JRJZkDYiU6MEA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeefgdekhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgepudenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 134E83064686; Tue, 20 Oct 2020 11:20:33 -0400 (EDT) From: Thomas Monjalon To: "McDaniel, Timothy" , "Eads, Gage" Cc: "Richardson, Bruce" , Jerin Jacob , "Mcnamara, John" , "Kovacevic, Marko" , Ray Kinsella , Neil Horman , dpdk-dev , "Carrillo, Erik G" , "Van Haaren, Harry" , Jerin Jacob , david.marchand@redhat.com Date: Tue, 20 Oct 2020 17:20:32 +0200 Message-ID: <44534720.QNPfj4FMZr@thomas> In-Reply-To: References: <1599855987-25976-2-git-send-email-timothy.mcdaniel@intel.com> <20201019083337.GA649@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 01/22] event/dlb2: add documentation and meson build infrastructure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 20/10/2020 17:17, McDaniel, Timothy: > From: Bruce Richardson > > On Sun, Oct 18, 2020 at 02:18:32PM +0530, Jerin Jacob wrote: > > > On Sat, Oct 17, 2020 at 11:50 PM Timothy McDaniel > > > wrote: > > > > > > > > Adds the meson build infrastructure, which includes > > > > compile-time constants in rte_config.h. DLB2 is > > > > only supported on Linux X86 platforms at this time. > > > > > > > > Signed-off-by: Timothy McDaniel > > > > Reviewed-by: Gage Eads > > > > --- > > > > --- a/drivers/event/meson.build > > > > +++ b/drivers/event/meson.build > > > > @@ -10,6 +10,9 @@ if not (toolchain == 'gcc' and > > cc.version().version_compare('<4.8.6') and > > > > dpdk_conf.has('RTE_ARCH_ARM64')) > > > > drivers += 'octeontx' > > > > endif > > > > +if (dpdk_conf.has('RTE_ARCH_X86_64') and is_linux) > > > > + drivers += 'dlb2' > > > > +endif > > > > > > Please add the message in "Content Skipped" section, > > > Reference: grep "reason" in drivers/vdpa/mlx5/meson.build > > > > > > > The octeontx case is also wrong in this file, IMHO. Rather than checking > > things in the event level and adding things to the list, the list should > > just be static. If something should be optionally compiled, then check the > > conditions in the driver meson.build file itself and add "build=false" to > > disable, setting "reason" to the cause of it being disabled. This keeps all > > the logic about a driver in the other file, rather than someone having to > > look in multiple places for why something is or isn't getting built > > properly. > > > > Regards, > > /Bruce > > Due to time constraints, I would prefer to take these issues up in a future release. If you have strong time constraints to complete everything, then it is better to postpone the feature to the next release.