From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 50A641B26C; Fri, 20 Oct 2017 18:57:57 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Oct 2017 09:57:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,405,1503385200"; d="scan'208";a="911981064" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.220]) ([10.241.224.220]) by FMSMGA003.fm.intel.com with ESMTP; 20 Oct 2017 09:57:39 -0700 Cc: Thomas Monjalon , dev@dpdk.org, stable@dpdk.org, Jianfeng Tan , George Prekas , Sergio Gonzalez Monroy References: <20171020165511.47899-1-ferruh.yigit@intel.com> To: Jingjing Wu , Shijith Thotton , Gregory Etelson , Harish Patil From: Ferruh Yigit Message-ID: <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> Date: Fri, 20 Oct 2017 09:57:38 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171020165511.47899-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] igb_uio: remove device reset in open X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2017 16:57:57 -0000 On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > Remove device reset during application start, the reset for application > exit still there. > > Reset in open removed because of following comments: > 1- Device reset not completed when VF driver loaded, which cause VF PMD > initialization error. > Adding delay can solve the issue but will increase driver load time. > > 2- Reset will be issues all devices unconditionally, not very efficient > way. > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit Hi Jingjing, Shijith, Gregory, Harish, Can you please test this on top of current master (which has already Jingjin's fix) ? Thanks, ferruh > --- > Cc: Jianfeng Tan > Cc: Jingjing Wu > Cc: Shijith Thotton > Cc: Gregory Etelson > Cc: Harish Patil > Cc: George Prekas > Cc: Sergio Gonzalez Monroy > --- > lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > index f7ef82554..fd320d87d 100644 > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c > @@ -336,8 +336,6 @@ igbuio_pci_open(struct uio_info *info, struct inode *inode) > struct pci_dev *dev = udev->pdev; > int err; > > - pci_reset_function(dev); > - > /* set bus master, which was cleared by the reset function */ > pci_set_master(dev); > >