From: Thomas Monjalon <thomas@monjalon.net>
To: Yuval Avnery <yuvalav@mellanox.com>
Cc: Ori Kam <orika@mellanox.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] regex/mlx5: fix sq free check on enqueue
Date: Wed, 29 Jul 2020 16:51:35 +0200 [thread overview]
Message-ID: <4457639.XNo7hN0TIy@thomas> (raw)
In-Reply-To: <1595988891-151622-1-git-send-email-yuvalav@mellanox.com>
29/07/2020 04:14, Yuval Avnery:
> Free sq check had a bug, causing jobs to overwrite.
Reworded with Ori's help:
regex/mlx5: fix overrun on enqueueing
When enqueueing a buffer the PMD check if there is room
in its send queue (SQ).
The current implementation did not take into account that
queue indices are wrapping around, which may result in
consumer index (sq->ci) can have bigger value than than
the producer index (sq->pi).
>
> Fixes: 8740ba5fe57f ("regex/mlx5: add enqueue implementation")
Fixes: 4d4e245ad637 ("regex/mlx5: support enqueue")
> Signed-off-by: Yuval Avnery <yuvalav@mellanox.com>
> Acked-by: Ori Kam <orika@mellanox.com>
Applied, thanks
prev parent reply other threads:[~2020-07-29 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 2:14 Yuval Avnery
2020-07-29 14:51 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4457639.XNo7hN0TIy@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=yuvalav@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).