From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 62D75A052B;
Wed, 29 Jul 2020 16:58:12 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 46EB037B7;
Wed, 29 Jul 2020 16:58:12 +0200 (CEST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 63F04A69
for <dev@dpdk.org>; Wed, 29 Jul 2020 16:58:10 +0200 (CEST)
Received: from compute7.internal (compute7.nyi.internal [10.202.2.47])
by mailout.nyi.internal (Postfix) with ESMTP id BB1205C0102;
Wed, 29 Jul 2020 10:51:37 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute7.internal (MEProxy); Wed, 29 Jul 2020 10:51:37 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm1; bh=
krb1SGIDDtsSSOv0XTdpHthAAiThZVFw1UY4wi1g53g=; b=QHAkFdImHy1GjYok
R9GpoupihLT3rEad3x+tG1O1EDXM6biuATBTJVvEvyVfnCyzjmHYEXLu8x1ktbfL
R/CM0x/aTdm0gHd211sSA5TPz38tCuFW1XKjPQBs/hy1e4vOgtvYKK7T8NPxSnyW
KDm+CBhccK2I43wugj7K5Z6JmqglJ1+brQBQxeRQyTZd4bA9hIweTAQsLZUM470H
0Ojzxtb+4n+7lQkMsbuPFBG1sVCjMx13F+ViMpKGBkH9VxhHm48aiydHuiKizZIu
AWcn6lXB/LWs2phs/ZXRNQNnmBQ3OH/TaAfUzCrqM4PrJZB5MFQO2UpxmSxHV5fK
qMto6A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm3; bh=krb1SGIDDtsSSOv0XTdpHthAAiThZVFw1UY4wi1g5
3g=; b=kh/sabLegHpdxCP+WZSS5DiQTcClm3XyPpPMlgV1yg8MrLk7QQOZZ5Tcn
pLs7PolHoURK/j67GuFR9/EH/I/zpCbI/CEqrluvtKTuTHjr+21DQmETQPggUTXB
XJWIRJ/q9T26j9ggSJoGj53SYolpZymEsaWKzDAVnqghxJ3YYtS8qY16qUzZh90u
EFLWWPaF0yy4G9B+f8nmq7+Wl5COgWwgAIwUuImgMgSU6s2qQUWBUSl3JPRO+VO+
QACVh9fMtDz+ybkrbF68+amgxqUIwr6NCKNUpVW5A3MOkr5g4wmwJa0acK/OLXv3
6HPkM/qTP7VL7RIqA0vsB1Y9Ycgew==
X-ME-Sender: <xms:-YwhX2Tl7ELRgcDXmzAqatpjgKLegyRILjiq8lxBgeNXm0f3gZSSGg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrieeggdekvdcutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
nhdrnhgvth
X-ME-Proxy: <xmx:-YwhX7yfG82kij-IF9y_jDG_e4yi4eKBFSX3nSqrEQ4GmeL3TxgQAQ>
<xmx:-YwhXz1D9maWafaPWWRY53yd7xkjmROpGekeBBeMTOK2j97xZTEQgQ>
<xmx:-YwhXyDbYj71UIk9PyvYdATWprNyLxmOmgzL6bok65v4AyAY7GHtjQ>
<xmx:-YwhXxeOteJ9dKn44rLYDmY1mCYYl0hsS7JBSNk7vN1_9KCGoWB7XQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id CE06630600B4;
Wed, 29 Jul 2020 10:51:36 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Yuval Avnery <yuvalav@mellanox.com>
Cc: Ori Kam <orika@mellanox.com>, dev@dpdk.org
Date: Wed, 29 Jul 2020 16:51:35 +0200
Message-ID: <4457639.XNo7hN0TIy@thomas>
In-Reply-To: <1595988891-151622-1-git-send-email-yuvalav@mellanox.com>
References: <1595988891-151622-1-git-send-email-yuvalav@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] regex/mlx5: fix sq free check on enqueue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
29/07/2020 04:14, Yuval Avnery:
> Free sq check had a bug, causing jobs to overwrite.
Reworded with Ori's help:
regex/mlx5: fix overrun on enqueueing
When enqueueing a buffer the PMD check if there is room
in its send queue (SQ).
The current implementation did not take into account that
queue indices are wrapping around, which may result in
consumer index (sq->ci) can have bigger value than than
the producer index (sq->pi).
>
> Fixes: 8740ba5fe57f ("regex/mlx5: add enqueue implementation")
Fixes: 4d4e245ad637 ("regex/mlx5: support enqueue")
> Signed-off-by: Yuval Avnery <yuvalav@mellanox.com>
> Acked-by: Ori Kam <orika@mellanox.com>
Applied, thanks