From: "Harris, James R" <james.r.harris@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Bie, Tiwei" <tiwei.bie@intel.com>,
"Wang, Zhihong" <zhihong.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: add __rte_experimental to rte_vhost_va_from_guest_pa
Date: Mon, 23 Sep 2019 23:26:40 +0000 [thread overview]
Message-ID: <445C53A1-178F-4B49-9537-6ACA581AFE40@intel.com> (raw)
In-Reply-To: <de142e8c-99d9-e179-d3c0-93d208b62b70@intel.com>
On 9/23/19, 8:41 AM, "Yigit, Ferruh" <ferruh.yigit@intel.com> wrote:
On 9/18/2019 2:12 PM, Maxime Coquelin wrote:
>
>
> On 8/20/19 11:37 AM, Jim Harris wrote:
>> This function is listed under EXPERIMENTAL in the
>> rte_vhost_version.map, so it needs to be marked
>> with __rte_experimental in the header file as well.
>>
>> Found by check-experimental-syms.sh when trying to compile
>> DPDK with -finstrument-functions. This script didn't
>> catch this in the normal case, since the function is
>> declared __rte_always_inline.
>>
>> Signed-off-by: Jim Harris <james.r.harris@intel.com>
>> ---
>> lib/librte_vhost/rte_vhost.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h
>> index 7fb172912..fc27bc21e 100644
>> --- a/lib/librte_vhost/rte_vhost.h
>> +++ b/lib/librte_vhost/rte_vhost.h
>> @@ -225,6 +225,7 @@ rte_vhost_gpa_to_vva(struct rte_vhost_memory *mem, uint64_t gpa)
>> * @return
>> * the host virtual address on success, 0 on failure
>> */
>> +__rte_experimental
>> static __rte_always_inline uint64_t
>> rte_vhost_va_from_guest_pa(struct rte_vhost_memory *mem,
>> uint64_t gpa, uint64_t *len)
>>
>
> Fixed commit message to comply with check-git-log tool.
>
> Applied to dpdk-next-virtio/master.
This is breaking the 'vhost_scsi' sample application since it is using this
experimental API [1].
Build system should be updated to say sample application is allowed to using
experimental APIs.
Can you please send a new version?
Thanks Ferruh. I missed that. Does this mean adding the following to examples/vhost_scsi/Makefile?
CFLAGS += -DALLOW_EXPERIMENTAL_API
And this to examples/vhost_scsi/meson.build?
allow_experimental_apis = true
Maxime - please let me know if you need a patch from me that you'll apply to dpdk-next-virtio/master, or if you would send such a patch yourself.
Thanks,
-Jim
next prev parent reply other threads:[~2019-09-23 23:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 9:37 Jim Harris
2019-08-21 5:19 ` Tiwei Bie
2019-09-18 13:12 ` Maxime Coquelin
2019-09-23 15:41 ` Ferruh Yigit
2019-09-23 23:26 ` Harris, James R [this message]
2019-09-24 16:04 ` Ferruh Yigit
2019-09-24 16:05 ` Maxime Coquelin
2019-09-24 9:23 ` [dpdk-dev] [PATCH v2] vhost: add experimental flag Jim Harris
2019-09-27 7:50 ` Maxime Coquelin
2019-09-27 9:48 ` Maxime Coquelin
2019-09-27 19:31 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445C53A1-178F-4B49-9537-6ACA581AFE40@intel.com \
--to=james.r.harris@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).