From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com [209.65.160.78]) by dpdk.org (Postfix) with ESMTP id BD47C282 for ; Thu, 15 Dec 2016 13:50:43 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id 3a192585.2b452fe72940.235943.00-2466.503309.nbfkord-smmo02.seg.att.com (envelope-from ); Thu, 15 Dec 2016 12:50:43 +0000 (UTC) X-MXL-Hash: 585291a33840c43c-00807bf71cf8594df5b03dc2731b9a41c97d81a0 Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id 0a192585.0.235941.00-2341.503306.nbfkord-smmo02.seg.att.com (envelope-from ); Thu, 15 Dec 2016 12:50:42 +0000 (UTC) X-MXL-Hash: 585291a2148ac4c6-a943b4a085d60a669bc30758174e9f3ada351b29 Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Thu, 15 Dec 2016 12:50:35 +0000 To: Ferruh Yigit , References: <1480664691-26561-1-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: <446323c9-eccc-59f6-808b-610006a5d771@solarflare.com> Date: Thu, 15 Dec 2016 15:50:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22762.003 X-TM-AS-Result: No--21.680400-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=Yd+7kllf c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=n5n_aSjo0skA:10 a=zRKbQ67AAAAA:8 a] X-AnalysisOut: [=q1uappCIrDOBnTEs8BcA:9 a=W-jTcimqJfmW8uO3:21 a=yVlqqxCxCE] X-AnalysisOut: [8dnK6j:21 a=pILNOxqGKmIA:10 a=QyXUC8HyAAAA:8 a=zEThAoJF2CL] X-AnalysisOut: [LzwZI8nAA:9 a=SIM11iHRwhF_QAY9:21 a=L8PMC6xuiVi15gpq:21 a=] X-AnalysisOut: [r-CRblnjs-AU2zIq:21 a=_W_S_7VecoQA:10 a=PA03WX8tBzeizutn5_] X-AnalysisOut: [OT:22 a=avl4LiGQNoF5OB0DmCJ7:22] X-Spam: [F=0.4413211907; CM=0.500; S=0.441(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 00/31] Support more features in Solarflare PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Dec 2016 12:50:44 -0000 On 12/09/2016 08:34 PM, Ferruh Yigit wrote: > On 12/2/2016 7:44 AM, Andrew Rybchenko wrote: >> The patch series adds a number of features to Solarflare libefx-based >> PMD. Basically one patch per feature. >> >> The patches are grouped into one series since they touch nearby lines >> in either PMD feature list, or dev_ops structure, or documentation. >> So, patches cannot be applied in arbitrary order. >> >> The patch series should be applied after >> [PATCH v2 00/55] Solarflare libefx-based PMD >> (Message-ID: 1480436367-20749-1-git-send-email-arybchenko@solarflare.com) >> >> >> Andrew Rybchenko (16): >> net/sfc: implement MCDI logging callback >> net/sfc: support parameter to choose performance profile >> net/sfc: implement ethdev hook to get basic statistics >> net/sfc: support extended statistics >> net/sfc: support flow control settings get/set >> net/sfc: support link status change interrupt >> net/sfc: implement device operation to change MTU >> net/sfc: support link speed and duplex settings >> net/sfc: support checksum offloads on receive >> net/sfc: handle received packet type info provided by HW >> net/sfc: support callback to get receive queue information >> net/sfc: support Rx free threshold >> net/sfc: add callback to get RxQ pending descriptors count >> net/sfc: add RxQ descriptor done callback >> net/sfc: support scattered Rx DMA >> net/sfc: support deferred start of receive queues >> >> Artem Andreev (1): >> net/sfc: support link up/down >> >> Ivan Malov (14): >> net/sfc: support promiscuous and all-multicast control >> net/sfc: support main (the first) MAC address change >> net/sfc: support multicast addresses list controls >> net/sfc: add callback to get transmit queue information >> net/sfc: support Tx free threshold >> net/sfc: support deferred start of transmit queues >> net/sfc: support VLAN offload on transmit path >> net/sfc: add basic stubs for RSS support on driver attach >> net/sfc: support RSS hash offload >> net/sfc: add callback to query RSS key and hash types config >> net/sfc: add callback to set RSS key and hash types config >> net/sfc: add callback to query RSS redirection table >> net/sfc: add callback to update RSS redirection table >> net/sfc: support firmware-assisted TSOv2 > Hi Andrew, > > I am getting following build errors for clang [1] and ICC [2]. I have > not investigated the root cause, just copy-pasting here. > > For ICC, since you explicitly noted it is not supported, and reported > warning is known, I believe it is safe the ignore this warning via > "-wd188" CFLAGS option in the Makefile. Hi Ferruh, I think I prefer to fix these warnings in v2. May be other compilers will become more pedantic in the future. Thanks, Andrew. > > Thanks, > ferruh > > > > [1] clang > .../drivers/net/sfc/sfc_ethdev.c:1143:4: error: format specifies type > 'unsigned short' but the argument has type 'int' [-Werror,-Wformat] > EFX_RSS_TBL_SIZE); > ^~~~~~~~~~~~~~~~ > .../drivers/net/sfc/base/efx.h:1866:26: note: expanded from macro > 'EFX_RSS_TBL_SIZE' > #define EFX_RSS_TBL_SIZE 128 /* Rows in RX indirection table */ > ^~~ > .../drivers/net/sfc/sfc_log.h:51:19: note: expanded from macro 'sfc_err' > SFC_LOG(sa, ERR, __VA_ARGS__) > ^~~~~~~~~~~ > .../drivers/net/sfc/sfc_log.h:47:18: note: expanded from macro 'SFC_LOG' > RTE_FMT_TAIL(__VA_ARGS__,))); \ > ^~~~~~~~~~~ > .../x86_64-native-linuxapp-clang/include/rte_common.h:345:32: note: > expanded from macro 'RTE_FMT_TAIL' > #define RTE_FMT_TAIL(fmt, ...) __VA_ARGS__ > ^~~~~~~~~~~ > .../x86_64-native-linuxapp-clang/include/rte_common.h:343:39: note: > expanded from macro 'RTE_FMT' > #define RTE_FMT(fmt, ...) fmt "%.0s", __VA_ARGS__ "" > ^~~~~~~~~~~ > .../x86_64-native-linuxapp-clang/include/rte_log.h:258:32: note: > expanded from macro 'RTE_LOG' > RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__) > ^~~~~~~~~~~ > > > > [2] ICC > .../drivers/net/sfc/sfc_ethdev.c(1063): error #188: enumerated type > mixed with another type > efx_hash_types, B_TRUE); > ^ > > .../drivers/net/sfc/sfc_ethdev.c(1086): error #188: enumerated type > mixed with another type > sa->rss_hash_types, B_TRUE) != 0) > ^ > > compilation aborted for .../drivers/net/sfc/sfc_ethdev.c (code 2) > make[7]: *** [sfc_ethdev.o] Error 2 > make[7]: *** Waiting for unfinished jobs.... > .../drivers/net/sfc/sfc_rx.c(820): error #188: enumerated type mixed > with another type > sa->rss_hash_types, B_TRUE); > ^ > > compilation aborted for .../drivers/net/sfc/sfc_rx.c (code 2) >