DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
@ 2020-08-04 10:26 Thomas Monjalon
  2020-08-04 10:30 ` Maxime Coquelin
                   ` (2 more replies)
  0 siblings, 3 replies; 15+ messages in thread
From: Thomas Monjalon @ 2020-08-04 10:26 UTC (permalink / raw)
  To: dev
  Cc: david.marchand, arybchenko, ferruh.yigit, bruce.richardson,
	stephen, ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal,
	bluca, ktraynor, honnappa.nagarahalli

Environment configuration is the responsibility of distributions
or upper-level frameworks.
DPDK focus on documenting the requirements and some recommendations.

Maintaining a good adaptative deployment setup is a project by itself.
Anyway this script was interactive, useful only for experimenters.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index ea4cfa7a48..7ce9fc3e4f 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -151,3 +151,7 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
+  ``make``. Given environments are too much variables for such a simple script,
+  it will be removed in DPDK 20.11.
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
  2020-08-04 10:26 [dpdk-dev] [PATCH] doc: announce removal of interactive setup script Thomas Monjalon
@ 2020-08-04 10:30 ` Maxime Coquelin
  2020-08-04 10:33   ` Jerin Jacob
  2020-08-05 16:19 ` Ferruh Yigit
  2020-08-06 14:51 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
  2 siblings, 1 reply; 15+ messages in thread
From: Maxime Coquelin @ 2020-08-04 10:30 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: david.marchand, arybchenko, ferruh.yigit, bruce.richardson,
	stephen, ajit.khaparde, jerinj, akhil.goyal, bluca, ktraynor,
	honnappa.nagarahalli



On 8/4/20 12:26 PM, Thomas Monjalon wrote:
> Environment configuration is the responsibility of distributions
> or upper-level frameworks.
> DPDK focus on documenting the requirements and some recommendations.
> 
> Maintaining a good adaptative deployment setup is a project by itself.
> Anyway this script was interactive, useful only for experimenters.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ea4cfa7a48..7ce9fc3e4f 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -151,3 +151,7 @@ Deprecation Notices
>    Python 2 support will be completely removed in 20.11.
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
> +
> +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> +  ``make``. Given environments are too much variables for such a simple script,
> +  it will be removed in DPDK 20.11.
> 

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
  2020-08-04 10:30 ` Maxime Coquelin
@ 2020-08-04 10:33   ` Jerin Jacob
  0 siblings, 0 replies; 15+ messages in thread
From: Jerin Jacob @ 2020-08-04 10:33 UTC (permalink / raw)
  To: Maxime Coquelin
  Cc: Thomas Monjalon, dpdk-dev, David Marchand, Andrew Rybchenko,
	Ferruh Yigit, Richardson, Bruce, Stephen Hemminger,
	Ajit Khaparde, Jerin Jacob, Akhil Goyal, Luca Boccassi,
	Kevin Traynor, Honnappa Nagarahalli

On Tue, Aug 4, 2020 at 4:00 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
>
>
> On 8/4/20 12:26 PM, Thomas Monjalon wrote:
> > Environment configuration is the responsibility of distributions
> > or upper-level frameworks.
> > DPDK focus on documenting the requirements and some recommendations.
> >
> > Maintaining a good adaptative deployment setup is a project by itself.
> > Anyway this script was interactive, useful only for experimenters.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index ea4cfa7a48..7ce9fc3e4f 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -151,3 +151,7 @@ Deprecation Notices
> >    Python 2 support will be completely removed in 20.11.
> >    In 20.08, explicit deprecation warnings will be displayed when running
> >    scripts with Python 2.
> > +
> > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > +  ``make``. Given environments are too much variables for such a simple script,
> > +  it will be removed in DPDK 20.11.
> >
>
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>



>
> Thanks,
> Maxime
>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
  2020-08-04 10:26 [dpdk-dev] [PATCH] doc: announce removal of interactive setup script Thomas Monjalon
  2020-08-04 10:30 ` Maxime Coquelin
@ 2020-08-05 16:19 ` Ferruh Yigit
  2020-08-05 16:26   ` Thomas Monjalon
  2020-08-06 14:51 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
  2 siblings, 1 reply; 15+ messages in thread
From: Ferruh Yigit @ 2020-08-05 16:19 UTC (permalink / raw)
  To: Thomas Monjalon, dev
  Cc: david.marchand, arybchenko, bruce.richardson, stephen,
	ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal, bluca,
	ktraynor, honnappa.nagarahalli

On 8/4/2020 11:26 AM, Thomas Monjalon wrote:
> Environment configuration is the responsibility of distributions
> or upper-level frameworks.
> DPDK focus on documenting the requirements and some recommendations.
> 
> Maintaining a good adaptative deployment setup is a project by itself.
> Anyway this script was interactive, useful only for experimenters.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index ea4cfa7a48..7ce9fc3e4f 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -151,3 +151,7 @@ Deprecation Notices
>    Python 2 support will be completely removed in 20.11.
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
> +
> +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> +  ``make``. Given environments are too much variables for such a simple script,
> +  it will be removed in DPDK 20.11.
> 

Personally I use script as a shortcut to allocate hugemaps, and find that bit
useful.

Agree that the environment configuration or deployment script is something else,
and not sure if this script ever claimed to be one, it is more a user helper
script I think.

What do you think remove the build part, which depends to Make build system as
mentioned above, and keep the rest as a helper script (and perhaps rename to
highlight the intention), so basically keep only below part:

----------------------------------------------------------
 Step 2: Setup linux environment
----------------------------------------------------------
[45] Insert IGB UIO module
[46] Insert VFIO module
[47] Insert KNI module
[48] Setup hugepage mappings for non-NUMA systems
[49] Setup hugepage mappings for NUMA systems
[50] Display current Ethernet/Baseband/Crypto device settings
[51] Bind Ethernet/Baseband/Crypto device to IGB UIO module
[52] Bind Ethernet/Baseband/Crypto device to VFIO module
[53] Setup VFIO permissions

----------------------------------------------------------
 Step 4: Other tools
----------------------------------------------------------
[56] List hugepage info from /proc/meminfo

----------------------------------------------------------
 Step 5: Uninstall and system cleanup
----------------------------------------------------------
[57] Unbind devices from IGB UIO or VFIO driver
[58] Remove IGB UIO module
[59] Remove VFIO module
[60] Remove KNI module
[61] Remove hugepage mappings

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
  2020-08-05 16:19 ` Ferruh Yigit
@ 2020-08-05 16:26   ` Thomas Monjalon
  2020-08-05 17:46     ` Trahe, Fiona
  0 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2020-08-05 16:26 UTC (permalink / raw)
  To: Ferruh Yigit
  Cc: dev, david.marchand, arybchenko, bruce.richardson, stephen,
	ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal, bluca,
	ktraynor, honnappa.nagarahalli

05/08/2020 18:19, Ferruh Yigit:
> On 8/4/2020 11:26 AM, Thomas Monjalon wrote:
> > Environment configuration is the responsibility of distributions
> > or upper-level frameworks.
> > DPDK focus on documenting the requirements and some recommendations.
> > 
> > Maintaining a good adaptative deployment setup is a project by itself.
> > Anyway this script was interactive, useful only for experimenters.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index ea4cfa7a48..7ce9fc3e4f 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -151,3 +151,7 @@ Deprecation Notices
> >    Python 2 support will be completely removed in 20.11.
> >    In 20.08, explicit deprecation warnings will be displayed when running
> >    scripts with Python 2.
> > +
> > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > +  ``make``. Given environments are too much variables for such a simple script,
> > +  it will be removed in DPDK 20.11.
> > 
> 
> Personally I use script as a shortcut to allocate hugemaps, and find that bit
> useful.
> 
> Agree that the environment configuration or deployment script is something else,
> and not sure if this script ever claimed to be one, it is more a user helper
> script I think.
> 
> What do you think remove the build part, which depends to Make build system as
> mentioned above, and keep the rest as a helper script (and perhaps rename to
> highlight the intention), so basically keep only below part:
> 
> ----------------------------------------------------------
>  Step 2: Setup linux environment
> ----------------------------------------------------------
> [45] Insert IGB UIO module
> [46] Insert VFIO module

It does not cover other kernel modules.

> [47] Insert KNI module
> [48] Setup hugepage mappings for non-NUMA systems
> [49] Setup hugepage mappings for NUMA systems

It does not use the standard hugepage directory.

> [50] Display current Ethernet/Baseband/Crypto device settings
> [51] Bind Ethernet/Baseband/Crypto device to IGB UIO module
> [52] Bind Ethernet/Baseband/Crypto device to VFIO module

These are just calling another script in usertools.

> [53] Setup VFIO permissions
> 
> ----------------------------------------------------------
>  Step 4: Other tools
> ----------------------------------------------------------
> [56] List hugepage info from /proc/meminfo
> 
> ----------------------------------------------------------
>  Step 5: Uninstall and system cleanup
> ----------------------------------------------------------
> [57] Unbind devices from IGB UIO or VFIO driver
> [58] Remove IGB UIO module
> [59] Remove VFIO module
> [60] Remove KNI module
> [61] Remove hugepage mappings

This script has bad quality and is very partial.
Are we sure we want to keep above parts?
What about adding separate scripts for VFIO permissions
or hugepage mapping and info?



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
  2020-08-05 16:26   ` Thomas Monjalon
@ 2020-08-05 17:46     ` Trahe, Fiona
  2020-08-05 18:26       ` Stephen Hemminger
  0 siblings, 1 reply; 15+ messages in thread
From: Trahe, Fiona @ 2020-08-05 17:46 UTC (permalink / raw)
  To: Thomas Monjalon, Yigit, Ferruh
  Cc: dev, david.marchand, arybchenko, Richardson, Bruce, stephen,
	ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal, bluca,
	ktraynor, honnappa.nagarahalli

+1 for keeping at least the huge-page setup  part - I use this all the time.

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
> Sent: Wednesday, August 5, 2020 5:27 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; david.marchand@redhat.com; arybchenko@solarflare.com; Richardson, Bruce
> <bruce.richardson@intel.com>; stephen@networkplumber.org; ajit.khaparde@broadcom.com;
> jerinj@marvell.com; maxime.coquelin@redhat.com; akhil.goyal@nxp.com; bluca@debian.org;
> ktraynor@redhat.com; honnappa.nagarahalli@arm.com
> Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
> 
> 05/08/2020 18:19, Ferruh Yigit:
> > On 8/4/2020 11:26 AM, Thomas Monjalon wrote:
> > > Environment configuration is the responsibility of distributions
> > > or upper-level frameworks.
> > > DPDK focus on documenting the requirements and some recommendations.
> > >
> > > Maintaining a good adaptative deployment setup is a project by itself.
> > > Anyway this script was interactive, useful only for experimenters.
> > >
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > ---
> > >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > > index ea4cfa7a48..7ce9fc3e4f 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -151,3 +151,7 @@ Deprecation Notices
> > >    Python 2 support will be completely removed in 20.11.
> > >    In 20.08, explicit deprecation warnings will be displayed when running
> > >    scripts with Python 2.
> > > +
> > > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > > +  ``make``. Given environments are too much variables for such a simple script,
> > > +  it will be removed in DPDK 20.11.
> > >
> >
> > Personally I use script as a shortcut to allocate hugemaps, and find that bit
> > useful.
> >
> > Agree that the environment configuration or deployment script is something else,
> > and not sure if this script ever claimed to be one, it is more a user helper
> > script I think.
> >
> > What do you think remove the build part, which depends to Make build system as
> > mentioned above, and keep the rest as a helper script (and perhaps rename to
> > highlight the intention), so basically keep only below part:
> >
> > ----------------------------------------------------------
> >  Step 2: Setup linux environment
> > ----------------------------------------------------------
> > [45] Insert IGB UIO module
> > [46] Insert VFIO module
> 
> It does not cover other kernel modules.
> 
> > [47] Insert KNI module
> > [48] Setup hugepage mappings for non-NUMA systems
> > [49] Setup hugepage mappings for NUMA systems
> 
> It does not use the standard hugepage directory.
> 
> > [50] Display current Ethernet/Baseband/Crypto device settings
> > [51] Bind Ethernet/Baseband/Crypto device to IGB UIO module
> > [52] Bind Ethernet/Baseband/Crypto device to VFIO module
> 
> These are just calling another script in usertools.
> 
> > [53] Setup VFIO permissions
> >
> > ----------------------------------------------------------
> >  Step 4: Other tools
> > ----------------------------------------------------------
> > [56] List hugepage info from /proc/meminfo
> >
> > ----------------------------------------------------------
> >  Step 5: Uninstall and system cleanup
> > ----------------------------------------------------------
> > [57] Unbind devices from IGB UIO or VFIO driver
> > [58] Remove IGB UIO module
> > [59] Remove VFIO module
> > [60] Remove KNI module
> > [61] Remove hugepage mappings
> 
> This script has bad quality and is very partial.
> Are we sure we want to keep above parts?
> What about adding separate scripts for VFIO permissions
> or hugepage mapping and info?
> 


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
  2020-08-05 17:46     ` Trahe, Fiona
@ 2020-08-05 18:26       ` Stephen Hemminger
  2020-08-06  9:35         ` Bruce Richardson
  0 siblings, 1 reply; 15+ messages in thread
From: Stephen Hemminger @ 2020-08-05 18:26 UTC (permalink / raw)
  To: Trahe, Fiona
  Cc: Thomas Monjalon, Yigit, Ferruh, dev, david.marchand, arybchenko,
	Richardson, Bruce, ajit.khaparde, jerinj, maxime.coquelin,
	akhil.goyal, bluca, ktraynor, honnappa.nagarahalli

On Wed, 5 Aug 2020 17:46:21 +0000
"Trahe, Fiona" <fiona.trahe@intel.com> wrote:

> +1 for keeping at least the huge-page setup  part - I use this all the time.

Huge page setup should be made its own script.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
  2020-08-05 18:26       ` Stephen Hemminger
@ 2020-08-06  9:35         ` Bruce Richardson
  2020-08-06 13:51           ` Kinsella, Ray
  0 siblings, 1 reply; 15+ messages in thread
From: Bruce Richardson @ 2020-08-06  9:35 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: Trahe, Fiona, Thomas Monjalon, Yigit, Ferruh, dev,
	david.marchand, arybchenko, ajit.khaparde, jerinj,
	maxime.coquelin, akhil.goyal, bluca, ktraynor,
	honnappa.nagarahalli

On Wed, Aug 05, 2020 at 11:26:13AM -0700, Stephen Hemminger wrote:
> On Wed, 5 Aug 2020 17:46:21 +0000
> "Trahe, Fiona" <fiona.trahe@intel.com> wrote:
> 
> > +1 for keeping at least the huge-page setup  part - I use this all the time.
> 
> Huge page setup should be made its own script.

Hugepage parameters should just be added to the kernel parameters in
/etc/default/grub and then forgotten about! :-)

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
  2020-08-06  9:35         ` Bruce Richardson
@ 2020-08-06 13:51           ` Kinsella, Ray
  2020-08-06 14:43             ` Thomas Monjalon
  0 siblings, 1 reply; 15+ messages in thread
From: Kinsella, Ray @ 2020-08-06 13:51 UTC (permalink / raw)
  To: Bruce Richardson, Stephen Hemminger
  Cc: Trahe, Fiona, Thomas Monjalon, Yigit, Ferruh, dev,
	david.marchand, arybchenko, ajit.khaparde, jerinj,
	maxime.coquelin, akhil.goyal, bluca, ktraynor,
	honnappa.nagarahalli

Suggest we keep the deprecation notice, 
and note that the script will be replaced with a specific script for hugepages?

Ray K

On 06/08/2020 10:35, Bruce Richardson wrote:
> On Wed, Aug 05, 2020 at 11:26:13AM -0700, Stephen Hemminger wrote:
>> On Wed, 5 Aug 2020 17:46:21 +0000
>> "Trahe, Fiona" <fiona.trahe@intel.com> wrote:
>>
>>> +1 for keeping at least the huge-page setup  part - I use this all the time.
>>
>> Huge page setup should be made its own script.
> 
> Hugepage parameters should just be added to the kernel parameters in
> /etc/default/grub and then forgotten about! :-)
> 

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script
  2020-08-06 13:51           ` Kinsella, Ray
@ 2020-08-06 14:43             ` Thomas Monjalon
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2020-08-06 14:43 UTC (permalink / raw)
  To: Bruce Richardson, Stephen Hemminger, Kinsella, Ray
  Cc: dev, Trahe, Fiona, Yigit, Ferruh, dev, david.marchand,
	arybchenko, ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal,
	bluca, ktraynor, honnappa.nagarahalli

06/08/2020 15:51, Kinsella, Ray:
> Suggest we keep the deprecation notice, 
> and note that the script will be replaced with a specific script for hugepages?

OK I send a v2 keeping acks from Maxime and Jerin.



> On 06/08/2020 10:35, Bruce Richardson wrote:
> > On Wed, Aug 05, 2020 at 11:26:13AM -0700, Stephen Hemminger wrote:
> >> On Wed, 5 Aug 2020 17:46:21 +0000
> >> "Trahe, Fiona" <fiona.trahe@intel.com> wrote:
> >>
> >>> +1 for keeping at least the huge-page setup  part - I use this all the time.
> >>
> >> Huge page setup should be made its own script.
> > 
> > Hugepage parameters should just be added to the kernel parameters in
> > /etc/default/grub and then forgotten about! :-)
> > 
> 






^ permalink raw reply	[flat|nested] 15+ messages in thread

* [dpdk-dev] [PATCH v2] doc: announce removal of interactive setup script
  2020-08-04 10:26 [dpdk-dev] [PATCH] doc: announce removal of interactive setup script Thomas Monjalon
  2020-08-04 10:30 ` Maxime Coquelin
  2020-08-05 16:19 ` Ferruh Yigit
@ 2020-08-06 14:51 ` Thomas Monjalon
  2020-08-06 16:23   ` Stephen Hemminger
  2 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2020-08-06 14:51 UTC (permalink / raw)
  To: dev
  Cc: david.marchand, arybchenko, ferruh.yigit, bruce.richardson,
	stephen, ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal,
	bluca, ktraynor, honnappa.nagarahalli

Environment configuration is the responsibility of distributions
or upper-level frameworks.
DPDK focus on documenting the requirements and some recommendations.
If some specific parts are complex, they can deserve some scripts.

Maintaining a good adaptative deployment setup is a project by itself.
Anyway this script was interactive, useful only for experimenters.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
---
v2: suggest replacing with more specific scripts
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 1a07f88172..fb405a09ac 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -232,3 +232,8 @@ Deprecation Notices
   Python 2 support will be completely removed in 20.11.
   In 20.08, explicit deprecation warnings will be displayed when running
   scripts with Python 2.
+
+* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
+  ``make``. Given environments are too much variables for such a simple script,
+  it will be removed in DPDK 20.11.
+  Some useful parts may be converted into specific scripts.
-- 
2.27.0


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce removal of interactive setup script
  2020-08-06 14:51 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
@ 2020-08-06 16:23   ` Stephen Hemminger
  2020-08-06 16:25     ` Thomas Monjalon
  0 siblings, 1 reply; 15+ messages in thread
From: Stephen Hemminger @ 2020-08-06 16:23 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, david.marchand, arybchenko, ferruh.yigit, bruce.richardson,
	ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal, bluca,
	ktraynor, honnappa.nagarahalli

On Thu,  6 Aug 2020 16:51:50 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> Environment configuration is the responsibility of distributions
> or upper-level frameworks.
> DPDK focus on documenting the requirements and some recommendations.
> If some specific parts are complex, they can deserve some scripts.
> 
> Maintaining a good adaptative deployment setup is a project by itself.
> Anyway this script was interactive, useful only for experimenters.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> v2: suggest replacing with more specific scripts
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 1a07f88172..fb405a09ac 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -232,3 +232,8 @@ Deprecation Notices
>    Python 2 support will be completely removed in 20.11.
>    In 20.08, explicit deprecation warnings will be displayed when running
>    scripts with Python 2.
> +
> +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> +  ``make``. Given environments are too much variables for such a simple script,
> +  it will be removed in DPDK 20.11.
> +  Some useful parts may be converted into specific scripts.

Do you want to add a nag at startup of dpdk-setup.sh in 20.08?
Users don't always read the deprecation notices.

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce removal of interactive setup script
  2020-08-06 16:23   ` Stephen Hemminger
@ 2020-08-06 16:25     ` Thomas Monjalon
  2020-08-06 16:56       ` Stephen Hemminger
  0 siblings, 1 reply; 15+ messages in thread
From: Thomas Monjalon @ 2020-08-06 16:25 UTC (permalink / raw)
  To: Stephen Hemminger
  Cc: dev, david.marchand, arybchenko, ferruh.yigit, bruce.richardson,
	ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal, bluca,
	ktraynor, honnappa.nagarahalli

06/08/2020 18:23, Stephen Hemminger:
> On Thu,  6 Aug 2020 16:51:50 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > Environment configuration is the responsibility of distributions
> > or upper-level frameworks.
> > DPDK focus on documenting the requirements and some recommendations.
> > If some specific parts are complex, they can deserve some scripts.
> > 
> > Maintaining a good adaptative deployment setup is a project by itself.
> > Anyway this script was interactive, useful only for experimenters.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> > v2: suggest replacing with more specific scripts
> > ---
> > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > +  ``make``. Given environments are too much variables for such a simple script,
> > +  it will be removed in DPDK 20.11.
> > +  Some useful parts may be converted into specific scripts.
> 
> Do you want to add a nag at startup of dpdk-setup.sh in 20.08?
> Users don't always read the deprecation notices.

Yes we could do that if this deprecation is accepted (missing an ack).



^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce removal of interactive setup script
  2020-08-06 16:25     ` Thomas Monjalon
@ 2020-08-06 16:56       ` Stephen Hemminger
  2020-08-06 17:02         ` Thomas Monjalon
  0 siblings, 1 reply; 15+ messages in thread
From: Stephen Hemminger @ 2020-08-06 16:56 UTC (permalink / raw)
  To: Thomas Monjalon
  Cc: dev, david.marchand, arybchenko, ferruh.yigit, bruce.richardson,
	ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal, bluca,
	ktraynor, honnappa.nagarahalli

On Thu, 06 Aug 2020 18:25:23 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> 06/08/2020 18:23, Stephen Hemminger:
> > On Thu,  6 Aug 2020 16:51:50 +0200
> > Thomas Monjalon <thomas@monjalon.net> wrote:
> >   
> > > Environment configuration is the responsibility of distributions
> > > or upper-level frameworks.
> > > DPDK focus on documenting the requirements and some recommendations.
> > > If some specific parts are complex, they can deserve some scripts.
> > > 
> > > Maintaining a good adaptative deployment setup is a project by itself.
> > > Anyway this script was interactive, useful only for experimenters.
> > > 
> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > > ---
> > > v2: suggest replacing with more specific scripts
> > > ---
> > > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > > +  ``make``. Given environments are too much variables for such a simple script,
> > > +  it will be removed in DPDK 20.11.
> > > +  Some useful parts may be converted into specific scripts.  
> > 
> > Do you want to add a nag at startup of dpdk-setup.sh in 20.08?
> > Users don't always read the deprecation notices.  
> 
> Yes we could do that if this deprecation is accepted (missing an ack).
> 
> 

Never liked dpdk-setup.sh anyway

Acked-by: Stephen Hemminger <stephen@networkplumber.org>

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [dpdk-dev] [PATCH v2] doc: announce removal of interactive setup script
  2020-08-06 16:56       ` Stephen Hemminger
@ 2020-08-06 17:02         ` Thomas Monjalon
  0 siblings, 0 replies; 15+ messages in thread
From: Thomas Monjalon @ 2020-08-06 17:02 UTC (permalink / raw)
  To: dev
  Cc: david.marchand, arybchenko, ferruh.yigit, bruce.richardson,
	ajit.khaparde, jerinj, maxime.coquelin, akhil.goyal, bluca,
	ktraynor, honnappa.nagarahalli, Stephen Hemminger

06/08/2020 18:56, Stephen Hemminger:
> On Thu, 06 Aug 2020 18:25:23 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > 06/08/2020 18:23, Stephen Hemminger:
> > > On Thu,  6 Aug 2020 16:51:50 +0200
> > > Thomas Monjalon <thomas@monjalon.net> wrote:
> > >   
> > > > Environment configuration is the responsibility of distributions
> > > > or upper-level frameworks.
> > > > DPDK focus on documenting the requirements and some recommendations.
> > > > If some specific parts are complex, they can deserve some scripts.
> > > > 
> > > > Maintaining a good adaptative deployment setup is a project by itself.
> > > > Anyway this script was interactive, useful only for experimenters.
> > > > 
> > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > > Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> > > > Acked-by: Jerin Jacob <jerinj@marvell.com>
> > > > ---
> > > > v2: suggest replacing with more specific scripts
> > > > ---
> > > > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially
> > > > +  ``make``. Given environments are too much variables for such a simple script,
> > > > +  it will be removed in DPDK 20.11.
> > > > +  Some useful parts may be converted into specific scripts.  
> > > 
> > > Do you want to add a nag at startup of dpdk-setup.sh in 20.08?
> > > Users don't always read the deprecation notices.  
> > 
> > Yes we could do that if this deprecation is accepted (missing an ack).
> 
> Never liked dpdk-setup.sh anyway

Me too

> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied




^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2020-08-06 17:02 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-04 10:26 [dpdk-dev] [PATCH] doc: announce removal of interactive setup script Thomas Monjalon
2020-08-04 10:30 ` Maxime Coquelin
2020-08-04 10:33   ` Jerin Jacob
2020-08-05 16:19 ` Ferruh Yigit
2020-08-05 16:26   ` Thomas Monjalon
2020-08-05 17:46     ` Trahe, Fiona
2020-08-05 18:26       ` Stephen Hemminger
2020-08-06  9:35         ` Bruce Richardson
2020-08-06 13:51           ` Kinsella, Ray
2020-08-06 14:43             ` Thomas Monjalon
2020-08-06 14:51 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-08-06 16:23   ` Stephen Hemminger
2020-08-06 16:25     ` Thomas Monjalon
2020-08-06 16:56       ` Stephen Hemminger
2020-08-06 17:02         ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git