From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BB1D41BE21; Fri, 21 Dec 2018 16:33:37 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 315DC20BE3; Fri, 21 Dec 2018 10:33:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 21 Dec 2018 10:33:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=aJ/oxQw2iu4/fg8DsMgI+ER7cFaSgDq2/wNBRJmJWkk=; b=OAP5SJ74LTZh dkPKwYRrWcNjLf65HUfpayoo6kMfwYdB28A2XQ2wdauU/Q8jzlfOczq7kkEYGFRm 7QkT9evaaCdVLB7mtrXJ5B5bNMi2Z3HG4Ke9uX0dOQVMeU7fkaW1LQHMBG8peoyf B+crPVwRiDfUrVctkmeEE2HK8ax+//4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=aJ/oxQw2iu4/fg8DsMgI+ER7cFaSgDq2/wNBRJmJW kk=; b=XjPyDPWYIgn/6lQ+d8fEku6Qg7BgXzeNqHcD1MT5hUINoSAxaOBmFuHGa Vf5b2THCUNmdMnkc7S2YYX02NzOPgYWr0JC0m+bDcts0SlTXRgscXfBjPlv7QwtT z/1vrV0OnX6yTJ4MIFyCycZS5XVoUlOm5+ze5uvaHW9hC/3r+UnkJ5WMOEw73xm9 T7Ec55fNTgCVliNggTdACVmC56hAQtcApKnVpCwO7aYOwjdZ6+CpTDQseD+fzJ+K vXTYOqw8TyU0ME2LZeRGr2xPYXnQpS1tq51AZTBJDY+Lxd95BwHlG1PZ6H2YNZ6e hQBWkw66+W0ydQA9nNqF94Z4lQRtg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejhedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DBAC1E436E; Fri, 21 Dec 2018 10:33:35 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: stable@dpdk.org, "Laatz, Kevin" , dev@dpdk.org Date: Fri, 21 Dec 2018 16:33:34 +0100 Message-ID: <4468033.Rs7KMS8u4G@xps> In-Reply-To: <9610a05b-bac2-a964-bbd2-44492ae1da03@intel.com> References: <20181219115950.46386-1-bruce.richardson@intel.com> <9610a05b-bac2-a964-bbd2-44492ae1da03@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] telemetry: fix error when using ports of different types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2018 15:33:38 -0000 21/12/2018 14:27, Laatz, Kevin: > On 19/12/2018 11:59, Bruce Richardson wrote: > > Different NIC ports can have different numbers of xstats on them, which > > means that we can't just use the xstats list from the first port registered > > in the telemetry library. Instead, we need to check the type of each port - > > by checking its ops structure pointer - and register each port type once > > with the metrics lib. > > > > CC: stable@dpdk.org > > Fixes: fdbdb3f9ce46 ("telemetry: add initial connection socket") > > > > Signed-off-by: Bruce Richardson > > Acked-by: Kevin Laatz Applied, thanks