From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94552A00C4; Sat, 16 Jul 2022 23:28:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3479640DF6; Sat, 16 Jul 2022 23:28:43 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id BEE1B40A87 for <dev@dpdk.org>; Sat, 16 Jul 2022 23:28:41 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D44E85C0098; Sat, 16 Jul 2022 17:28:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sat, 16 Jul 2022 17:28:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658006920; x= 1658093320; bh=w27VreU1lIDdPIRLduR/3uub1WgDWhJeS5eysVpW21o=; b=0 CJaMznED2LWnfdZd4VYQFJzedTrpid7ChEXVydEiPIboJpmidBMqLw1HkOef59NS 2yerRXCBSgkULBlFQ7Lx2zR1/8OOTUVEMwilWK1fhBJXbY8a7iWnuU5Ffho52dKn ZnJgJ0DzneJ5bAkEpT0JYHwIrwUwALrn9JwQtWD8hCkI6Qjj8r37SYGXn388nMWh 7bcMj0GfE2Wem6/OcfsqDAD7/d6k5USqUhNnWnm7AB2gp+hLk+TRxkR81Uwjscqx XnKqdwxiy7tttHoZtmaEB7E2xFQtyU8yX34/D4sTWlZJCiOvBaoDBO0kmcFUMiJ8 ucFgphKxZrFOip5fT3YRg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658006920; x= 1658093320; bh=w27VreU1lIDdPIRLduR/3uub1WgDWhJeS5eysVpW21o=; b=r JI/i+q/wFBjE0mpWTsqhpDz8UrqHFduwIqJ7k8I041SbN93aq2m5A0ngVVf8M9WD yvDXN+NhgN3HgFILTr1ItoBhEAqlmKNVjnkXPqOi1jedzrVgnJpRKClp9hkvSWta 90yxHbxTfqwA+MHYuXxhofYVTp5lPxBK02DREW0Qun2qk4r2+BTjYTcw+EGy7GxQ E+bKzfGxdQw0A3yTYpNtnkuKJullrZeQoLMOTDQZcY7oW/pz2yzHcMdOBKMSG28u Q7CJpeMdCV8iQzeRi1bfM2SyuzQgY3wtJj9Jyrg1k0Fa/ethwDfJxepaiSJi/JND ZbLMOuemx+My/uOiS+kdA== X-ME-Sender: <xms:iC3TYqh8VnfdxMzuhqPyNREKC0esCaMQUcL3IcxDgZQvYEJDHqDzsw> <xme:iC3TYrAfqGboo30BTVaWNqSXfn8WCj9MCwTbSUOT7VtNMQk20i6VFWjN9c_PrGYnv j_Nw-JXSdPriPBQTg> X-ME-Received: <xmr:iC3TYiH2rY-1HZLuqKDnhh5vbpg5w4beTLtAp61eVuwCMevcLHvH8DTl-EH8No63M3uZQoAy2FR96UoWuI1g_SdPAQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekfedgudeigecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: <xmx:iC3TYjTegkHTG84yTMqa_rC0JiY-L0mD_2I_dO5Odi9DD-d6d-S6_g> <xmx:iC3TYnwYj6SPTUsnezB66U_40OPv6e7FHiQJgCsdMbAP2gTvCZmAjQ> <xmx:iC3TYh5xIzwxf4SlbsiJHT0kzJYedNQpQmVotRrinO9W_ggNH6kQnA> <xmx:iC3TYvfzm_R436SJ9hzP_oZc4gu-vR9EaHwLs5wQIblKp_HTzmd8WQ> Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Jul 2022 17:28:38 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Xuan Ding <xuan.ding@intel.com> Cc: mdr@ashroe.eu, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@xilinx.com, viacheslavo@nvidia.com, dev@dpdk.org, stephen@networkplumber.org, mb@smartsharesystems.com, qi.z.zhang@intel.com, asekhar@marvell.com, pbhagavatula@marvell.com Subject: Re: [PATCH v2] doc: announce header split deprecation Date: Sat, 16 Jul 2022 23:28:36 +0200 Message-ID: <44812611.fMDQidcC6G@thomas> In-Reply-To: <20220715203055.64074-1-xuan.ding@intel.com> References: <20220523142016.44451-1-xuan.ding@intel.com> <20220715203055.64074-1-xuan.ding@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org 15/07/2022 22:30, xuan.ding@intel.com: > From: Xuan Ding <xuan.ding@intel.com> > > RTE_ETH_RX_OFFLOAD_HEADER_SPLIT offload was introduced some time ago to > substitute bit-field header_split in struct rte_eth_rxmode. It allows > to enable per-port header split offload with the header size controlled > using split_hdr_size in the same structure. > > Right now, no single PMD actually supports RTE_ETH_RX_OFFLOAD_HEADER_SPLIT > with above definition. Many examples and test apps initialize the field > to 0 explicitly. The most of drivers simply ignore split_hdr_size since > the offload is not advertised, but some double-check that its value is 0. > > So the RTE_ETH_RX_OFFLOAD_HEADER_SPLIT and split_header_size field > will be removed in DPDK 22.11. After DPDK 22.11 LTS, the > RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT can still be used for per-queue Rx > packet split offload, which is configured by rte_eth_rxseg_split. > > Signed-off-by: Xuan Ding <xuan.ding@intel.com> > Acked-by: Ray Kinsella <mdr@ashroe.eu> > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> > Acked-by: Ferruh Yigit <ferruh.yigit@xilinx.com> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> Acked-by: Thomas Monjalon <thomas@monjalon.net> This v2 is a lot better for the users to understand what happens. Fixed the indent and moved few words: * ethdev: Since no single PMD supports ``RTE_ETH_RX_OFFLOAD_HEADER_SPLIT`` offload and the ``split_hdr_size`` field in structure ``rte_eth_rxmode`` to enable per-port header split, they will be removed in DPDK 22.11. The per-queue Rx packet split offload ``RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT`` can still be used, and it is configured by ``rte_eth_rxseg_split``. Applied, thanks.