From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FAB5A034F; Wed, 11 Aug 2021 12:19:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 516A740042; Wed, 11 Aug 2021 12:19:51 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 7BA2840040 for ; Wed, 11 Aug 2021 12:19:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="276132187" X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208,217";a="276132187" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Aug 2021 03:19:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,311,1620716400"; d="scan'208,217";a="571097381" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 11 Aug 2021 03:19:41 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 11 Aug 2021 03:19:40 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 11 Aug 2021 03:19:40 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 11 Aug 2021 03:19:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LpruYcxqyGMUDkYWlxnEFcmI7ehdpBOAY6OEI6jT44Sb0dvN1du0EIpoJwwVwHwHCwplBpGbKxd6uu0/7DpLGHUfBPFhd+dUAEbB6LQwBQZYlHfJQ7Lk91Yyr/iOV/IDsR+R6kkzhnsN7Vh5CMPES4uYj8qmfz+dHurPxCknJW6mX6gQWSrjDpGRIJKnmwTOAKdB0MJvDTJZ4PvLPDlYUOpGJB+OMh/N7ekP87WshpeehZnUeNbnZS9BejbZ5LZg/sAmG/tZVWnjsXF4OZrx2usY/MYHDuHgnRb1AvZ2ZOdx3AtDFSlbjKEF5hRh1Z+QtIJdhVbhgMyb8KN9IV6o+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q0qUZgH7z3AYqL+k/vqa/ht/FATghP4qkENRRPfLqvE=; b=NDvKTtWHG08BDfv1s3zpUN4uqnlX44+O4Ntki1Ekpy5EZwTwgEWJalTI5dTC1AG36R6q9vZ1wA997ZkxRn6/zm4c3LehNLl73giXAI7yhanlVG4hxartRFVnDOce0rF0H/q0l20p1qB/gI9ijqz8/IC0VjyVja91vRRH3zMCYD50+DERNpvggUv6jkA5KVxKCMBRRYgF6C0ZlBWIcoe8NpTXLHC5EOMtshTMyIIKj3fXL5X0FmK8EKYZwYTT42OViZqOrB8OPstfQngGczyAkoZ2+km8P/wuZ7zje7N7o1bmTxzPiFOTQeVYzrQbnfWmlC5WPPWdBs1qpmMsEpnFNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q0qUZgH7z3AYqL+k/vqa/ht/FATghP4qkENRRPfLqvE=; b=KmREgnm/iGo53B6HX1fU9mnjsGQ2Wj3S8bA0kWLgW1LpsFgzftEH/gIhD2whZTqn0WO+WPRkM9b3fkSH5P0ofTDI2Nd0r0QjC1fss4RjYFsB4I7rTwkGzgfUT6d/RxHNNoGr273gmgdl4dH3ELXWXMhVKfV9HqHnw6+8x3EvAMM= Authentication-Results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; Received: from BN6PR11MB1474.namprd11.prod.outlook.com (2603:10b6:405:c::17) by BN6PR11MB4049.namprd11.prod.outlook.com (2603:10b6:405:7f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.21; Wed, 11 Aug 2021 10:19:39 +0000 Received: from BN6PR11MB1474.namprd11.prod.outlook.com ([fe80::7cde:47ff:b54e:9e11]) by BN6PR11MB1474.namprd11.prod.outlook.com ([fe80::7cde:47ff:b54e:9e11%12]) with mapi id 15.20.4394.023; Wed, 11 Aug 2021 10:19:39 +0000 To: CC: , , , "Sachin Saxena" , Vanshika Shukla References: <20210727092523.22718-1-rohit.raj@nxp.com> From: "Singh, Aman Deep" Message-ID: <4481d0de-e691-110b-1dc4-fd7218a86d30@intel.com> Date: Wed, 11 Aug 2021 15:49:28 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 In-Reply-To: <20210727092523.22718-1-rohit.raj@nxp.com> Content-Language: en-GB X-ClientProxiedBy: PN0PR01CA0037.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:49::17) To BN6PR11MB1474.namprd11.prod.outlook.com (2603:10b6:405:c::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.18] (223.178.213.111) by PN0PR01CA0037.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:49::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14 via Frontend Transport; Wed, 11 Aug 2021 10:19:36 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b610150-988d-4d95-51de-08d95cb186c4 X-MS-TrafficTypeDiagnostic: BN6PR11MB4049: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:483; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UQGyeswh64c+MhO17+4nQA9zLm/kQd+PmwPsZeGPhlBRFzr0+j+kPp61jHULA5lWj8iAoYxLl3IhcDHmKajx4zzBKs14nY23eslV76vKDC2/BPwV0KmgD4pWAZhgYj/gooTGJhq3wk4d0xHyj/xLUsD+fGYjzKfzx0/L8NQBPGo98b2pgEV8ZG9TCGYGD6paKsWkt+UKu5DYH9TIJ5kqYDGeiwuOerFshio1gw7IvldzEDzp4DT2SaMYalZppm4aAQQU777K+H0VmZtnTkZ8CfpgnCFifpH7Fl5+FVtR8h2r55EnBMtp5N7oIX1UfeX5F+38fN5Qd2R30q2wlqxYixwxc86qdulRbbGghhgpCFIFEtaIh+2+LNYsfS7Qs32eIyLJfmvPg3yI9+0EdkAIIZcCAxlte+Vd2yeeMV8CaEbf+HNlTQCB4TGgNISR3Af1GeOs7WcfgrzqZrxyaAYJfOblE+AOOZNGy7gzWtK2ffVkh+yFnm0vvQ7X1jnqiFPvGJZlbzOsxMLqI8Ai409RoSYlJr8bK0x2Y3jahtrifC2QqjG5+dp/ijxlHEJ7ug2D5dArii8RrF81FdmSM47LJKEEewwkxrNqeK2vkH1Rlcbd/vjqJ0eBjTC4d06BNKV4UPnpcQkvrTJNZR29Ti03MXilca5MtDPC65fZpXEDkRSOUYnLt3/TmcWUNAw49FYWlS4Y7aNfHmoysT2X0BPLP1jz6RAWygok7TJa4Cqhsn0= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR11MB1474.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(136003)(39860400002)(396003)(346002)(186003)(83380400001)(53546011)(6916009)(5660300002)(26005)(6666004)(6486002)(86362001)(36756003)(316002)(16576012)(8936002)(8676002)(38100700002)(478600001)(54906003)(66946007)(66476007)(66556008)(33964004)(2616005)(956004)(2906002)(31686004)(4326008)(31696002)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TnlFS1QvTjEzN2VLSCt3ZnJmdlVFVHRlTFo4dnlnYlc1ZnFhWlNOZ1ZXNHZE?= =?utf-8?B?SUtVc0UvbFJJbXNQSVhOU1hyTnVHcm4xZWVMMnJSbFBRNGVmLzVib1o0RXBt?= =?utf-8?B?dGgwSGs2RXlUaWYzUzhTaStyN1o3c1djVUpPSU4yRU05blFWRkMycytQaEVv?= =?utf-8?B?MUZLbHhmSHZ6czhRSXdFTFViSHZncWl5bVNoRnlUWGh3UmVTeDl2UUEwcWxH?= =?utf-8?B?U2M2eDFEYVQrOWErNFUvUVhFbWVwd09KRU8wMWMxeTZhOEJpck1WdjlMQmpX?= =?utf-8?B?ZUljOU80L1M5WUl1Yjd6cHg3dW9xZ1lzdytSbVJ3SUxTeVQzM1FJZUxHY2dF?= =?utf-8?B?eFY4V2hMYitra1NKZWRVbUVCc2w5RXlIYmRXa1NtQjhWVngxQUVjRWRJZHJV?= =?utf-8?B?cUduZ0FqUmVjRFAxNVB6czlwSUQ5WUEvbnNzZTN0M0tsU1NIaXBOQWsvWC9w?= =?utf-8?B?WWRudXp5cmNaMUZyd3RJL1FvdWJKYjd6Z1lRcmZUK25PSmM4TUNLNVhHRC9t?= =?utf-8?B?MHN0MFZoRnhDK3pWWStOeUMwcHk4OGNCLzlmVjF4YW16dUtROGovRGF3KzJB?= =?utf-8?B?Zk1hSDRSeUlXYVMyekJVL1paUUM4akU3WFZ6a1ViTU9DUzBWUStyNnV6alAw?= =?utf-8?B?SVJyWlBPNE9qV2ZHczZtREJsY2crendtNVBaK29pT1NTaGd0cCtjRXdGOWt0?= =?utf-8?B?Wk0rdHNEenJEeWtlRllCNng2b1d5QTZsR2l3UE9GMG41cXJrU2VzNVcwNEZF?= =?utf-8?B?TlRieWlKWkdFQnY3OWoxc2laajlBaC8rVHlXNU9PVm4xblBISUdWdHNyOG1r?= =?utf-8?B?RHBLU3BYejgrdFhNU2dFcEJ0TXJ5YTZGWXNSQmQvOEF4TEVNUDZnL3lPTW1w?= =?utf-8?B?YWloQlc2UG5EZ2JXVCtLRGQrSlYwbFd0SUlnOHYzTlVoWm03SkUzMlM0ZUlE?= =?utf-8?B?bGI4NGRxZ0NEMERkeENHbVEwVm8yajlSM1ZGRUJXSWk3NkRkWFpvaElTeGFS?= =?utf-8?B?V3JjQjJiNjhnTis1cGtPMm8ySHkyRkFGVjc4UzVXNHZLTVZrNHo1N01id2t5?= =?utf-8?B?RjZBcko2cDlqRVpNN3hnb2krOStxdWRQQldaZnJwN3J1RGdvNEpiWDNwT2xD?= =?utf-8?B?V1p2TWZ4STBFSlBUYTVFenp2NFFEZ3kzYitxWWN6bkZUYks2eW5XME5pd1o2?= =?utf-8?B?OEZmeEpoVkxpTTRSMytiVW01RS8zVkx4VStEZFlCTS9ScFFoYW1pSzJRNjBm?= =?utf-8?B?REYzeEZGVVp6ZEFzQ21iQUVLNTV4RDY5UHNaYUxqaVlDdSsxNS9NK2s0cmZp?= =?utf-8?B?QzZGSFd6dm40MDlkd05MZUtoakZoc0ttM2lWSTNCbVlQdmduU1l6ZVg1THhy?= =?utf-8?B?NVlDT2lpckpwSDlwY1NaTU5sRmhOaE01SnFsc1BXbkozWm9jSGw0K3UyU29O?= =?utf-8?B?ZDBDaWlvQVhYQzRTR3BhdU93ZjZleUpxc0hmYkxnMzNSWWdPUFRPUzQ3bkpT?= =?utf-8?B?dytWdEllVEJ2VXBZQmhucEdFSU8wank1YzNzT1dRWDMzWHZaTmtRcDJESlBU?= =?utf-8?B?U0FRUHRpVmMvbVRDbWdkMUdUU25NaEcreDA2R2dJRU1ZcHFDY3U5L3A2dXl1?= =?utf-8?B?NDdDaHNFY25ZNDBzMzZBNEJ1dElPNjdVSzFkTmZFdXBVcnZMazJCeTk1WEtM?= =?utf-8?B?RktHT0ovYy9Jd0hLRzBYaExEbDNJOGVHRnhGSEtJY0haWlZ1bFlEZkFFaVFv?= =?utf-8?Q?FrZv7FsdBS4c29P2x4tlftoPmjWNyrywMAg2VGl?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7b610150-988d-4d95-51de-08d95cb186c4 X-MS-Exchange-CrossTenant-AuthSource: BN6PR11MB1474.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2021 10:19:39.3823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jdPhaOgeTeIjjZHKZ9DvoYvHoKSd9kL2VCL3qGv56V1tFabBHAyEzkuCyDrnJA91L0fweK+49PvvGEMjhcTWDCHgOb0HDFNLUpYbe240XD0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4049 X-OriginatorOrg: intel.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd: fix jumbo packet drop issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Rohit, On 7/27/2021 2:55 PM, rohit.raj@nxp.com wrote: > From: Rohit Raj > > l3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is > not able to store packets with size greater than 2KB, hence these > packets are dropped. > > This patch fixes this issue by enabling scatter for jumbo packet, if > it is supported by NIC. > > If scatter is not supported by NIC and max jumbo packet length is > greater than default mbuf data size, then application exits with > proper error message. > > Fixes: f68aad7904f ("examples/l3fwd: update") > > Signed-off-by: Rohit Raj > Signed-off-by: Sachin Saxena > Signed-off-by: Vanshika Shukla > --- > examples/l3fwd/main.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c > index 4cb800aa15..6aaaa8ecb5 100644 > --- a/examples/l3fwd/main.c > +++ b/examples/l3fwd/main.c > @@ -1035,6 +1035,20 @@ l3fwd_poll_resource_setup(void) > "Error during getting device (port %u) info: %s\n", > portid, strerror(-ret)); > > + /* Enable Receive side SCATTER, if supported by NIC, > + * when jumbo packet is enabled. > + */ > + if (local_port_conf.rxmode.offloads & > + DEV_RX_OFFLOAD_JUMBO_FRAME){ > + if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_SCATTER) > + local_port_conf.rxmode.offloads |= > + DEV_RX_OFFLOAD_SCATTER; > + else if (local_port_conf.rxmode.max_rx_pkt_len > > + RTE_MBUF_DEFAULT_DATAROOM) > + rte_exit(EXIT_FAILURE, > + "Max packet length greater than default MBUF size\n"); > + } > + > if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) > local_port_conf.txmode.offloads |= > DEV_TX_OFFLOAD_MBUF_FAST_FREE; Acked-by: Aman Deep Singh