From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF7D54247D; Tue, 24 Jan 2023 16:24:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7D3040150; Tue, 24 Jan 2023 16:24:07 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id E6186400EF for ; Tue, 24 Jan 2023 16:24:06 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 89C135C053D; Tue, 24 Jan 2023 10:24:06 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 24 Jan 2023 10:24:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1674573846; x= 1674660246; bh=N1m6grBauu773rQJcIAawxbVEmQoUA3yvVajoKOQMOw=; b=r qC0u6xTDAMY4C/+87J2YZKbW3Yy87FPs6ftUIbiFWsqoSi3cS9xeLoEXjgKIWwsW TxqXGD4VuNuCJGzYkEDVfgzeGg0Do4HMiXiHn7uQdWYLP+0Iod6lmUGmPniYKfmo /NGs5WDP/X9DIP78pJjk07EBGnybJzbWIZphDh9760Kkd/rmI1dAVTvNt3myjVuc I7daDNmF0o14G2WlC+nZJL/uLk1D4ZUT1E49Jfj/9sii/Qu557SCqNjtodPlGhtG hIdAJ0GSZMI5DVAA4yQ9FA7jIw2YD7ZAxvrxJZznFouzKEDd1ZJaWIKjZCxnaS5n lfqRSViUmKMPRPCcIGg6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1674573846; x= 1674660246; bh=N1m6grBauu773rQJcIAawxbVEmQoUA3yvVajoKOQMOw=; b=p e2YUXaYzYun6k3KgKPCp+78DSTFRdYiOf5B0+ycF3PbLDIHoKbFOB36CBwHRDwdJ vpYDWCApCxXhfWoMXlPzwbbF97A2LZvA10+kHyvf7cRQyk4v6lH9hi69YDViSKPV KMXYvLa+L06aUj6NlDdHSWhCKM+2pqEjIxqrF7eM11ocUmmFpBlE3oDSVFetfmcg CAqaSkhDb4YOy36HjX5uaAT4tOG/+SVpjk0kHgLkNHLeiYaPrFrzDHetNZeH5a06 273Fc8HhNqk1H/+a+C86Yku3eN2RxgiytcarXOqFyBrFOy2R1e4ZQPz9vQd9lI6a MpS7CwBtr1sSK+04FAW/w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvtddgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkfgjfhgggfgtsehtqh ertddttddunecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghs sehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrthhtvghrnhepfefhjeeluedvvedtud dtuedtvefhieejtefhffeujefhteduudevtdektdeikeffnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonh drnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 24 Jan 2023 10:24:05 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff Cc: dev@dpdk.org, david.marchand@redhat.com, jerinjacobk@gmail.com, mb@smartsharesystems.com Subject: Re: [PATCH v7 2/5] eal: remove thread getname API Date: Tue, 24 Jan 2023 16:24:04 +0100 Message-ID: <4488102.Fh7cpCN91P@thomas> In-Reply-To: <1674502774-20253-3-git-send-email-roretzla@linux.microsoft.com> References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1674502774-20253-1-git-send-email-roretzla@linux.microsoft.com> <1674502774-20253-3-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 23/01/2023 20:39, Tyler Retzlaff: > Remove the rte_thread_getname API. The API is __rte_experimental and > requires no deprecation notice. You should give a justification in this commit log, and note the removal in the release notes (removed items). > Fold the platform specific variants into the one place it is used as a > special case to retain the functionality for linux only. >=20 > Adjust the function as follows. >=20 > * reduce scope where thread_get_name can be used to eal_common_trace.c > * change the return type to void since the return value is not > consistent reportable depending on glibc version. > * change the thread id type to be rte_thread_t. >=20 > Signed-off-by: Tyler Retzlaff >=20 > Acked-by: Morten Br=F8rup > Acked-by: Jerin Jacob Note: no space before acks.