From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0AD5A04E7; Tue, 3 Nov 2020 01:30:38 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 062ED5AA6; Tue, 3 Nov 2020 01:30:37 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id C622F5AA4 for ; Tue, 3 Nov 2020 01:30:35 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 86C97C58; Mon, 2 Nov 2020 19:30:33 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 02 Nov 2020 19:30:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= u3ymRN5Ho9nC5exdgof8l2+zR4twlsFS6DnDflWavII=; b=U10Bi9D51DNCi3J2 +yCEJRcP6felwfaJ0D4FnoegIqZ/H9mvWcQvcyXoJTbgYhlyo80RxpgmG3RwqkBF NmTsRoT0WXL3lCC3fcrOJFUC7vFZjIHaSpMhONK1/Dm/VbWXhGHsdrFj8e3Lb5SD myVYisshfw54T7PwwECvHYNwl1nO4yPuMumOe3q65bb8hPZt9vJezyUe268CDtLa KZju69JNpq9dPuY4yM9q0mTf5UhLcM0Pxnpq0xDxofoNb4NCk+5+zgw9sShFcSxS 0f96t7AmmJYEimqp7uG4v4FsutwwbVCGfGspB2BueLDOT3zmWu3+uVga9lUAOs0x KWpxKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=u3ymRN5Ho9nC5exdgof8l2+zR4twlsFS6DnDflWav II=; b=GzTWWY7jmKkRE9y9bGZ8i/MPS33lVlyd8r7vXmg51lUH1jf1gXNBgHjJo aS7m50tZYAu5c83ld9MQNGAcsIGXReEj7ti3fAu2GKRgz3ahTmfXQR4M6njDECgq H7DdGZX1bZGqgAbTYI6b0SHIS5q/o+IzREF5qW6j/8E/lyC3vm8ep7F9AJPtHXxI nOqAN6qiFRptT9OYwy+nbTY78Dqk65x3l4EyRJpccniRdZZS4iORV2tJozMYNmsc Qj2XE/+xr3hROw620veiago2gGsFj7uLSdyTz7FPQ2wRw1FNeh2w/hv+O7EFfQJT Cc3TW0hOmu/+LX4hl5KSMtxn7zx+g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtvddgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepffdvffejueetleefieeludduuefgteejleevfeekjeefieegheet ffdvkeefgedunecuffhomhgrihhnpeguphgukhdrohhrghenucfkphepjeejrddufeegrd dvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhf rhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C4C103064682; Mon, 2 Nov 2020 19:30:31 -0500 (EST) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, Guy Kaneti , Luca Boccassi , Rosen Xu , Andrew Rybchenko , David Marchand Date: Tue, 03 Nov 2020 01:30:30 +0100 Message-ID: <4495149.WBtOTWmHy8@thomas> In-Reply-To: References: <20201102174507.1085128-1-bruce.richardson@intel.com> <20201102174507.1085128-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/8] regex/octeontx2: fix unnecessary name override X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/11/2020 20:48, David Marchand: > On Mon, Nov 2, 2020 at 6:45 PM Bruce Richardson > wrote: > > > > Since the device class is now part of the standard filenames, it's no > > longer needed in name overrides in specific drivers. > > > > Fixes: a20b2c01a7a1 ("build: standardize component names and defines") > > > > Signed-off-by: Bruce Richardson > > Equivalent to https://patchwork.dpdk.org/patch/81961/ but maybe better > to skip setting fmt_name when it is the same as the default value. [...] > > -name = 'octeontx2_regex' But it is not the same? The name will default to "octeontx2", which is fine. But the fmt_name should not take this default. I believe fmt_name should be "octeontx2_regex" as I did in my patch.