From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5729C1B576; Wed, 17 Apr 2019 02:46:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 17:45:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,359,1549958400"; d="scan'208";a="134960666" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 16 Apr 2019 17:45:57 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 17:45:58 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 17:45:58 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.92]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 08:45:56 +0800 From: "Wang, Ying A" To: "Zhang, Qi Z" , "Lu, Wenzhuo" , "Yang, Qiming" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/ice: code clean Thread-Index: AQHU8TiI+DTi8zL2jUO3rVyQR3JVG6Y8qTuAgALhRZA= Date: Wed, 17 Apr 2019 00:45:55 +0000 Message-ID: <44DE8E8A53B4014CA1985CEE86C07F2A0B915E9C@SHSMSX101.ccr.corp.intel.com> References: <1555077139-244831-1-git-send-email-ying.a.wang@intel.com> <1555077139-244831-2-git-send-email-ying.a.wang@intel.com> <039ED4275CED7440929022BC67E7061153368A6F@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153368A6F@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjJlMWUyZGEtZmViNi00YWEwLWFmYmEtMzU3YjcxZjE3YjY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoielNiZGFpd0V6Y0ZoQmNGYUVJNHBkNnNHSDhLNWtTd003dnFrUElVUzg3dXM4VUVPT3lyeDRFSWdaTXdLOXFadSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: code clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2019 00:46:01 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, April 15, 2019 8:44 PM > To: Wang, Ying A ; Lu, Wenzhuo > ; Yang, Qiming > Cc: dev@dpdk.org; Wang, Ying A ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] net/ice: code clean >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang Ying A > > Sent: Friday, April 12, 2019 9:52 PM > > To: Lu, Wenzhuo ; Yang, Qiming > > > > Cc: dev@dpdk.org; Wang, Ying A ; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH 1/2] net/ice: code clean >=20 > Better to change title to "fix wrong type", since it's actually a bug fix= . OK, will modify it. > > > > Variable "status" should be difined as "int" instead of "uint_16t". > > This patch fixes the issue. >=20 > Some typo >=20 OK, will modify it. > > > > Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wang Ying A > > --- > > drivers/net/ice/ice_ethdev.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ice/ice_ethdev.c > > b/drivers/net/ice/ice_ethdev.c index 9d01018..72831bb 100644 > > --- a/drivers/net/ice/ice_ethdev.c > > +++ b/drivers/net/ice/ice_ethdev.c > > @@ -2753,7 +2753,7 @@ static int ice_macaddr_set(struct rte_eth_dev *de= v, > > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > struct ice_vsi *vsi =3D pf->main_vsi; > > uint8_t pmask; > > - uint16_t status; > > + int status; >=20 > Can we use enum ice_status directly here? > Since I saw it will be compared with a enum value ICE_SUCCESS later. >=20 OK, will change to enum ice_status. > > > > pmask =3D ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX | > > ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; @@ - > 2769,7 > > +2769,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, > > struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > struct ice_vsi *vsi =3D pf->main_vsi; > > - uint16_t status; > > + int status; > > uint8_t pmask; > > > > pmask =3D ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX | @@ > > -2787,7 +2787,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, > > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > struct ice_vsi *vsi =3D pf->main_vsi; > > uint8_t pmask; > > - uint16_t status; > > + int status; > > > > pmask =3D ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; > > > > @@ -2802,7 +2802,7 @@ static int ice_macaddr_set(struct rte_eth_dev *de= v, > > struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > struct ice_vsi *vsi =3D pf->main_vsi; > > - uint16_t status; > > + int status; > > uint8_t pmask; > > > > if (dev->data->promiscuous =3D=3D 1) > > -- > > 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 79331A00E6 for ; Wed, 17 Apr 2019 02:46:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C8E841B577; Wed, 17 Apr 2019 02:46:01 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5729C1B576; Wed, 17 Apr 2019 02:46:00 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2019 17:45:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,359,1549958400"; d="scan'208";a="134960666" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 16 Apr 2019 17:45:57 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 17:45:58 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 16 Apr 2019 17:45:58 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.92]) with mapi id 14.03.0415.000; Wed, 17 Apr 2019 08:45:56 +0800 From: "Wang, Ying A" To: "Zhang, Qi Z" , "Lu, Wenzhuo" , "Yang, Qiming" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/2] net/ice: code clean Thread-Index: AQHU8TiI+DTi8zL2jUO3rVyQR3JVG6Y8qTuAgALhRZA= Date: Wed, 17 Apr 2019 00:45:55 +0000 Message-ID: <44DE8E8A53B4014CA1985CEE86C07F2A0B915E9C@SHSMSX101.ccr.corp.intel.com> References: <1555077139-244831-1-git-send-email-ying.a.wang@intel.com> <1555077139-244831-2-git-send-email-ying.a.wang@intel.com> <039ED4275CED7440929022BC67E7061153368A6F@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153368A6F@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjJlMWUyZGEtZmViNi00YWEwLWFmYmEtMzU3YjcxZjE3YjY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoielNiZGFpd0V6Y0ZoQmNGYUVJNHBkNnNHSDhLNWtTd003dnFrUElVUzg3dXM4VUVPT3lyeDRFSWdaTXdLOXFadSJ9 x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] net/ice: code clean X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190417004555.e6ieqacpV9_5RW-Cwk61j8JnYjqEUoyJXvv5lpIHR8M@z> > -----Original Message----- > From: Zhang, Qi Z > Sent: Monday, April 15, 2019 8:44 PM > To: Wang, Ying A ; Lu, Wenzhuo > ; Yang, Qiming > Cc: dev@dpdk.org; Wang, Ying A ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/2] net/ice: code clean >=20 >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wang Ying A > > Sent: Friday, April 12, 2019 9:52 PM > > To: Lu, Wenzhuo ; Yang, Qiming > > > > Cc: dev@dpdk.org; Wang, Ying A ; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH 1/2] net/ice: code clean >=20 > Better to change title to "fix wrong type", since it's actually a bug fix= . OK, will modify it. > > > > Variable "status" should be difined as "int" instead of "uint_16t". > > This patch fixes the issue. >=20 > Some typo >=20 OK, will modify it. > > > > Fixes: c945e4bf9063 ("net/ice: support promiscuous mode") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wang Ying A > > --- > > drivers/net/ice/ice_ethdev.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/net/ice/ice_ethdev.c > > b/drivers/net/ice/ice_ethdev.c index 9d01018..72831bb 100644 > > --- a/drivers/net/ice/ice_ethdev.c > > +++ b/drivers/net/ice/ice_ethdev.c > > @@ -2753,7 +2753,7 @@ static int ice_macaddr_set(struct rte_eth_dev *de= v, > > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > struct ice_vsi *vsi =3D pf->main_vsi; > > uint8_t pmask; > > - uint16_t status; > > + int status; >=20 > Can we use enum ice_status directly here? > Since I saw it will be compared with a enum value ICE_SUCCESS later. >=20 OK, will change to enum ice_status. > > > > pmask =3D ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX | > > ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; @@ - > 2769,7 > > +2769,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, > > struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > struct ice_vsi *vsi =3D pf->main_vsi; > > - uint16_t status; > > + int status; > > uint8_t pmask; > > > > pmask =3D ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX | @@ > > -2787,7 +2787,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev, > > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > struct ice_vsi *vsi =3D pf->main_vsi; > > uint8_t pmask; > > - uint16_t status; > > + int status; > > > > pmask =3D ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX; > > > > @@ -2802,7 +2802,7 @@ static int ice_macaddr_set(struct rte_eth_dev *de= v, > > struct ice_pf *pf =3D ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private); > > struct ice_hw *hw =3D ICE_DEV_PRIVATE_TO_HW(dev->data- > >dev_private); > > struct ice_vsi *vsi =3D pf->main_vsi; > > - uint16_t status; > > + int status; > > uint8_t pmask; > > > > if (dev->data->promiscuous =3D=3D 1) > > -- > > 1.8.3.1