DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Xueming Li <xuemingl@mellanox.com>
Cc: dev@dpdk.org, Asaf Penso <asafp@mellanox.com>, viacheslavo@mellanox.com
Subject: Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix completion queue initialization
Date: Tue, 28 Jul 2020 15:44:48 +0200
Message-ID: <44ba160c-0ce1-082f-3b83-bb2d5eb0e8de@redhat.com> (raw)
In-Reply-To: <1595860193-2771-1-git-send-email-xuemingl@mellanox.com>



On 7/27/20 4:29 PM, Xueming Li wrote:
> Vdpa device failed to initialize 2nd VQ during setup. From FW syndrome,
> unsupported CQE size was specified in CQ initialization attributes.
> 
> The unsupported CQE size comes from uninitialized stack struct data, and
> the struct has new fields defined recently which are not initialized in
> vdpa code.
> 
> This patch initializes cq creation attributes with zero to avoid such
> random data.
> 
> Fixes: 79a7e409a2f6 ("common/mlx5: prepare support of packet pacing")
> Cc: viacheslavo@mellanox.com
> 
> Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
>  drivers/vdpa/mlx5/mlx5_vdpa_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_event.c b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> index e14b380f19..13ad43611e 100644
> --- a/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> +++ b/drivers/vdpa/mlx5/mlx5_vdpa_event.c
> @@ -121,7 +121,7 @@ static int
>  mlx5_vdpa_cq_create(struct mlx5_vdpa_priv *priv, uint16_t log_desc_n,
>  		    int callfd, struct mlx5_vdpa_cq *cq)
>  {
> -	struct mlx5_devx_cq_attr attr;
> +	struct mlx5_devx_cq_attr attr = {0};
>  	size_t pgsize = sysconf(_SC_PAGESIZE);
>  	uint32_t umem_size;
>  	uint16_t event_nums[1] = {0};
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>


  reply	other threads:[~2020-07-28 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-27 14:29 Xueming Li
2020-07-28 13:44 ` Maxime Coquelin [this message]
2020-07-28 15:49 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44ba160c-0ce1-082f-3b83-bb2d5eb0e8de@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=asafp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=viacheslavo@mellanox.com \
    --cc=xuemingl@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git