From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84973A0521; Tue, 3 Nov 2020 12:41:59 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56587C95E; Tue, 3 Nov 2020 12:41:57 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 263E3C954 for ; Tue, 3 Nov 2020 12:41:54 +0100 (CET) IronPort-SDR: OALzEae4/95rIVw1fJgMmkRVdWvNXSYLCgib0UkqUpGbik4QdZVKh5FNzpqkyGpFwRv24qX5wC ZHso9s9zrd0A== X-IronPort-AV: E=McAfee;i="6000,8403,9793"; a="148319542" X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="148319542" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 03:41:53 -0800 IronPort-SDR: jc2INLH6uI4QoDve4c3khCak+LPDPs7DIg44PfYemYAjYkYGw4XTUx45ybFsm1e9hKBRFcmNbg WL1/evJNOoUA== X-IronPort-AV: E=Sophos;i="5.77,447,1596524400"; d="scan'208";a="538459260" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.218.178]) ([10.213.218.178]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Nov 2020 03:41:52 -0800 To: Lijun Ou Cc: dev@dpdk.org, linuxarm@huawei.com References: <1604327899-60126-1-git-send-email-oulijun@huawei.com> <1604327899-60126-8-git-send-email-oulijun@huawei.com> From: Ferruh Yigit Message-ID: <44cc36e0-c554-f717-953a-fe0d0ea259bc@intel.com> Date: Tue, 3 Nov 2020 11:41:48 +0000 MIME-Version: 1.0 In-Reply-To: <1604327899-60126-8-git-send-email-oulijun@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 7/8] net/hns3: fix some static check errors by coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2020 2:38 PM, Lijun Ou wrote: > From: Hongbo Zheng > > This patch fixes some warnings. > coverity:function format symbol does not match I think we are not getting these warnings in the public coverity, is there a specific configuration for it? > > coverity:not_unsigned: Violation: Operand > "hw->hw_tc_map & (1UL << i)", Right Expression: > "1UL << i" is not an unsigned type > Can you please split this patch into multiple patches, one for each type of issue? > Coverity issue: 91708127 > Coverity issue: 89776953 I assume these are internal coverity ids, it has not much value to record them in the commit log. We record the public coverity [1] ids with this tag. [1] https://scan.coverity.com/projects/dpdk-data-plane-development-kit?tab=overview > Fixes: 62e3ccc2b94c ("net/hns3: support flow control") > Fixes: 19a3ca4c99cf ("net/hns3: add start/stop and configure operations") > Fixes: a5475d61fa34 ("net/hns3: support VF") > Fixes: fb94f359481f ("net/hns3: fix adding multicast MAC address") > Fixes: fcba820d9b9e ("net/hns3: support flow director") > Fixes: a951c1ed3ab5 ("net/hns3: support different numbers of Rx and Tx queues") > Fixes: 2790c6464725 ("net/hns3: support device reset") > Fixes: 23d4b61fee5d ("net/hns3: support multiple process") > Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") > Fixes: e31f123db06b ("net/hns3: support NEON Tx") > Fixes: 8839c5e202f3 ("net/hns3: support device stats") > Cc: stable@dpdk.org > > Signed-off-by: Hongbo Zheng > Signed-off-by: Lijun Ou <...>