DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Wei Dai <wei.dai@intel.com>, thomas@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: add enum type for loop on Rx/Tx offloads
Date: Tue, 20 Mar 2018 11:59:51 +0000	[thread overview]
Message-ID: <44e0ca58-a0fe-50ae-3e2b-cef1510b251f@intel.com> (raw)
In-Reply-To: <1521518424-3603-1-git-send-email-wei.dai@intel.com>

On 3/20/2018 4:00 AM, Wei Dai wrote:
> This patch adds enum rte_eth_rx_offload_type and
> enum rte_eth_tx_offload_type. For a loop on all
> Rx offloads, it is convenient to begin with the
> first enum member ETH_RX_OFFLOAD_FIRST_FEATURE
> and to end at ETH_RX_OFFLOAD_TOTAL_NUM.
> A loop on all Tx offloads can begin with
> ETH_TX_OFFLOAD_FIRST_FEATURE and end at
> ETH_TX_OFFLOAD_TOTAL_NUM.

Hi Wei,

It may be confusing to have both
ETH_RX_OFFLOAD_VLAN_STRIP and DEV_RX_OFFLOAD_VLAN_STRIP.

Will it work only to have a definition of the OFFLOAD_TOTAL_NUM?

Can you please put some sample usage of the enums?

> 
> Signed-off-by: Wei Dai <wei.dai@intel.com>
> ---
>  lib/librte_ether/rte_ethdev.h | 44 +++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
> 
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 0361533..0089ea3 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -946,6 +946,27 @@ struct rte_eth_conf {
>  			     DEV_RX_OFFLOAD_VLAN_FILTER | \
>  			     DEV_RX_OFFLOAD_VLAN_EXTEND)
>  
> +enum rte_eth_rx_offload_type {
> +	ETH_RX_OFFLOAD_FIRST_FEATURE = 0,
> +	ETH_RX_OFFLOAD_VLAN_STRIP = ETH_RX_OFFLOAD_FIRST_FEATURE,
> +	ETH_RX_OFFLOAD_IPV4_CKSUM,
> +	ETH_RX_OFFLOAD_UDP_CKSUM,
> +	ETH_RX_OFFLOAD_TCP_CKSUM,
> +	ETH_RX_OFFLOAD_TCP_LRO,
> +	ETH_RX_OFFLOAD_QINQ_STRIP,
> +	ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM,
> +	ETH_RX_OFFLOAD_MACSEC_STRIP,
> +	ETH_RX_OFFLOAD_HEADER_SPLIT,
> +	ETH_RX_OFFLOAD_VLAN_FILTER,
> +	ETH_RX_OFFLOAD_VLAN_EXTEND,
> +	ETH_RX_OFFLOAD_JUMBO_FRAME,
> +	ETH_RX_OFFLOAD_CRC_STRIP,
> +	ETH_RX_OFFLOAD_SCATTER,
> +	ETH_RX_OFFLOAD_TIMESTAMP,
> +	ETH_RX_OFFLOAD_SECURITY,
> +	ETH_RX_OFFLOAD_TOTAL_NUM
> +};
> +
>  /*
>   * If new Rx offload capabilities are defined, they also must be
>   * mentioned in rte_rx_offload_names in rte_ethdev.c file.
> @@ -981,6 +1002,29 @@ struct rte_eth_conf {
>   */
>  #define DEV_TX_OFFLOAD_SECURITY         0x00020000
>  
> +enum rte_eth_tx_offload_type {
> +	ETH_TX_OFFLOAD_FIRST_FEATURE = 0,
> +	ETH_TX_OFFLOAD_VLAN_INSERT = ETH_TX_OFFLOAD_FIRST_FEATURE,
> +	ETH_TX_OFFLOAD_IPV4_CKSUM,
> +	ETH_TX_OFFLOAD_UDP_CKSUM,
> +	ETH_TX_OFFLOAD_TCP_CKSUM,
> +	ETH_TX_OFFLOAD_SCTP_CKSUM,
> +	ETH_TX_OFFLOAD_TCP_TSO,
> +	ETH_TX_OFFLOAD_UDP_TSO,
> +	ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM,
> +	ETH_TX_OFFLOAD_QINQ_INSERT,
> +	ETH_TX_OFFLOAD_VXLAN_TNL_TSO,
> +	ETH_TX_OFFLOAD_GRE_TNL_TSO,
> +	ETH_TX_OFFLOAD_IPIP_TNL_TSO,
> +	ETH_TX_OFFLOAD_GENEVE_TNL_TSO,
> +	ETH_TX_OFFLOAD_MACSEC_INSERT,
> +	ETH_TX_OFFLOAD_MT_LOCKFREE,
> +	ETH_TX_OFFLOAD_MULTI_SEGS,
> +	ETH_TX_OFFLOAD_MBUF_FAST_FREE,
> +	ETH_TX_OFFLOAD_SECURITY,
> +	ETH_TX_OFFLOAD_TOTAL_NUM
> +};
> +
>  /*
>   * If new Tx offload capabilities are defined, they also must be
>   * mentioned in rte_tx_offload_names in rte_ethdev.c file.
> 

  reply	other threads:[~2018-03-20 11:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20  4:00 Wei Dai
2018-03-20 11:59 ` Ferruh Yigit [this message]
2018-03-20 12:00 ` Ananyev, Konstantin
2018-03-21 14:08   ` Dai, Wei
2018-03-21 14:23     ` Zhang, Qi Z
2018-03-22  0:41       ` Dai, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44e0ca58-a0fe-50ae-3e2b-cef1510b251f@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=wei.dai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).