From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9569A054F; Mon, 15 Mar 2021 18:02:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6B6F5242752; Mon, 15 Mar 2021 18:02:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id A9BEA242741 for ; Mon, 15 Mar 2021 18:02:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615827769; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G8i9kobRBrvQ75YA1Yovu5JNAyMko8vplmDMRFlb9UA=; b=dHo2nTMrrO2jZFQgYkzGFLwUe29PPW8Voq56BSDhNHm54eX/PDJ2xidO4yWAlFnd9ElO8D 4TTeGkbgLRkshvLFxwveXkgVkeD4m2cspXZTM2M05efpJI10xNbjKw6LaupRSTgc+2iNnS 8tbK26DaScvlsdL1zwyChv17WOIZbIs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-vBAzZyuHPB2HeiwSupby3Q-1; Mon, 15 Mar 2021 13:02:41 -0400 X-MC-Unique: vBAzZyuHPB2HeiwSupby3Q-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 23247801817; Mon, 15 Mar 2021 17:02:40 +0000 (UTC) Received: from [10.36.110.10] (unknown [10.36.110.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 649A05D9C0; Mon, 15 Mar 2021 17:02:35 +0000 (UTC) To: David Marchand Cc: dev , "Xia, Chenbo" , Adrian Moreno Zapata , Olivier Matz , bnemeth@redhat.com References: <20210315164619.372575-1-maxime.coquelin@redhat.com> <20210315164619.372575-4-maxime.coquelin@redhat.com> From: Maxime Coquelin Message-ID: <44e52bf5-9e2e-7732-47dc-1d019cf64825@redhat.com> Date: Mon, 15 Mar 2021 18:02:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/virtio: allocate fake mbuf in Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/15/21 5:57 PM, David Marchand wrote: > On Mon, Mar 15, 2021 at 5:46 PM Maxime Coquelin > wrote: >> @@ -612,6 +622,8 @@ virtio_init_queue(struct rte_eth_dev *dev, uint16_t queue_idx) >> >> clean_vq: >> hw->cvq = NULL; >> + rte_free(fake_mbuf); >> +free_sw_ring: >> rte_free(sw_ring); >> free_hdr_mz: >> rte_memzone_free(hdr_mz); >> @@ -641,6 +653,7 @@ virtio_free_queues(struct virtio_hw *hw) >> >> queue_type = virtio_get_queue_type(hw, i); >> if (queue_type == VTNET_RQ) { >> + free(vq->rxq.fake_mbuf); Oups, will fix while applying. Thanks, Maxime > > rte_free() > >