DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Jingjing Wu <jingjing.wu@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] i40e: correct the private data size for i40e vf driver
Date: Tue, 28 Jul 2015 10:11:13 +0200	[thread overview]
Message-ID: <4517043.MQg1LVTXME@xps13> (raw)
In-Reply-To: <1438046019-30149-1-git-send-email-jingjing.wu@intel.com>

Hi Jingjing,

Few comments about the patch message.
The title must tell what issue is fixed, e.g. "fix crash when...".
the end "for i40e vf driver" is useless if it starts with "i40evf:".

2015-07-28 09:13, Jingjing Wu:
> The patch fixes the i40e VF crash issue. The issue's root cause is that
> the dev_private_size in i40e virtual function driver struct
> rte_i40evf_pmd was set incorrectly.

Please explain what are the conditions of the crash
and give a reference to the commit introducing the error with "Fixes: ...".

> Signed-off-by: jingjing.wu <jingjing.wu@intel.com>

Thanks

  parent reply	other threads:[~2015-07-28  8:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-28  1:13 Jingjing Wu
2015-07-28  1:27 ` Liu, Yong
2015-07-28  8:11 ` Thomas Monjalon [this message]
2015-07-28  9:01 ` [dpdk-dev] [PATCH V2] i40evf: fix crash when setup tx queues on vf port Jingjing Wu
2015-07-29  0:54   ` [dpdk-dev] [PATCH v3] " Jingjing Wu
2015-07-29 22:33     ` Thomas Monjalon
2015-07-30  0:41       ` Wu, Jingjing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4517043.MQg1LVTXME@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).