From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A5CFA0559; Mon, 16 Mar 2020 17:39:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 508911C0B8; Mon, 16 Mar 2020 17:39:54 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 200831C069 for ; Mon, 16 Mar 2020 17:39:51 +0100 (CET) IronPort-SDR: NIW1ZM53IMkU7Ws3lgrFhWLhVfPA6miMxeAOmbriT3FqM0IoUKMlAF84vP5xwgq6hrlqnUv7Me x+2vN4Lr8OJA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Mar 2020 09:39:51 -0700 IronPort-SDR: 1JmB21JKzCj5qvIY8WTG/hDMRtUOktHwCWMRBD5kWkaMI8YbXVcHyz7WBs7N0+Zn7hm3NZQEAl YlT9W8JhqidA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,561,1574150400"; d="scan'208";a="290750901" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.251.87.90]) ([10.251.87.90]) by FMSMGA003.fm.intel.com with ESMTP; 16 Mar 2020 09:39:49 -0700 To: Muhammad Ahmad , wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com Cc: Muhammad Ahmad , dev@dpdk.org References: <20200316100754.13447-1-muhammad.ahmad@emumba.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <4520447d-5ab0-c8fb-8251-7e86d86a6a44@intel.com> Date: Mon, 16 Mar 2020 16:39:48 +0000 MIME-Version: 1.0 In-Reply-To: <20200316100754.13447-1-muhammad.ahmad@emumba.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] testpmd: added rte_eth_dev_fw_version_get in testpmd rte_eth_dev_fw_version_get() was not called in test pmd. Added rte_eth_dev_fw_version_get() in testpmd under show port info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/16/2020 10:07 AM, Muhammad Ahmad wrote: > From: Muhammad Ahmad > Hi Muhammed, Can you please keep the patch title short, ~70 chars, and put the detail in the commit log? > Bugzilla ID: 225 > > Cc: dev@dpdk.org > Reported-by: Thomas Monjalon > Signed-off-by: Muhammad Ahmad > --- > app/test-pmd/config.c | 6 ++++++ > app/test-pmd/testpmd.h | 3 ++- > app/test-pmd/util.c | 14 ++++++++++++++ > 3 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 8cf84ccd3..0abec7d47 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -52,6 +52,8 @@ > > #include "testpmd.h" > > +#define ETHTOOL_FWVERS_LEN 32> + Why "ETHTOOL" ? > static char *flowtype_to_str(uint16_t flow_type); > > static const struct { > @@ -523,6 +525,7 @@ port_infos_display(portid_t port_id) > uint16_t mtu; > char name[RTE_ETH_NAME_MAX_LEN]; > int ret; > + char fw_version[ETHTOOL_FWVERS_LEN]; > > if (port_id_is_invalid(port_id, ENABLED_WARN)) { > print_valid_ports(); > @@ -544,6 +547,9 @@ port_infos_display(portid_t port_id) > rte_eth_dev_get_name_by_port(port_id, name); > printf("\nDevice name: %s", name); > printf("\nDriver name: %s", dev_info.driver_name); > + if (eth_dev_fw_version_get_err(port_id, fw_version, > + ETHTOOL_FWVERS_LEN) == 0) > + printf("\nfirmware-version: %s", fw_version); What do you think starting with uppercase, like "Firmware-version: ...", to be consistent. > if (dev_info.device->devargs && dev_info.device->devargs->args) > printf("\nDevargs: %s", dev_info.device->devargs->args); > printf("\nConnect to socket: %u", port->socket_id); > diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h > index 7a7c73f79..6b7842d3d 100644 > --- a/app/test-pmd/testpmd.h > +++ b/app/test-pmd/testpmd.h > @@ -850,7 +850,8 @@ void eth_set_allmulticast_mode(uint16_t port, int enable); > int eth_link_get_nowait_print_err(uint16_t port_id, struct rte_eth_link *link); > int eth_macaddr_get_print_err(uint16_t port_id, > struct rte_ether_addr *mac_addr); > - > +int eth_dev_fw_version_get_err(uint16_t port_id, > + char *fw_version, size_t fw_size); > /* Functions to display the set of MAC addresses added to a port*/ > void show_macs(portid_t port_id); > void show_mcast_macs(portid_t port_id); > diff --git a/app/test-pmd/util.c b/app/test-pmd/util.c > index 8488fa1a8..2ac76f18e 100644 > --- a/app/test-pmd/util.c > +++ b/app/test-pmd/util.c > @@ -375,3 +375,17 @@ eth_macaddr_get_print_err(uint16_t port_id, struct rte_ether_addr *mac_addr) > > return ret; > } > + > +int > +eth_dev_fw_version_get_err(uint16_t port_id, char *fw_version, size_t fw_size) > +{ > + int ret; > + > + ret = rte_eth_dev_fw_version_get(port_id, fw_version, fw_size); > + if (ret < 0) > + printf("firmware version get error: (%s)\n", strerror(-ret)); For the drivers doesn't support getting FW version, these errors are printed in the middle of the port info, so instead of this helper function, what do you think calling `rte_eth_dev_fw_version_get()` directly from `port_infos_display()`? > + else if (ret > 0) > + printf("Insufficient fw version buffer size, " > + "the minimum size should be %d\n", ret); > + return ret; > +} >