From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 945D2A00C3; Tue, 1 Feb 2022 13:19:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20E1C40698; Tue, 1 Feb 2022 13:19:46 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 0232640691 for ; Tue, 1 Feb 2022 13:19:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643717984; x=1675253984; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=olP+CkYL+tmC1NhZSW982khri50CD7O9P+SvTD2nSPI=; b=GDeFj/H6n+i/ALxUFXvLHs330ftKzAI3mRFIjFKIWsGsz53wuxaXmovT vMFyfhdzVDD9BREl0G4vU/Z0U8JSc1urIUbLSnM/9ScpvbARcXrl8F7v1 oJ+JkOUCMqkqYFkD7FkXeBDnGjMzqH1TCkcSLQu0mR4ODpKnpAJhQFNfv y4IhA2vTKvpuOWbhHvSmXQRHA6rAx6GhTIL8p2DsXJ/hTmYWNHyn7vpJ7 2YaE6Vts3hjGbURSotQzK/+07spwSlsqLW5PXQhD6bdM2+xPMRaxZUSzs TQUWmW/2K8biXxpnK3GJIw0fAo9r1F7KgL8cb4zZIpXUkEZBVIjXBtSTY Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10244"; a="228337869" X-IronPort-AV: E=Sophos;i="5.88,333,1635231600"; d="scan'208";a="228337869" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2022 04:19:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,333,1635231600"; d="scan'208";a="626716232" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 01 Feb 2022 04:19:42 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 04:19:42 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 1 Feb 2022 04:19:42 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Feb 2022 04:19:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cDRO+4tDnUd00nNGMq1Uoy3v0OUIMgcvg2vJu/B6wQtp4zslpchiIVXIcafhxXJB0d2FaK9d2VkkPFm310kzJ6gjAdB1aM1saYQZs1F7VP9TUjFJkbCAHnn0+BDMy7l+qjC3A0UVppNHVaAYDSKDl3rH1tq06GCtoHWoe+KDRA8nn/REgc26NrY8Sz4tXfHvItQ9kM7/1eR5Hp5cRRpNXrc7Io4A8D3zaWy4bho9HaPf/7lH6AbYD3I5yOyQ2uOrhSe2f1zLNBbFe7IyQHvr1PiF97mrIdO0MFWcBhZB8CzIYVxAT/19YbVwZrnwPoeXPnX3YKQcW7ay6YQrQrEhZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AKS+a77VepoPdkp1Qb8QXliJLpHYJQX2IFaBPYYclG8=; b=TGu/A1oX2RNLs9/L4Ix2ruAOo9w0aDDOstjoC81vw5f3ZlKJS2RUml7MhdqcBIC6DFFN/kBHrUHWUg6NI/kYxNbWvEwCBV7DyhhkO1xHya8ER1JI9rFRMhQhqyBIq8MYsXfZulnoXqATuR4yYXb7fW9JwKNEctbyVvOs25DnaJILwmWSDtKT6RfQSZALk0h36mbKJEFZ1iUSerXTcy5j8cOn1vX/mItgnulYvW23XAFq5k4EhQyAoMyErdR4a0BpP3kcGA4hvdIO+ll2QJzheKnGok8NhbT+MJKD8lo0mShfgnfjq3oiDqV+DL0CJGLUO27X6TB89C+tNOOMyubdUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BY5PR11MB4119.namprd11.prod.outlook.com (2603:10b6:a03:190::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Tue, 1 Feb 2022 12:19:39 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022 12:19:39 +0000 Message-ID: <452340e8-ecf8-c759-9667-5cce98c2d0d8@intel.com> Date: Tue, 1 Feb 2022 12:19:33 +0000 Content-Language: en-US To: <20220126063016.2384393-1-jie1x.wang@intel.com>, CC: , , , , , , , , , Jie Wang References: <20220129062434.2455711-1-jie1x.wang@intel.com> <20220129062434.2455711-2-jie1x.wang@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v3 1/6] ethdev: add L2TPv2 RSS offload type X-User: ferruhy In-Reply-To: <20220129062434.2455711-2-jie1x.wang@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0045.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ac::21) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a624667b-8e60-439d-56a6-08d9e57d1dbd X-MS-TrafficTypeDiagnostic: BY5PR11MB4119:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3631; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ccvGrQrmFFTQXz7/3NEYwfMfjuWN34M1VOii2e2Qap7T1REh6NCQDnKJiA4WYphZONDmI3Z/m2WMUAEmWKXB06yD0j0h9q41Vb39JB9jda5oqxOGM3c6ERPUVojEjeDf9WWwGBBj/MftG1ksp8/0aLhzvnu8c6CFmXlNv01XpJGqaxwX5dKKj3XH7vBEsfOTTkHBoV/2dLXpMFV84I17duoSDp0/KcPR7EF453ZXvuiFYm29PuEVBddbhn+rRs+v/cFaRYsHXgxTNbpasEeNZGhW4CO/xkGKwp8tYHwPJsMrgBYIg6+3/cCpYR08TN0R/ZS6vkLDvC7aIFsOVlUWbAk96FtF3lC6PkKSWFJpYIkJ6V4utOYtwH0wmhYW9lWtvFLow0tu5OIfjsBvTzgPpUHsYXJdN6addyluagXAtHdyNhaSlBGLWqQy2Y0GOzNqaXaDnfSOdl8xnfDfH6H/8BC0AkfxaZj3F8Uq9HJcfvV+6zpTZrosuadmnpI5zahzT+4oRw2XyT/RZPDaCFaAaWPT714AgMiReoVG263lbo5NFezyApofXDCTb/Y8a4UubSCG36FX+++upUYQG1a5i7OOaqdkc1D+r0+MbXAxP7i87blARLyQfyPIl/RQ9Rlw53SXXO4mtFsoMV0tjGoJvPrtYK8dsD5tsJRJmGcNz6BV3HWtwc+v2SVPx2Fom9EvpcsuT0xzX0XvkYFhE4K7VA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8676002)(8936002)(66556008)(4326008)(2906002)(86362001)(107886003)(31696002)(66946007)(82960400001)(38100700002)(66476007)(6512007)(6506007)(44832011)(31686004)(6666004)(53546011)(4744005)(26005)(55236004)(6486002)(36756003)(5660300002)(508600001)(316002)(186003)(2616005)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWNxWHQyVFpaWFhYRVh5TUNheFJCMEJJWS93ZnVsWkFkMXNSWjNkSDRkNG1U?= =?utf-8?B?TFBpU2ZjZXExS0FJdHVSS2FOc0xNR1dCWHFYQ3hNUmtQVUI2VWQwdFJOWnVM?= =?utf-8?B?czk3Rm1VeHJvQmVRWG5UYnRmaXlSYlFSVnJ4QnZPUFNtM2dybmlzc1VJTmpF?= =?utf-8?B?WmRjZTBrNCtZbjFCY3B4bkh1Ylp0RXdOY25nYXBVSGNLZ05IcDNhVmkxQWxz?= =?utf-8?B?V242aS9pWFlzT2UxbjNWRWQ1VDJiSnBxVzlGc3J4TGFLbzBEK0NEOXlpUzlj?= =?utf-8?B?Y2lrNW1kSFBBdlJ1eTRuK1hLcHBVT1RIcTRYNitKdEIxQWo2blloSVNqMHpK?= =?utf-8?B?aXc1M05SQkFNS1BkQU9mUFh4ci9RUFlPSVdBV3RmSU9DZmlxeEZ0REJUQXY4?= =?utf-8?B?SlV1ZHJNK1ZGcHZzUlNIQmtMV0xwRnJOS1hRTk5naG9nWCtnbU1qd0xvdUQ1?= =?utf-8?B?a3FVQTQ1MjVhTlAxdXVBVHcxVm9kRytCQmtqV2FPOGxoQ1hNL2x2V3RyK3Fi?= =?utf-8?B?TXk4aWRPTzdXdGJHNHd0bnplVnE5c1lrTVJZaElMNDUzaHJJN1BEOHZOZXNR?= =?utf-8?B?MDRrOUw5YitCU3A5VFY3eDRja2NnYlU5VWYrWmFmYU5CalZIRVZWa0oxQkgr?= =?utf-8?B?ZzcyeC9NRkJsdithdDl2T1hQL3hidlN4QUFaVlNKb0NPeUw4Q0VPWTJ4S1Ew?= =?utf-8?B?QlNzbUM3SGc4QW55LzFjSk10bHRxbTQrWkpKdHBReVZxVGhIb0VKYXljQ2lU?= =?utf-8?B?ZVM3SDBrd0s1L0k0dUIxUVAwYitpMmpFMEJ6blZ5d01TUU1kU3AwaXpnSnJP?= =?utf-8?B?MnFwYjkwUllRcEUra2tRZ3IrMUZmeTRjQTBMU0s0L1FiZG5MVmphZ2R1R2RD?= =?utf-8?B?TWFKY0ZRNmVsNEZwU1dBODRuUm1jcVRyeTlCZ0s1UCtldWllNHZTSlV6aXFp?= =?utf-8?B?cGdKcWVQYUpGKzdFVzNkRklDajVGV0J0ZEdoY0tIU0RncVhOaFh3R1JxY1hq?= =?utf-8?B?OWR5Zkw1aWtVbE16cWNzbkhrQjJXQlFWeXdnMmJuMnl2WkJ3NDZhNVlxQ1ly?= =?utf-8?B?RXJHcVc4OFhVVEZKQklCVWJYNlYwMGVCWkhKb2dVQ2x1bW5HWmdpS0RTdlVL?= =?utf-8?B?R2M0c3dPZmc0bU9lK1RadXN3cElKUmVKSEhsdHlRajBuMFR5dGlrTG5FL3FW?= =?utf-8?B?WXZJKzJiaXhYQUx0K0lRc0dBWGczeCtENktGRTd6RVZuUmdsSFRNU3dNaG4x?= =?utf-8?B?UGQwUDhIckl6V090S1FvRXZqdFJRZjZlVkJrcUR0WTlXMXNJSFdqVkplcU9r?= =?utf-8?B?QTAwbTNSTWxGdzJZd1JsSFpxQ3oyS2NKOGo2T0VMQkE2dzJzOE1tbGN5NGVo?= =?utf-8?B?T3A0QkhHWW91MkxLVFJOWFh0RGRIRnBwS1dYbGhRZ0ZVVVdJazh5V3BHMVlm?= =?utf-8?B?bkM1T0E4LzFwUU1jdFQvcmIwTm1pdE0rcXcwQi91WFRjR2hDalp0cTBCWXR1?= =?utf-8?B?ZEJkTTFhZXFRVS82K3RtWDZYTDZxd3NoTnc4Q2o2MjR0SHdzVUlCS2ZGaU1q?= =?utf-8?B?MldKZ251eSs3TWJyamp6RnFSU3pGWnFVNkFoV0c3cU44YzRBKzRNc1dPNE9W?= =?utf-8?B?WVp1elk1MDM5VndIRXM4bnMvMFdkQVBXRXZSL1BMQnVzRVJEVlI0QmNYSUFQ?= =?utf-8?B?K045bnhrc3dQK2tYZmd1ZHhOQ25CTkZ1OE5PeU1HNHhPNGFVci9aUlJnR3Fx?= =?utf-8?B?eURpL2RZNmRUK1F2TmtEOGxkV0Rkbnc4S3N4dC9TS2d2VUVjYmpCODRGNVN5?= =?utf-8?B?V2pTTlBTdHpWeHJ2bVFWdk9nRWcrZHlqdElhdmZNNFJKVEpUVjVxeUM4b3Fl?= =?utf-8?B?SWs0b2htSjYwemc0RE1OR01aTzJ0Y1pONGdvVVBneUlVekhSeFFYQUFkclkx?= =?utf-8?B?dEVDdEtITFhoN0xCWXlWdll3YUlSNXNDcnd0M1EyNHVIWExGNDVQd2JVblpE?= =?utf-8?B?dGpFSzdURnNucmFkR2tCaExBdlh6N01HOHdoeFNVNFJKSktGTHdzRWZQMWhC?= =?utf-8?B?ZlhrWFBqRzZTVEQvc2d0VVd4akVlVXJaUllET05tWjgzQ3ZLQVBqTE42TGgy?= =?utf-8?B?REp3NzRSQXNkQ2RGend3alZsOTVwaGI2a2FqTXdhaTEySHQ2cnovYVhjOW5C?= =?utf-8?Q?qdijeNwtrw5pyj9/0gBe8K0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a624667b-8e60-439d-56a6-08d9e57d1dbd X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 12:19:38.5056 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oy8SXhS+g/c/hBiuZBjO/ZOM3SSAq9e/HBeAYCJB1z4T1n4SssamHMDpXuxx5lPhuxc59N+ewu/jdtRJfj9kjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4119 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/29/2022 6:24 AM, Jie Wang wrote: > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 147cc1ced3..29e6091bc8 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -651,6 +651,13 @@ struct rte_eth_rss_conf { > #define RTE_ETH_RSS_L4_CHKSUM RTE_BIT64(35) > #define ETH_RSS_L4_CHKSUM RTE_DEPRECATED(ETH_RSS_L4_CHKSUM) RTE_ETH_RSS_L4_CHKSUM > > +/* > + * Below macro is defined for RSS offload type, it can be used to > + * fill rte_eth_rss_conf.rss_hf or rte_flow_action_rss.types. > + */ > +#define RTE_ETH_RSS_L2TPV2 RTE_BIT64(36) > +#define ETH_RSS_L2TPV2 RTE_ETH_RSS_L2TPV2 Perhaps I wasn't clear, don't have 'ETH_RSS_L2TPV2' at all. Old macros were missing 'RTE_' prefix, so new ones added with prefix, and old ones marked as deprecated. When you are adding a new macro that already starts with 'RTE_' prefix no need to add old/deprecated style of macro. Please keep existing acks in next version of the patch.