From: Thomas Monjalon <thomas@monjalon.net>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Bing Zhao <bingz@nvidia.com>,
dev@dpdk.org, Ori Kam <orika@nvidia.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Matan Azrad <matan@nvidia.com>,
Slava Ovsiienko <viacheslavo@nvidia.com>, dpdk-dev <dev@dpdk.org>,
Gregory Etelson <getelson@nvidia.com>,
Andrey Vesnovaty <andreyv@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH v3 1/1] ethdev: introduce indirect action APIs
Date: Fri, 16 Apr 2021 09:03:19 +0200 [thread overview]
Message-ID: <4523824.l8Hmzzfj0I@thomas> (raw)
In-Reply-To: <CACZ4nhsy_bMkjGUvULvWqhHbnqZ55KvKqJoJzmiN-kcA-W5e6A@mail.gmail.com>
15/04/2021 19:59, Ajit Khaparde:
> On Thu, Apr 15, 2021 at 8:52 AM Bing Zhao <bingz@nvidia.com> wrote:
> > There are two types of flow actions:
> > 1. the direct (normal) actions that could be created and stored
> > within a flow rule. Such action is tied to its flow rule and
> > cannot be reused.
> > 2. the indirect action, in the past, named shared_action. It is
> > created from a direct actioni, like count or rss, and then used
> > in the flow rules with an object handle. The PMD will take care
> > of the retrieve from indirect action to the direct action
> > when it is referenced.
[...]
> > The RTE_FLOW_ACTION_TYPE_SHARED is kept for now in order not to
> > break the ABI. All the implementations are changed by using
> > RTE_FLOW_ACTION_TYPE_INDIRECT.
>
> When I read this somehow indirect did not feel right.
> But I don't have a strong suggestion either.
> Since it is a context of action or actions maybe we use action_context?
This is an action which is not directly described in the flow rule,
but in another object referenced by its handle.
It creates a level of indirection in the rule description.
I think the word "indirect" is accurate.
next prev parent reply other threads:[~2021-04-16 7:03 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1615967952-228321-1-git-send-email-bingz@nvidia.com>
2021-03-17 8:28 ` [dpdk-dev] [RFC] ethdev: introduce action context APIs Thomas Monjalon
2021-03-17 16:10 ` Bing Zhao
2021-03-22 14:59 ` Andrew Rybchenko
2021-04-06 9:05 ` Bing Zhao
2021-03-22 14:54 ` Andrew Rybchenko
2021-04-06 9:07 ` Bing Zhao
2021-04-06 9:48 ` Thomas Monjalon
2021-04-06 11:02 ` Bing Zhao
2021-04-06 12:18 ` Thomas Monjalon
2021-04-07 3:16 ` Ajit Khaparde
2021-04-07 6:11 ` Bing Zhao
2021-04-08 14:46 ` [dpdk-dev] [RFC PATCH v2] ethdev: introduce indirect action APIs Bing Zhao
2021-04-09 3:54 ` [dpdk-dev] [PATCH] " Bing Zhao
2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API Bing Zhao
2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 1/4] ethdev: introduce indirect action APIs Bing Zhao
2021-04-12 19:42 ` Ferruh Yigit
2021-04-13 1:26 ` Bing Zhao
2021-04-13 14:00 ` Ori Kam
2021-04-13 12:36 ` Andrey Vesnovaty
2021-04-15 13:55 ` Andrew Rybchenko
2021-04-15 14:10 ` Thomas Monjalon
2021-04-15 16:02 ` Andrew Rybchenko
2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 2/4] app/test-pmd: change to indirect action command Bing Zhao
2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 3/4] doc: update user guide for indirect action Bing Zhao
2021-04-10 14:03 ` [dpdk-dev] [PATCH v2 4/4] net/mlx5: adaption to indirect action API Bing Zhao
2021-04-12 19:40 ` [dpdk-dev] [PATCH v2 0/4] Change shared action API to action handle API Ferruh Yigit
2021-04-13 1:22 ` Bing Zhao
2021-04-13 7:23 ` Thomas Monjalon
2021-04-13 7:24 ` Bing Zhao
2021-04-15 15:51 ` [dpdk-dev] [PATCH v3 0/1] " Bing Zhao
2021-04-15 15:51 ` [dpdk-dev] [PATCH v3 1/1] ethdev: introduce indirect action APIs Bing Zhao
2021-04-15 15:56 ` Ori Kam
2021-04-15 17:59 ` Ajit Khaparde
2021-04-16 6:58 ` Bing Zhao
2021-04-16 7:03 ` Thomas Monjalon [this message]
2021-04-16 15:00 ` Ajit Khaparde
2021-04-16 17:33 ` [dpdk-dev] [PATCH v4 0/1] Change shared action API to action handle API Bing Zhao
2021-04-16 17:33 ` [dpdk-dev] [PATCH v4 1/1] ethdev: introduce indirect action APIs Bing Zhao
2021-04-19 12:26 ` Thomas Monjalon
2021-04-19 15:05 ` Bing Zhao
2021-04-19 14:28 ` [dpdk-dev] [PATCH v5] Change shared action API to action handle API Bing Zhao
2021-04-19 14:28 ` [dpdk-dev] [PATCH v5] ethdev: introduce indirect action APIs Bing Zhao
2021-04-19 14:38 ` [dpdk-dev] [PATCH v5 0/1] Change shared action API to action handle API Bing Zhao
2021-04-19 14:38 ` [dpdk-dev] [PATCH v5 1/1] ethdev: introduce indirect action APIs Bing Zhao
2021-04-19 14:50 ` Thomas Monjalon
2021-04-19 15:09 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4523824.l8Hmzzfj0I@thomas \
--to=thomas@monjalon.net \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=andreyv@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).