From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B325FA0C41; Fri, 16 Apr 2021 09:03:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9AA2B141B36; Fri, 16 Apr 2021 09:03:25 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id 2CA1F40140 for ; Fri, 16 Apr 2021 09:03:24 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 632C75C00B1; Fri, 16 Apr 2021 03:03:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 16 Apr 2021 03:03:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= JA+PawIrvgfO53dRQBIM1QmdcBvRVpvQ8Z91noEHqGg=; b=QAZEAMGMkx+ELP5L TMQElDWSCh8lq/lbKE4I1uVKLNNOnatwmBQ13SKr0+E4YaUYS+5Ris6fXm7X/Wu1 zliNhFqTQ+jjftxCkrX5bIOel6GC9xrjKwEX5++rHWdGJrsV3Mse4w5cSTypJEhr G/nTeVN7GAuV/Rb5qkMmiEmTAWM6RjgbgIiMM8MMhA31tM/3WZASAxwPYQVkKa6V V8nOuSOFGVVjCfv4mk726KxnV9e9xlnZCbJLGCDZzhOczP8tMjji1kDwV2sIxpFr fjkz3HHJkL6OR/xItmqdUjJYsnlS2M4gvKCQ4nubGV2n9heMRHOefZfypk5LZdrL cyDGhA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=JA+PawIrvgfO53dRQBIM1QmdcBvRVpvQ8Z91noEHq Gg=; b=VqNDLTRwdDZWBgDN4TO/+6Tzsi59xJrWw4VSQElrJaaJSvAZuQXswohdn 5Sofw93aV3lNWDB4kaLexg1rZgqhBKrWmMqmrfDeNesrKCevQzelgRj6eSN76v0H QHT42lkVG6aEilwSjx0oD8bjB8WH+o+SQtqjPXevcWq/kBovepc4xkW2n0lYue2Q Rhq5oldwVj0aKAf7wnmaa/9TC/nkVwwcVDgvBgLmP12fxT3onCsBH6d4D5Hy8huD 9uYWz4dx2QbVeXk931WLrZRkRptrZQLxnipDOXuEkCmUql3MYqxhOxarhoghANxp MQ0edQDTYR4zVrtx5vAJ6q37mtanw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudelgedguddujecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4F6E4240065; Fri, 16 Apr 2021 03:03:21 -0400 (EDT) From: Thomas Monjalon To: Ajit Khaparde Cc: Bing Zhao , dev@dpdk.org, Ori Kam , Ferruh Yigit , Andrew Rybchenko , Matan Azrad , Slava Ovsiienko , dpdk-dev , Gregory Etelson , Andrey Vesnovaty Date: Fri, 16 Apr 2021 09:03:19 +0200 Message-ID: <4523824.l8Hmzzfj0I@thomas> In-Reply-To: References: <1617940481-125528-1-git-send-email-bingz@nvidia.com> <1618501912-92525-2-git-send-email-bingz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/1] ethdev: introduce indirect action APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 15/04/2021 19:59, Ajit Khaparde: > On Thu, Apr 15, 2021 at 8:52 AM Bing Zhao wrote: > > There are two types of flow actions: > > 1. the direct (normal) actions that could be created and stored > > within a flow rule. Such action is tied to its flow rule and > > cannot be reused. > > 2. the indirect action, in the past, named shared_action. It is > > created from a direct actioni, like count or rss, and then used > > in the flow rules with an object handle. The PMD will take care > > of the retrieve from indirect action to the direct action > > when it is referenced. [...] > > The RTE_FLOW_ACTION_TYPE_SHARED is kept for now in order not to > > break the ABI. All the implementations are changed by using > > RTE_FLOW_ACTION_TYPE_INDIRECT. > > When I read this somehow indirect did not feel right. > But I don't have a strong suggestion either. > Since it is a context of action or actions maybe we use action_context? This is an action which is not directly described in the flow rule, but in another object referenced by its handle. It creates a level of indirection in the rule description. I think the word "indirect" is accurate.