From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f50.google.com (mail-lf0-f50.google.com [209.85.215.50]) by dpdk.org (Postfix) with ESMTP id BA5465398 for ; Sun, 9 Oct 2016 21:50:58 +0200 (CEST) Received: by mail-lf0-f50.google.com with SMTP id b81so88878917lfe.1 for ; Sun, 09 Oct 2016 12:50:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=wxoYNEqi1AtrKNyfxc/gpSS0seUurL6cZCSV5P8odJk=; b=T8xFBDKtpnqpCDQHbQx2ThKFwDh4Z3yto9L/Q8YhyEWQcsroJhoDrl1uea7gvWymAs uauNysyCW6xcnoRuP+oK1/k5Sx4EbuMQQGqMH9y/PjCXyFBVMcsEinoh4jqFYrEz9Rbz bq1m2/FxcHoEdiW0I84JSVNXFlfQeMinYlFHYEbLXGtSGlQ+qsfO26S2cg86L0aiNreP mNQ5fKYzgoU0Q/RsXa+L+eAL5/AGhUPIk15RNO6cPE+jzx4N1QIbftYJPVfqT07fPkLh EoJG8ttwnAVUFnHX63qd6oJXup8Lag38VEcJhkL+GGr4cVXCAKu39f3sfof/KKLTcwGI gTBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=wxoYNEqi1AtrKNyfxc/gpSS0seUurL6cZCSV5P8odJk=; b=JAMSJ91R1eF0sMJPmdH81sKci9T+xoi6WY7F6Yd4xNKEIkji6YS1fyYusOtksFko94 ahbzpBShuBRnMSwErzHb6d3gA1JZtueGpx8iqYmFNGGUCYkeHpNikkIqUBOgM1+5y/2v IQTyUjF3/PiAt+iFAsL6WQZznTHy/Qm9zWaAU+3R5YyWrTFOF8sIfIop3REAh1U8HqLx QF+hYIpd/FzzLa3DgMoIiV4+ElTmf9am1Pg8InTedKvSQxCWnDz8mRNh/5JO8zXdGDBu iW9+L+iacDvup0LmNz45wAYTYIF/aTA2v0l2gGsA5Dt8oO7JsuMy/y8+4QusRZyRG0Rh jnfg== X-Gm-Message-State: AA6/9RlZWmxUQqOsvyU/FXkXKM2J97ut6zG+hccCWIxfPu+E4GdQcsoWi1zbM1VUWD9Z8/gJ X-Received: by 10.194.142.116 with SMTP id rv20mr26021726wjb.184.1476042658066; Sun, 09 Oct 2016 12:50:58 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id p3sm33148514wjr.31.2016.10.09.12.50.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Oct 2016 12:50:57 -0700 (PDT) From: Thomas Monjalon To: Shreyansh Jain Cc: "david.marchand@6wind.com" , dev@dpdk.org, "nhorman@tuxdriver.com" Date: Sun, 09 Oct 2016 21:50:56 +0200 Message-ID: <4525292.xovB97rfbE@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1475949668-26829-1-git-send-email-shreyansh.jain@nxp.com> <184506162.Hjg7Xy8FWv@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] drivers: prefix driver REGISTER macro with RTE PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Oct 2016 19:50:59 -0000 2016-10-09 15:12, Shreyansh Jain: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2016-10-08 23:35, Shreyansh Jain: > > > +PMDINFO_TO_O = if grep -E 'RTE_PMD_REGISTER_PCI\([0-9a-zA-Z,_\. > > ]+\)|RTE_PMD_REGISTER_VDEV\([0-9a-zA-Z,_\. ]+\)' $<;\ > > > + then \ > > > > I don't understand why you don't simply grep 'RTE_PMD_REGISTER_.*(' ? > > Because I want to make sure that the grep matches only the DRIVER registration functions. > In case a new macro (or driver type) is added in future, this macro can be updated. This way we can reduce the probability of a faulty match. > > Is there a problem with closest possible match? It is just long and useless. A macro starting with RTE_PMD_REGISTER_ must be called from a PMD. What else?