From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38FC9A04B4; Tue, 25 Aug 2020 09:44:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1ADFAE07; Tue, 25 Aug 2020 09:44:39 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id D039F14581 for ; Tue, 25 Aug 2020 09:44:36 +0200 (CEST) IronPort-SDR: YIX8KTpj9qS6gK2IWx9lO25a8JHeYyty4SZijch1aQbrwT+ldbmUioeJQ9J3KbsoZg+O4PyBQv utKJhqL2db8Q== X-IronPort-AV: E=McAfee;i="6000,8403,9723"; a="143725320" X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="143725320" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 00:44:35 -0700 IronPort-SDR: neyB/c3ss/ZtiDoM+Z37BgpkooGPDCTlIjNN19YV9XGfugpJlNoOz8R4lLb/rKQ5JoNXMdmL2c GoHI60x+1ucA== X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="474242342" Received: from gtohallo-mobl.ger.corp.intel.com (HELO [10.252.20.100]) ([10.252.20.100]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2020 00:44:34 -0700 To: Ed Czeck Cc: Bruce Richardson , dev@dpdk.org, Shepard Siegel , John Miller References: <20200819153539.32698-1-ed.czeck@atomicrules.com> <20200824133641.19450-1-ed.czeck@atomicrules.com> <20200824144045.GA547@bricha3-MOBL.ger.corp.intel.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: <452567d5-c7df-057f-29d8-190b30ecb532@intel.com> Date: Tue, 25 Aug 2020 08:44:33 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/2] net/ark: remove compile time log macros in favor of run time log control X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/24/2020 10:40 PM, Ed Czeck wrote: > On Mon, Aug 24, 2020 at 11:09 AM Ferruh Yigit wrote: >> >> On 8/24/2020 3:40 PM, Bruce Richardson wrote: >>> On Mon, Aug 24, 2020 at 03:37:53PM +0100, Ferruh Yigit wrote: >>>> On 8/24/2020 2:36 PM, Ed Czeck wrote: >>>>> Use ARK_PMD_LOG in place of PMD_DRV_LOG, PMD_DEBUG_LOG, PMD_FUNC_LOG, >>>>> PMD_STATS_LOG, PMD_RX_LOG, and PMD_TX_LOG. >>>>> Review and adjust log levels and messages as needed. >>>>> >>>>> Signed-off-by: Ed Czeck >>>>> --- >>>>> doc/guides/nics/ark.rst | 13 ------ >>>>> drivers/net/ark/ark_ddm.c | 12 ++--- >>>>> drivers/net/ark/ark_ethdev.c | 77 +++++++++++++++------------------ >>>>> drivers/net/ark/ark_ethdev_rx.c | 46 ++++++++++---------- >>>>> drivers/net/ark/ark_ethdev_tx.c | 10 ++--- >>>>> drivers/net/ark/ark_logs.h | 63 +++------------------------ >>>>> drivers/net/ark/ark_mpu.c | 32 ++++---------- >>>>> drivers/net/ark/ark_pktchkr.c | 36 +++++++-------- >>>>> drivers/net/ark/ark_pktdir.c | 2 +- >>>>> drivers/net/ark/ark_pktgen.c | 22 +++++----- >>>>> drivers/net/ark/ark_rqp.c | 4 +- >>>>> drivers/net/ark/ark_udm.c | 18 ++++---- >>>>> 12 files changed, 125 insertions(+), 210 deletions(-) >>>>> >>>>> diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst >>>>> index 06e8c3374..c3ffcbbc2 100644 >>>>> --- a/doc/guides/nics/ark.rst >>>>> +++ b/doc/guides/nics/ark.rst >>>>> @@ -132,19 +132,6 @@ Configuration Information >>>>> * **CONFIG_RTE_LIBRTE_ARK_PAD_TX** (default y): When enabled TX >>>>> packets are padded to 60 bytes to support downstream MACS. >>>>> >>>>> - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_RX** (default n): Enables or disables debug >>>>> - logging and internal checking of RX ingress logic within the ARK PMD driver. >>>>> - >>>>> - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TX** (default n): Enables or disables debug >>>>> - logging and internal checking of TX egress logic within the ARK PMD driver. >>>>> - >>>>> - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_STATS** (default n): Enables or disables debug >>>>> - logging of detailed packet and performance statistics gathered in >>>>> - the PMD and FPGA. >>>>> - >>>>> - * **CONFIG_RTE_LIBRTE_ARK_DEBUG_TRACE** (default n): Enables or disables debug >>>>> - logging of detailed PMD events and status. >>>>> - >>>> >>>> Can you please remove these config option from 'config/common_base'? >>>> >>> Given that the file is scheduled for deletion fairly soon, not sure if that >>> is worthwhile doing. >>> >> >> Since there is possible new version already because of comment in 2/2, I think >> better to update 'config/common_base' for the sake of completeness. >> >> But if there won't be a new version, this can be skipped pragmatically. > > I will avoid the update of config/common_base as changes there will > cause merge conflict. > OK