From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Matthew Hall <mhall@mhcomputing.net>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/6] librte_log: add function to retrieve log_level
Date: Fri, 13 Nov 2015 12:49:36 +0100 [thread overview]
Message-ID: <4536748.1MnZAysZE1@xps13> (raw)
In-Reply-To: <20151113114008.GA15612@bricha3-MOBL3>
2015-11-13 11:40, Bruce Richardson:
> On Fri, Nov 13, 2015 at 06:47:33AM +0000, Matthew Hall wrote:
> > --- a/lib/librte_eal/common/include/rte_log.h
> > +++ b/lib/librte_eal/common/include/rte_log.h
> > @@ -131,6 +131,7 @@ void rte_set_log_level(uint32_t level);
> >
> > /**
> > * Get the global log level.
> > + *
> > */
> > uint32_t rte_get_log_level(void);
> >
> I don't think this patch is necessary, as all it adds is a single extra line to
> a comment.
I'm sad for you Bruce: you only see an empty line where you could catch
the beauty of the star ;)
Matthew, obviously you failed your send.
As a general comment, please group patches by logic meaning and
check them before sending ;)
next prev parent reply other threads:[~2015-11-13 11:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 6:47 [dpdk-dev] [PATCH 0/6] librte_eal: allow wider range of log levels Matthew Hall
2015-11-13 6:47 ` [dpdk-dev] [PATCH 1/6] librte_log: add function to retrieve log_level Matthew Hall
2015-11-13 11:40 ` Bruce Richardson
2015-11-13 11:49 ` Thomas Monjalon [this message]
2015-11-13 19:04 ` Matthew Hall
2015-11-13 19:01 ` Matthew Hall
2015-11-13 6:47 ` [dpdk-dev] [PATCH 2/6] rte_log.h: add detailed log levels RTE_LOG{FINE, FINER, FINEST} Matthew Hall
2015-11-13 11:44 ` Bruce Richardson
2015-11-13 11:48 ` Ananyev, Konstantin
2015-11-13 19:14 ` Matthew Hall
2015-11-13 19:16 ` Matthew Hall
2015-11-13 16:07 ` Stephen Hemminger
2015-11-13 19:15 ` Matthew Hall
2015-11-13 6:47 ` [dpdk-dev] [PATCH 3/6] eal_common_log.c: reset default level to RTE_LOG_FINEST Matthew Hall
2015-11-13 6:47 ` [dpdk-dev] [PATCH 4/6] rte_log.h: update logging docs to include FINEST level Matthew Hall
2015-11-13 6:47 ` [dpdk-dev] [PATCH 5/6] rte_log.h: add RTE_SYSLOG_LEVEL_MAX Matthew Hall
2015-11-13 6:47 ` [dpdk-dev] [PATCH 6/6] eal_log.c: limit syslog level to RTE_SYSLOG_LEVEL_MAX Matthew Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4536748.1MnZAysZE1@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=mhall@mhcomputing.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).