From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 7E7AD940C for ; Fri, 13 Nov 2015 12:50:49 +0100 (CET) Received: by wmvv187 with SMTP id v187so77522750wmv.1 for ; Fri, 13 Nov 2015 03:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=PuCBLcyMnfaQwxTOCXIP/Re4gH83Lj4aUlVaRq+XR0Y=; b=iHxneltCPcBfgVfAG7Kq6GfZCgaQmeqNDQCybWrRg6Vss05CCPQdVb0GyiF18N+hS6 EoHv8aEDUYgHMg3/aZoSrXzBDh54b/pLJE2nw+6fW/L8dYFosiI5fRHepX92M36SgK3h D6gACrT66jQ2j029k5WHGK2ZMQj4zGcjbBCzMLgI6fj56rPrvvdPw4RCjuN+Pq/oMtd2 Mdeo5qOsJdaqRZ78EqsBupReyeS8MhKPs8wMBOGdy5KeVVwxf1XmtwlViZK8hHgsKHZo bHvCBSBHXwVr5ywzq3iCXPDTsNCwG00vUpYDkiVP07hJUIyZ/W8vbVo78qZdYmVPT1Tb k3Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=PuCBLcyMnfaQwxTOCXIP/Re4gH83Lj4aUlVaRq+XR0Y=; b=ZfVJpIkgf+NS3uezmel2YVT0UeRbvDQZN8HcP7iPOeKM9iDPFu5qD7SXVL8UMCWBjr KaJYNEQ+i6eBI5Gp6m5pZvFHda/nvuJIh/su5Gb66l1TsguU/9WWJtRKVZMrSRoJfaLZ CSVhv9kuWeSzJAPDDXbL2DXGy+7+1aRu5nokRCWTkq3SYcwhao/TpKt6SguVGJBhXaVu nFeA6UJegGqgUQAJ6AdjvpctXDg6DYBMwD0aILw4UNla9M9wA2a5fX7Q7I6yYPW/nq17 6JHdNDxpyGmQflE8aooqYF4cQesGH12AGVl7qRtS/iEpWjEkp5FIaQee4prvUlnjv9// ZzzQ== X-Gm-Message-State: ALoCoQlQ60ayWCprvLirCXwpZuYxRZxCeyApA56i9SRw+1Ul3OINYIdsNmTSi8dXj7iX8npUeC/j X-Received: by 10.28.232.136 with SMTP id f8mr3568013wmi.1.1447415449295; Fri, 13 Nov 2015 03:50:49 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id he3sm19496951wjc.48.2015.11.13.03.50.48 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 13 Nov 2015 03:50:48 -0800 (PST) From: Thomas Monjalon To: Bruce Richardson , Matthew Hall Date: Fri, 13 Nov 2015 12:49:36 +0100 Message-ID: <4536748.1MnZAysZE1@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20151113114008.GA15612@bricha3-MOBL3> References: <1447397258-27233-1-git-send-email-mhall@mhcomputing.net> <1447397258-27233-2-git-send-email-mhall@mhcomputing.net> <20151113114008.GA15612@bricha3-MOBL3> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/6] librte_log: add function to retrieve log_level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Nov 2015 11:50:49 -0000 2015-11-13 11:40, Bruce Richardson: > On Fri, Nov 13, 2015 at 06:47:33AM +0000, Matthew Hall wrote: > > --- a/lib/librte_eal/common/include/rte_log.h > > +++ b/lib/librte_eal/common/include/rte_log.h > > @@ -131,6 +131,7 @@ void rte_set_log_level(uint32_t level); > > > > /** > > * Get the global log level. > > + * > > */ > > uint32_t rte_get_log_level(void); > > > I don't think this patch is necessary, as all it adds is a single extra line to > a comment. I'm sad for you Bruce: you only see an empty line where you could catch the beauty of the star ;) Matthew, obviously you failed your send. As a general comment, please group patches by logic meaning and check them before sending ;)