Re: [dpdk-dev] [PATCH v10 2/4] mk: Fix missing directory with combined extlib build

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-12-07 13:48, Remy Horton:
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
>  mk/rte.extlib.mk | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/mk/rte.extlib.mk b/mk/rte.extlib.mk
> index 4d459e4..47023a3 100644
> --- a/mk/rte.extlib.mk
> +++ b/mk/rte.extlib.mk
> @@ -42,11 +42,17 @@ export NOT_FIRST_CALL
>  
>  all:
>  	$(Q)mkdir -p $(RTE_OUTPUT)
> +ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
> +	$(Q)mkdir -p $(RTE_OUTPUT)/build/lib
> +endif

This directory is created to copy an object file which is not never used.

I suggest this approach instead:

--- a/mk/rte.lib.mk
+++ b/mk/rte.lib.mk
@@ -136,7 +136,7 @@ endif
                $(depfile_newer)),\
                $(O_TO_S_DO))
 
-ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS)$(EXTLIB_BUILD),yn)
        $(if $(or \
         $(file_missing),\
         $(call cmdline_changed,$(O_TO_C_STR)),\
@@ -159,7 +159,7 @@ $(LIB): $(OBJS-y) $(DEP_$(LIB)) FORCE
            $(depfile_missing),\
            $(depfile_newer)),\
            $(O_TO_A_DO))
-ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),y)
+ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS)$(EXTLIB_BUILD),yn)
        $(if $(or \
         $(file_missing),\
         $(call cmdline_changed,$(O_TO_C_STR)),\

The combine lib is not prepared for external lib objects.