DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Lance Richardson <lance.richardson@broadcom.com>,
	Xiaoyun Li <xiaoyun.li@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 21.05 v2] app/testpmd: support show Rx queue desc count
Date: Fri, 12 Feb 2021 16:16:33 +0000	[thread overview]
Message-ID: <454225fd-2667-ca1a-d872-080b5efcd231@intel.com> (raw)
In-Reply-To: <20210212145637.195181-1-lance.richardson@broadcom.com>

On 2/12/2021 2:56 PM, Lance Richardson wrote:
> Add support for querying the count of ready descriptors on a
> receive queue in order to allow the rte_eth_dev rx_queue_count()
> API to be exercised and tested.
> 

Overall looks good to me, but there are slightly different reference to the feature,
the commit title mentions from feature as "show Rx queue desc count",
the commit log has as "count of ready descriptors",
and the documentation has "rxq desc used count",
what do you think unifying them?

> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>

<...>

> +	.f = cmd_show_rx_queue_desc_used_count_parsed,
> +	.data = NULL,
> +	.help_str = "show port <port_id> rxq <queue_id> desc used count",

Can you please add the new command to the help, 'cmd_help_long_parsed()' too?


  reply	other threads:[~2021-02-12 16:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 19:44 [dpdk-dev] [PATCH 21.05] app/testpmd: support show Rx queue count Lance Richardson
2021-02-12 11:51 ` Ferruh Yigit
2021-02-12 15:12   ` Lance Richardson
2021-02-12 14:56 ` [dpdk-dev] [PATCH 21.05 v2] app/testpmd: support show Rx queue desc count Lance Richardson
2021-02-12 16:16   ` Ferruh Yigit [this message]
2021-02-12 21:24 ` [dpdk-dev] [PATCH 21.05 v3] app/testpmd: display rxq desc used count Lance Richardson
2021-02-22  5:15   ` Li, Xiaoyun
2021-02-22 11:17     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=454225fd-2667-ca1a-d872-080b5efcd231@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=lance.richardson@broadcom.com \
    --cc=xiaoyun.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).