From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0319EA0547; Fri, 12 Feb 2021 17:16:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8081D22A2B6; Fri, 12 Feb 2021 17:16:42 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 0980D22A29E for ; Fri, 12 Feb 2021 17:16:39 +0100 (CET) IronPort-SDR: tZLLG+oega688PpCqR9wCatc+HST9ljg3et0vqoixIjKhZbe7Ly+mYSld/NJrxrXVUNXc5QDKC UZKT3b/2l8jw== X-IronPort-AV: E=McAfee;i="6000,8403,9893"; a="182505612" X-IronPort-AV: E=Sophos;i="5.81,174,1610438400"; d="scan'208";a="182505612" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 08:16:38 -0800 IronPort-SDR: 6NLYrv1zM/tG00oxZ/+6g3GbqAIHBH0LrtLGzPBGAhZidZLX2fCbMOzyY3ynOYfY2xN6papC9c ya7A/LGzC2Xw== X-IronPort-AV: E=Sophos;i="5.81,174,1610438400"; d="scan'208";a="437635432" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.3.39]) ([10.252.3.39]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Feb 2021 08:16:37 -0800 To: Lance Richardson , Xiaoyun Li Cc: dev@dpdk.org References: <20210211194434.172212-1-lance.richardson@broadcom.com> <20210212145637.195181-1-lance.richardson@broadcom.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <454225fd-2667-ca1a-d872-080b5efcd231@intel.com> Date: Fri, 12 Feb 2021 16:16:33 +0000 MIME-Version: 1.0 In-Reply-To: <20210212145637.195181-1-lance.richardson@broadcom.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 21.05 v2] app/testpmd: support show Rx queue desc count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/12/2021 2:56 PM, Lance Richardson wrote: > Add support for querying the count of ready descriptors on a > receive queue in order to allow the rte_eth_dev rx_queue_count() > API to be exercised and tested. > Overall looks good to me, but there are slightly different reference to the feature, the commit title mentions from feature as "show Rx queue desc count", the commit log has as "count of ready descriptors", and the documentation has "rxq desc used count", what do you think unifying them? > Signed-off-by: Lance Richardson <...> > + .f = cmd_show_rx_queue_desc_used_count_parsed, > + .data = NULL, > + .help_str = "show port rxq desc used count", Can you please add the new command to the help, 'cmd_help_long_parsed()' too?