From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86211A00C5; Thu, 11 Jun 2020 16:29:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 68760FEB; Thu, 11 Jun 2020 16:29:44 +0200 (CEST) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by dpdk.org (Postfix) with ESMTP id D952C2AB for ; Thu, 11 Jun 2020 16:29:42 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id EEA9F580209; Thu, 11 Jun 2020 10:29:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 11 Jun 2020 10:29:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= u2HxzfH/jcbi5vCZ/lBAyEEqYumvk/yNYQu78hTJS0s=; b=jKaxuKbANZqgN4Db dr0nmtfqRhcPhaY6Q56LTr5QY8zWLZ0CUfRr33bcqUBUVZNJ9x8XQVa02lDSqM// U5f6Te6OWX+HZEhdfWuld8pdro5z0I0Oxbu+TtIe+naZ3GGJT9bixhk3QAETtgPA ik04P6gwVu/Pb5e59ccbeK//wj0IluWLWmbnrrChgX9bt/lIRxRJgyOy0QoD7QJR r1aSbNER1fPz/r0cZZ3HjkuFUnItvypnWPGvB66bK2ij3BqZcl40K4qbS1fW+4T8 0r1XF+AUaeFqevM9d7lhoxyfGePaYJ50T5dzKU6xxbh4UDXvzCuz9kPXgQ0N250x 0aTukA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=u2HxzfH/jcbi5vCZ/lBAyEEqYumvk/yNYQu78hTJS 0s=; b=Y1lztPzG28t51LoNOEtk4YaYdxSv/4CacaiFjW9tPAM9C5L0RJClctSx0 NdpBHUB+Ew1tBGH5aC4ofA3/eYkA0fIRFXfitUHaF/Wzb9ImQd2nebHDZH+SomnM IZWjiQYmaT6CPquqknbXjOiiRR2icU1iOMxkt4lpWfsVEqYL9NPV/WfjIP0eV/dm XIpvKOVT6foCbheyESZ7jvwP6upPgHRjRmBvmWuExFYmULMuOqTl3yIQrR/Assdu gUH4kBrliJBGJvz80thUPVgdoz91i12jt7R2Oc+ChyqcgnuH+4G7BauwYFqFdVwD SscwUnKOI7ZH2VeU4s1zEbZ+I57Zw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudehledghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 45FEF3065113; Thu, 11 Jun 2020 10:29:36 -0400 (EDT) From: Thomas Monjalon To: talshn@mellanox.com Cc: Ranjit Menon , dev@dpdk.org, Dmitry Kozlyuk , dev@dpdk.org, pallavi.kadam@intel.com, navasile@linux.microsoft.com, harini.ramakrishnan@microsoft.com, ocardona@microsoft.com, david.marchand@redhat.com, arybchenko@solarflare.com, bruce.richardson@intel.com, jerinj@marvell.com, drc@linux.vnet.ibm.com, ruifeng.wang@arm.com, konstantin.ananyev@intel.com, Olivier Matz Date: Thu, 11 Jun 2020 16:29:34 +0200 Message-ID: <4549446.TvtaaPhbfP@thomas> In-Reply-To: <20200611114316.GA12564@platinum> References: <20200519184111.4504-1-talshn@mellanox.com> <20200611114316.GA12564@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mbuf: align rte_mbuf for Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/06/2020 13:43, Olivier Matz: > On Tue, May 19, 2020 at 03:15:19PM -0700, Ranjit Menon wrote: > > On 5/19/2020 1:18 PM, Thomas Monjalon wrote: > > > 19/05/2020 21:57, Dmitry Kozlyuk: > > > > On Tue, 19 May 2020 20:49:50 +0200 > > > > Thomas Monjalon wrote: > > > > > > > > > +Cc more maintainers > > > > > > > > > > 19/05/2020 20:41, talshn@mellanox.com: > > > > > > From: Tal Shnaiderman > > > > > > > > > > > > Using uint32_t type bit-fields in Windows will pads the > > > > > > 'L2/L3/L4 and tunnel information' union with additional bits. > > > > > > > > > > > > This padding causes rte_mbuf size misalignment and the total size > > > > > > increases to 3 cache-lines. > > > > > > > > > > > > Changed packet_type bit-fields types from uint32_t to uint8_t > > > > > > to allow unified 2 cache-line structure size. > > > > > > > > > > > > Added the __extension__ attribute over the modified struct to avoid > > > > > > the warning: > > > > > > > > > > > > type of bit-field ... is a GCC extension [-pedantic] > > > > > > > > > > > > Signed-off-by: Tal Shnaiderman > > Acked-by: Olivier Matz Applied, thanks