* [dpdk-dev] [PATCH v1] net/ice/base: revert the change of first profile mask
@ 2021-07-13 1:51 Wenjun Wu
2021-07-13 2:31 ` [dpdk-dev] [PATCH v2] " Wenjun Wu
0 siblings, 1 reply; 3+ messages in thread
From: Wenjun Wu @ 2021-07-13 1:51 UTC (permalink / raw)
To: dev, qiming.yang, qi.z.zhang; +Cc: Wenjun Wu
Segmentation fault mentioned in patch[1] is related to hardware
issue.
This patch revert patch[1], since patch[1] may have protential
risk and side effect if the first profile mask is set to 0.
[1]:
commit 148fdf2d3537 ("net/ice/base: fix first profile mask")
Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
---
drivers/net/ice/base/ice_flex_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 829d88bba6..b3cea731f3 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -3432,7 +3432,7 @@ static void ice_init_prof_masks(struct ice_hw *hw, enum ice_block blk)
per_pf = ICE_PROF_MASK_COUNT / hw->dev_caps.num_funcs;
hw->blk[blk].masks.count = per_pf;
- hw->blk[blk].masks.first = 0;
+ hw->blk[blk].masks.first = hw->pf_id * per_pf;
ice_memset(hw->blk[blk].masks.masks, 0,
sizeof(hw->blk[blk].masks.masks), ICE_NONDMA_MEM);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [dpdk-dev] [PATCH v2] net/ice/base: revert the change of first profile mask
2021-07-13 1:51 [dpdk-dev] [PATCH v1] net/ice/base: revert the change of first profile mask Wenjun Wu
@ 2021-07-13 2:31 ` Wenjun Wu
2021-07-13 2:55 ` Zhang, Qi Z
0 siblings, 1 reply; 3+ messages in thread
From: Wenjun Wu @ 2021-07-13 2:31 UTC (permalink / raw)
To: dev, qiming.yang, qi.z.zhang; +Cc: Wenjun Wu
Segmentation fault mentioned in patch[1] is related to hardware
issue.
This patch revert patch[1], since patch[1] may have potential
risk and side effect if the first profile mask is set to 0.
[1]:
commit 148fdf2d3537 ("net/ice/base: fix first profile mask")
Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
---
v2: correct misspelling in commit message.
---
drivers/net/ice/base/ice_flex_pipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 829d88bba6..b3cea731f3 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -3432,7 +3432,7 @@ static void ice_init_prof_masks(struct ice_hw *hw, enum ice_block blk)
per_pf = ICE_PROF_MASK_COUNT / hw->dev_caps.num_funcs;
hw->blk[blk].masks.count = per_pf;
- hw->blk[blk].masks.first = 0;
+ hw->blk[blk].masks.first = hw->pf_id * per_pf;
ice_memset(hw->blk[blk].masks.masks, 0,
sizeof(hw->blk[blk].masks.masks), ICE_NONDMA_MEM);
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH v2] net/ice/base: revert the change of first profile mask
2021-07-13 2:31 ` [dpdk-dev] [PATCH v2] " Wenjun Wu
@ 2021-07-13 2:55 ` Zhang, Qi Z
0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Qi Z @ 2021-07-13 2:55 UTC (permalink / raw)
To: Wu, Wenjun1, dev, Yang, Qiming
> -----Original Message-----
> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Sent: Tuesday, July 13, 2021 10:31 AM
> To: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Subject: [PATCH v2] net/ice/base: revert the change of first profile mask
>
> Segmentation fault mentioned in patch[1] is related to hardware issue.
> This patch revert patch[1], since patch[1] may have potential risk and side
> effect if the first profile mask is set to 0.
>
> [1]:
> commit 148fdf2d3537 ("net/ice/base: fix first profile mask")
>
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-13 2:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-13 1:51 [dpdk-dev] [PATCH v1] net/ice/base: revert the change of first profile mask Wenjun Wu
2021-07-13 2:31 ` [dpdk-dev] [PATCH v2] " Wenjun Wu
2021-07-13 2:55 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).