From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3937A0C43; Fri, 26 Nov 2021 13:39:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 789AD40C35; Fri, 26 Nov 2021 13:39:29 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mails.dpdk.org (Postfix) with ESMTP id A6686406FF; Fri, 26 Nov 2021 13:39:27 +0100 (CET) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 508CB5C0112; Fri, 26 Nov 2021 07:39:27 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Fri, 26 Nov 2021 07:39:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= wGq4H/CMalR086qJ+iUI6QGw6HuhjUmVvaFCyD7fV3Y=; b=MvosRjZzcTwF96/T j/Cp4+tM4HXh4G4HGJEyXQMZ4daZ/LMVzGvX5KDn7lx5tey1hGd7r6bzgpKKwuJ9 l0p4l4EIXYmwNLe1uVAFPkQ/lucJGinnka9JPBnjqfNI/LQ8oebHcz5Omvhbo8JN Hs7CQDy9IhinOtpyG5ER6++aaeeRfMA5nzYOJkSQjgh3sPoAhppfBNjV/+BUTgxQ TeWSYEWSxjrbEXO+9sZtOUElv5lzetmWeV6vwJu6DXGsQEw7IbcqR8bRlC+ommDN iRIzQemuBIRjYRxLznelGTZUvJo5QrDxoBmrz/DImj3j55SYQiTaXMov8/XdnsKe zoJV6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=wGq4H/CMalR086qJ+iUI6QGw6HuhjUmVvaFCyD7fV 3Y=; b=YnJbCmA9lmlT5+l2qB8nPar8KK2rP9uuYBT0jOxh7/zUFHP7LTv45sUUr JgwCeS5T6VaubmoNp8WEfjX3160dxt7l8FZwIHGYZy2Bw+JXo37BA45peGVMAxpZ 9wvZUGmtMFBse7UPPz4KGafaoO/F1NMzOkImtbrTulQJ0TIjAcYEqlYQcKjx+Ptm 8BD/tXZRVOLgrZWRTWPYt1S17D1ga3tDmoXJcLnM75CC+npznz1dyZyTeHQcHbuL b+4PkgJJel6H0iyaZ4phWr5lL0LbwkIDx+G4s/apgLVFruKNPq9A+GOB7zJkYSnA SgP7ypdJrlmahBtCwjNGvpY5t9A3Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrhedvgdegvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 Nov 2021 07:39:25 -0500 (EST) From: Thomas Monjalon To: Michael Baum , Matan Azrad Cc: Raslan Darawsheh , dev@dpdk.org, Slava Ovsiienko , "stable@dpdk.org" , Lior Margalit , Asaf Penso Subject: Re: [PATCH] net/mlx5: fix devargs validation for multiclass probe Date: Fri, 26 Nov 2021 13:39:20 +0100 Message-ID: <4551809.0VFYljT9zx@thomas> In-Reply-To: References: <20211125061655.3143135-1-michaelba@nvidia.com> <2510169.dztEg1IeGT@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 25/11/2021 11:38, Matan Azrad: > From: Thomas Monjalon > > 25/11/2021 07:16, michaelba@nvidia.com: > > > From: Michael Baum > > > > > > The mlx5_args function reads the devargs and checks if they are valid > > > for this driver and if not it returns an error. > > > > > > This was normal behavior as long as all the devargs come to this > > > driver, but since it is possible to run several drivers together, the > > > function may return an error for another driver's devarg even though > > > it is completely valid. > > > In addition the function does not allow the user to know which of the > > > devargs he sent is incorrect, but returns an error without printing > > > the unknown devarg. > > > > > > This patch eliminates the error return in the case of an unknown > > > devarg, and prints a warning for each such devarg specifically. > > > > > > Fixes: 7b4f1e6bd367 ("common/mlx5: introduce common library") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Michael Baum > > > Acked-by: Matan Azrad > > > --- > > > drivers/net/mlx5/mlx5.c | 68 > > > ++++++----------------------------------- > > > 1 file changed, 9 insertions(+), 59 deletions(-) > > > > It is quite a big patch. > > How well it has been tested? > > It was tested carefully to see that devargs affect the actual configuration and also to allow running !net classes devargs with the net class. > > > How critical it is to have in 21.11? > > CRYPTO class cannot run with NET\ETH on the same device. > No significant risk here; I suggest taking. OK, applied, thanks.