From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92FE34416A; Thu, 6 Jun 2024 15:15:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EAA040E5E; Thu, 6 Jun 2024 15:15:04 +0200 (CEST) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by mails.dpdk.org (Postfix) with ESMTP id 4482C402E7 for ; Thu, 6 Jun 2024 15:15:03 +0200 (CEST) Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-57a85cc2d96so1169538a12.2 for ; Thu, 06 Jun 2024 06:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1717679703; x=1718284503; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tGizzEL1qe89p5GfgxKkQQv7ZrtlROOrrV7s1p//GqY=; b=fHj1M4Fo2DJ+nZ6wSjHOePT7yad7lHONoEX2kbq5hhbFrrF0aG9syFquHjBldg/hye DD+zYgfUdiGSviTIwqvzzuvI0lsFwldHxrEeUJnLcNj1yo7QnKkmroBJlI1fXQu9YeW2 Y3HfGgoEPr9CnEZdbBJ0HwC1wM80wB5T12ZfzUNpVLZ9OQ+zcdJ5bTLwDYnzdl9aAZT7 zdWspE+mMQrd533rYbVNkHkFJlW8sUZrH9wJqDNWXD+1FtOZ138Armh315qFj6/2sZpj h73jfuQUC/zeGTTMWc2247CTvwf5n6s43tY2juU0BqZ6psHPclAGnlEtZbUWONT2CyBS 3xGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717679703; x=1718284503; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tGizzEL1qe89p5GfgxKkQQv7ZrtlROOrrV7s1p//GqY=; b=oLoyaFh2FPiizyntYAeMwGBzyoEAMHHUiP+LV4C5Dav77cBdFiQzPIZ/ZD1E7q+Mry n6oPBbTwVQoNmoxypkdUyemEhjQBzSogxl9KI5HHn7twOBlF7Gm/dmAJr7QnLEtdCA7A OloIGDw/H25iL0TwIoC0FL6Dm1OQvF+uXkr8d7GainRqlkjfWp/kk76UVPv1tiwhFUcp S5jWUjJTga3vHXIukG+96xn7PQj+D3tCTVG9z/oovhvK3WbEpXp8ATxcJWVutCUymyN6 +DturexpWsr5xvlR5w3Deiova4teUsrcJ+VsfZKhG+ZZ7v1OPzPjhic7EHhp4t0HTST4 sfcA== X-Forwarded-Encrypted: i=1; AJvYcCVlbE0huh0HNTos3Cacice9RYHDarIW9Z0J5mJYLe+FVF7eWc5EkOsuoAyX21yFy1u6ZMXLD6UuAym3qR8= X-Gm-Message-State: AOJu0YzGilvP9Q5fIjvEGbOmBFYHU2NdmRq9MQ6KJy3wq9Knu/2KdCc0 5tYDVOJC+rWoCyEtTlIaalgnuEr8NLYBZrdpSeNugtgvMvubAEDBdQjmg15Pc20= X-Google-Smtp-Source: AGHT+IEPpqNqP3hNL7UzV9cKQkF5cIheXXldUvfIfL6JMrPv2ccV+uBz0IcYUC14mFt43kYZs9Q6dQ== X-Received: by 2002:a50:d602:0:b0:57a:2eab:3112 with SMTP id 4fb4d7f45d1cf-57a8b6a4dc9mr3247405a12.15.1717679702763; Thu, 06 Jun 2024 06:15:02 -0700 (PDT) Received: from [10.12.0.137] ([81.89.53.154]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57aae234204sm1069086a12.87.2024.06.06.06.15.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jun 2024 06:15:01 -0700 (PDT) Message-ID: <45558892-c4f0-4548-a5c0-0759e54bf4e7@pantheon.tech> Date: Thu, 6 Jun 2024 15:14:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/8] dts: use Params for interactive shells To: Luca Vizzarro , dev@dpdk.org Cc: Jeremy Spewock , Paul Szczepanek References: <20240326190422.577028-1-luca.vizzarro@arm.com> <20240509112057.1167947-1-luca.vizzarro@arm.com> <20240509112057.1167947-3-luca.vizzarro@arm.com> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240509112057.1167947-3-luca.vizzarro@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9. 5. 2024 13:20, Luca Vizzarro wrote: > Make it so that interactive shells accept an implementation of `Params` > for app arguments. Convert EalParameters to use `Params` instead. > > String command line parameters can still be supplied by using the > `Params.from_str()` method. > > Signed-off-by: Luca Vizzarro > Reviewed-by: Paul Szczepanek Reviewed-by: Juraj Linkeš > diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py > index 97aa26d419..c886590979 100644 > --- a/dts/framework/testbed_model/sut_node.py > +++ b/dts/framework/testbed_model/sut_node.py > @@ -393,24 +376,21 @@ def create_eal_parameters( > if prefix: > self._dpdk_prefix_list.append(prefix) > > - if vdevs is None: > - vdevs = [] > - > if ports is None: > ports = self.ports > > - return EalParameters( > + return EalParams( > lcore_list=lcore_list, > memory_channels=self.config.memory_channels, > prefix=prefix, > no_pci=no_pci, > vdevs=vdevs, > ports=ports, > - other_eal_param=other_eal_param, > + other_eal_param=Params.from_str(other_eal_param), So this is where from_str() is used. I guess it didn't get removed in a subsequent patche where the last usage of it was removed.