From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6B1111B8B4 for ; Fri, 8 Feb 2019 12:34:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Feb 2019 03:34:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,347,1544515200"; d="scan'208";a="145214884" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by fmsmga001.fm.intel.com with ESMTP; 08 Feb 2019 03:34:40 -0800 Received: from irsmsx105.ger.corp.intel.com ([169.254.7.72]) by IRSMSX109.ger.corp.intel.com ([169.254.13.83]) with mapi id 14.03.0415.000; Fri, 8 Feb 2019 11:34:39 +0000 From: "Medvedkin, Vladimir" To: "Wang, Yipeng1" , "Gobriel, Sameh" , Thomas Monjalon CC: "dev@dpdk.org" , "Richardson, Bruce" , "De Lara Guarch, Pablo" , "Yigit, Ferruh" Thread-Topic: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash Thread-Index: AQHUvghC8MMlRvZhgUCSIAk4oe8XyqXUuqYAgAAgbgCAAAI7gIAAHB6AgADMi/A= Date: Fri, 8 Feb 2019 11:34:38 +0000 Message-ID: <455E10571F3D08449B101F4522C6CA6725F8FDCB@irsmsx105.ger.corp.intel.com> References: <1549375057-4211-1-git-send-email-vladimir.medvedkin@intel.com> <5937441.0T0pBNs0GK@xps> <8657694.f1liP514bC@xps> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZTU0NWQ1NDUtNWU2My00ZGY5LTkwYzYtYzk4YTg5YzI4YzEwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoib0o5a0RRUVZkVTJTUzdsMXlSMHFrcU1CNnhTYW5hSmZFeVwvXC9XMkthNlVCWUJCcmFXZXZ6czBvUUhzSEJpRWR5In0= dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toeplitz hash X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Feb 2019 11:34:43 -0000 Hi Yipeng, Yes, I agree with you point. So keep me in mind if you decide to split hash= table and functions someday :) Thomas, I think this patch could be rejected. Thanks!=20 -----Original Message----- From: Wang, Yipeng1=20 Sent: Thursday, February 7, 2019 11:14 PM To: Gobriel, Sameh ; Thomas Monjalon ; Medvedkin, Vladimir Cc: dev@dpdk.org; Richardson, Bruce ; De Lara G= uarch, Pablo ; Yigit, Ferruh Subject: RE: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of Toe= plitz hash Hi Vladimir, Thanks for stepping up for the maintaining job. I agree with you that they are two parts and we mixed hash table and hashin= g function from beginning. They are actually should be two libraries, but a= t this Stage it is not very necessary to change the situation yet I think. If you trust us, I will definitely consult with you for questions coming up= about thash (also other hash functions like crc and jhash to the correspon= ding Authors). I will also get more familiar with the code as the maintaine= r. Thanks Yipeng >-----Original Message----- >From: Gobriel, Sameh >Sent: Thursday, February 7, 2019 1:33 PM >To: Thomas Monjalon ; Medvedkin, Vladimir=20 > >Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson,=20 >Bruce ; De Lara Guarch, Pablo=20 >; Yigit, Ferruh=20 > >Subject: RE: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of=20 >Toeplitz hash > >I agree with Thomas. It makes sense to separate out hash function from has= h table implementation. > >Sameh > >-----Original Message----- >From: Thomas Monjalon [mailto:thomas@monjalon.net] >Sent: Thursday, February 7, 2019 1:25 PM >To: Medvedkin, Vladimir >Cc: dev@dpdk.org; Wang, Yipeng1 ; Gobriel,=20 >Sameh ; Richardson, Bruce=20 >; De Lara Guarch, Pablo=20 >; Yigit, Ferruh=20 > >Subject: Re: [dpdk-dev] [PATCH v2] maintainers: claim maintainership of=20 >Toeplitz hash > >07/02/2019 20:28, Medvedkin, Vladimir: >> On 06/02/2019 10:38, Thomas Monjalon wrote: >> > 05/02/2019 14:57, Vladimir Medvedkin: >> >> --- a/MAINTAINERS >> >> +++ b/MAINTAINERS >> >> +M: Vladimir Medvedkin >> >> +F: lib/librte_hash/rte_thash.h >> > I'm not sure about adding maintainership for one file. >> > You are the author of this file, so you should be consulted during=20 >> > reviews if you don't catch them by yourself. >> > But I prefer seeing maintainers as taking charge and understanding=20 >> > of a full library as a block. >> > >> > And unfortunately, it does not work with the script: >> > devtools/get-maintainer.sh lib/librte_hash/rte_cuckoo_hash.h You=20 >> > would appear as maintainer for all hash files. >> >> It could be solved by adding header. >> >> In fact thash is not used by other parts of the hash library (instead=20 >> it could be used by softnic for example). >> >> From my point of view, hash library consists of two parts, hash=20 >> table itself and a number of hash functions. Hash functions, in turn,=20 >> can be used for many other purposes, not just for a hash table. Maybe=20 >> we should separate hash functions and hash table? And if you think it=20 >> is a bad idea, so be it, 4 maintainers for hash is enough. > >I don't know. >It's opening the door for more split of maintainers areas. >I would like to get more opinions from other maintainers, please. >