DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Rosen Xu <rosen.xu@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, orika@mellanox.com,
	walter.e.gilmore@intel.com, qi.z.zhang@intel.com,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add rte_fdir_conf initialization
Date: Thu, 26 Jul 2018 19:42:13 +0200	[thread overview]
Message-ID: <4562218.vGJ9EyzqYi@xps> (raw)
In-Reply-To: <1532255950-105866-1-git-send-email-rosen.xu@intel.com>

22/07/2018 12:39, Rosen Xu:
> Rte_fdir_conf of rte_eth_conf should be initialized before
> port initialization. It is a workaround solution when working
> with Intel I40e.
[...]
> +		/*
> +		 * Initialize fdir_conf of ete_eth_conf

Typo and lack of punctuation.

> +		 * it is a workaround solution when working with Intel I40e
> +		 * and it is not the normal way

It is not said why it is needed,
and what are we waiting to remove the workaround.

> +		 */
> +		.fdir_conf = {
> +			.mode = RTE_FDIR_MODE_PERFECT,
> +			.pballoc = RTE_FDIR_PBALLOC_64K,
> +			.status = RTE_FDIR_REPORT_STATUS,
> +			.drop_queue = 127,
> +		},

Please work on a v4 with better explanations.

  parent reply	other threads:[~2018-07-26 17:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  2:09 [dpdk-dev] [PATCH] " Rosen Xu
2018-07-12  5:17 ` Ori Kam
2018-07-12  5:26   ` Xu, Rosen
2018-07-12  5:58     ` Ori Kam
2018-07-12  6:22       ` Xu, Rosen
2018-07-17  5:15         ` Ori Kam
2018-07-17  9:57           ` Ferruh Yigit
2018-07-17 13:04             ` Ori Kam
2018-07-17 15:49               ` Ferruh Yigit
2018-07-21  7:50 ` [dpdk-dev] [PATCH v2] " Rosen Xu
2018-07-22  6:33   ` Ori Kam
2018-07-22 10:37     ` Xu, Rosen
2018-07-22 10:39 ` [dpdk-dev] [PATCH v3] " Rosen Xu
2018-07-23 20:32   ` Ferruh Yigit
2018-07-26 17:42   ` Thomas Monjalon [this message]
2018-07-31 12:55     ` Xu, Rosen
2018-07-31 12:52 ` [dpdk-dev] [PATCH v4] " Rosen Xu
2018-08-05 20:13   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4562218.vGJ9EyzqYi@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=orika@mellanox.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=walter.e.gilmore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).