From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 11DBE98;
 Thu, 26 Jul 2018 19:42:20 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id A0E9621B74;
 Thu, 26 Jul 2018 13:42:19 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Thu, 26 Jul 2018 13:42:19 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=KWkR81rUH1Xl228ZLOLiDQPnCI
 gLbNa6igMgry+7mGQ=; b=YbbjC84O9a2XGNQdtfcLuSg4swHP14gDRDjmpP1NpC
 WkkgW/NZBCF7U/+OwsyQvOOagjEljKzfg1uVpSh+cXqJ9V61uTPNXPBajFKBpYpA
 kRyIO8MmEWrMXpivs1OL8IqmqF4fBgjE4krcpdj9v4PuLKKN2BWFXH2dcEzRosKy
 w=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=KWkR81
 rUH1Xl228ZLOLiDQPnCIgLbNa6igMgry+7mGQ=; b=oafrqcAEmCkxvl4TbP5GXK
 pGddTH/vw+8UdzjhmChtYrBk1l+7+m719zPAie24nnCedLLcOchr8JirRdFWVyy4
 Hw6+Zf5O/4oXhRTgS/urGyXRxyXLa4bOTDQNCBpoSAC1jCZ8QfuIJZxtWLyWI5QW
 omj7g7LyEjwoVqemawT5V/TmuK0iL3va62VtuidIR30PDj8D3rAw9aH7Xpckkj7G
 z1egNXe9L2aDH/1Yumx4t5ZTZjcXQ7FIYCLhq9sTGSEUHLAfcRczAlibGnewD9Vh
 dF4W6KlJFD6ma/ka04sxbNv4ucvzNHYkFtzDwgA1vO2emGfN2Zfugp0pPztV24fA
 ==
X-ME-Proxy: <xmx:-wdaW87jVIr4zq0Q5_jSeU--H_e8BL6lTbNA5snIUnMME9FA2Odksw>
 <xmx:-wdaW0uF3GTkgrxHyyuhtJjX4u0fMQCKLUzjnmJrVusggZZlmDeIcA>
 <xmx:-wdaW8oW5Yzt7UVX0jmfuuEsdmudx8QZsozCeTJ06QoJhYLXN3taIQ>
 <xmx:-wdaW-6KUhJ5tMI3MhUxv4XO3_4olNeJ3jKhHMdjF1F-NQIkoG6bvA>
 <xmx:-wdaW3e59jrkP6PRn-k5TaMmZdvn6zt1ftpPJOBZqQMS7DJOZ58E4g>
 <xmx:-wdaWwNfSrclywUJv_MtVidxM-a1A-81YnMYp2a3BXY7GrnAp5Eq_A>
X-ME-Sender: <xms:-wdaW5efwwTFfHaWOK8gwI1NhROOf66CaU8-mlKqhbT3Qc4BtZcNVw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 2237910261;
 Thu, 26 Jul 2018 13:42:18 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Rosen Xu <rosen.xu@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, orika@mellanox.com,
 walter.e.gilmore@intel.com, qi.z.zhang@intel.com, stable@dpdk.org
Date: Thu, 26 Jul 2018 19:42:13 +0200
Message-ID: <4562218.vGJ9EyzqYi@xps>
In-Reply-To: <1532255950-105866-1-git-send-email-rosen.xu@intel.com>
References: <1531361387-116027-1-git-send-email-rosen.xu@intel.com>
 <1532255950-105866-1-git-send-email-rosen.xu@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3] examples/flow_filtering: add
	rte_fdir_conf initialization
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 26 Jul 2018 17:42:20 -0000

22/07/2018 12:39, Rosen Xu:
> Rte_fdir_conf of rte_eth_conf should be initialized before
> port initialization. It is a workaround solution when working
> with Intel I40e.
[...]
> +		/*
> +		 * Initialize fdir_conf of ete_eth_conf

Typo and lack of punctuation.

> +		 * it is a workaround solution when working with Intel I40e
> +		 * and it is not the normal way

It is not said why it is needed,
and what are we waiting to remove the workaround.

> +		 */
> +		.fdir_conf = {
> +			.mode = RTE_FDIR_MODE_PERFECT,
> +			.pballoc = RTE_FDIR_PBALLOC_64K,
> +			.status = RTE_FDIR_REPORT_STATUS,
> +			.drop_queue = 127,
> +		},

Please work on a v4 with better explanations.