From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 53C6F1E34 for ; Sun, 16 Jul 2017 06:22:07 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id 62so49794126wmw.1 for ; Sat, 15 Jul 2017 21:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weka.io; s=google; h=from:to:cc:subject:date:message-id:organization:in-reply-to :references:mime-version:content-transfer-encoding; bh=5ARZdMifZFclcr0Sq64/3ALJ3ZjH1tChd594/g/QLXQ=; b=CRb38I3xw2BULDKtJB3ErJbl8LDoKqL8SUrsBkCLTINB8b8lzfbUnYVThQ1aR8hqqY NqYhIg5xvggWnadhaoTcVI0mUVZ1wuxGDC6BxWf7o8BEI48xmVPI5lZEBt/Q76xcz1tj 9SB74rQQL1rraSBGYPJKlfPh5seKrnDPdnIAg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :in-reply-to:references:mime-version:content-transfer-encoding; bh=5ARZdMifZFclcr0Sq64/3ALJ3ZjH1tChd594/g/QLXQ=; b=CDzgXDOlvXH/FJHgHycs4SQDDPGFF27NPLMgGrCYc3dp2/fR7ly6Fhok8Hzv+L9ZVR NKr01hcE3WXm5O3F3Bkvi9SQJ8AO+aB0sRSarb3zj9l+GM6ng4dJmuz6EqXTvjwmuk0J R7iFSRrKv01l5xsk58yNBCenGCZjtP5+U2xuYc0gKVrETlGzqzNldumBmIDVoYZT+d2k iX16meVuYsitTh7k0VCIRb3donkURTye2exCrk5Z4rW5nFgdae0/Fck1qP2lhtXYY2LB zkeCTmTNxyfnTyCHFobAEWK0QvB1O7/UCVk2XhMedACWHDfFEwf51phC7Xn0UEstEIR6 RZoA== X-Gm-Message-State: AIVw110Fv1g95HVA2xWRvgLEBRiYcKxACLqUK1yd9HRtT+uiEYuFdG14 sXolQY+ReLk7KXED X-Received: by 10.28.208.69 with SMTP id h66mr334041wmg.66.1500178927001; Sat, 15 Jul 2017 21:22:07 -0700 (PDT) Received: from polaris.localnet (bzq-82-81-85-138.red.bezeqint.net. [82.81.85.138]) by smtp.gmail.com with ESMTPSA id x98sm19168241wrb.47.2017.07.15.21.22.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 15 Jul 2017 21:22:06 -0700 (PDT) From: Gregory Etelson To: Shijith Thotton Cc: "Tan, Jianfeng" , "dev@dpdk.org" , "Yigit, Ferruh" , Thomas Monjalon , Stephen Hemminger , "Lu, Wenzhuo" , spdk@lists.01.org Date: Sun, 16 Jul 2017 07:22:04 +0300 Message-ID: <4563824.ntyntO6lBN@polaris> Organization: Weka.IO In-Reply-To: References: <1497260285-27536-1-git-send-email-shijith.thotton@caviumnetworks.com> <1499426031-2664-1-git-send-email-shijith.thotton@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] igb_uio: issue FLR during open and release of device file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Jul 2017 04:22:07 -0000 Hello Shijith, Please add the patch to uio_pci_generic.c file in Linux kernel We experience similar faults with NVMe devices On Wednesday, 12 July 2017 06:40:55 IDT Tan, Jianfeng wrote: > > > -----Original Message----- > > From: Shijith Thotton [mailto:shijith.thotton@caviumnetworks.com] > > Sent: Friday, July 7, 2017 7:14 PM > > To: dev@dpdk.org > > Cc: Yigit, Ferruh; Gregory Etelson; Thomas Monjalon; Stephen Hemminger; > > Tan, Jianfeng; Lu, Wenzhuo > > Subject: [PATCH v2] igb_uio: issue FLR during open and release of device file > > > > Set UIO info device file operations open and release. Call pci reset > > function inside open and release to clear device state at start and end. > > Copied this behaviour from vfio_pci kernel module code. With this patch, > > it is not mandatory to issue FLR by PMD's during init and close. > > > > Bus master enable and disable are added in open and release respectively > > to take care of device DMA. > > > > Signed-off-by: Shijith Thotton > > Reviewed-by: Jianfeng Tan