DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] bonding: fix incorrect loop boundary condition
@ 2016-04-01 12:16 Vladyslav Buslov
  2016-04-01 13:28 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Vladyslav Buslov @ 2016-04-01 12:16 UTC (permalink / raw)
  To: dev

Loop that calculates total number of tx descriptors in slave tx queues should iterate up to nb_tx_queues, not nb_rx_queues.

Signed-off-by: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>
---
 drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
index 1b7e93a..c4448b7 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.c
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
@@ -890,7 +890,7 @@ bond_mode_8023ad_activate_slave(struct rte_eth_dev *bond_dev, uint8_t slave_id)
 	/* The size of the mempool should be at least:
 	 * the sum of the TX descriptors + BOND_MODE_8023AX_SLAVE_TX_PKTS */
 	total_tx_desc = BOND_MODE_8023AX_SLAVE_TX_PKTS;
-	for (q_id = 0; q_id < bond_dev->data->nb_rx_queues; q_id++) {
+	for (q_id = 0; q_id < bond_dev->data->nb_tx_queues; q_id++) {
 		bd_tx_q = (struct bond_tx_queue*)bond_dev->data->tx_queues[q_id];
 		total_tx_desc += bd_tx_q->nb_tx_desc;
 	}
-- 
2.8.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] bonding: fix incorrect loop boundary condition
  2016-04-01 12:16 [dpdk-dev] [PATCH] bonding: fix incorrect loop boundary condition Vladyslav Buslov
@ 2016-04-01 13:28 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-04-01 13:28 UTC (permalink / raw)
  To: Vladyslav Buslov; +Cc: dev

2016-04-01 15:16, Vladyslav Buslov:
> Loop that calculates total number of tx descriptors in slave tx queues should iterate up to nb_tx_queues, not nb_rx_queues.
> 
> Signed-off-by: Vladyslav Buslov <vladyslav.buslov@harmonicinc.com>

Fixes: 3ef7955700e7 ("bonding: fix LACP mempool size")

Applied, thanks

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-01 13:30 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-01 12:16 [dpdk-dev] [PATCH] bonding: fix incorrect loop boundary condition Vladyslav Buslov
2016-04-01 13:28 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).