From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Neil Horman <nhorman@tuxdriver.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility Date: Wed, 04 Mar 2015 17:49:50 +0100 Message-ID: <4566278.scup7l1psc@xps13> (raw) In-Reply-To: <1425486419-12508-1-git-send-email-nhorman@tuxdriver.com> 2015-03-04 11:26, Neil Horman: > +#trap on ctrl-c to clean up > +trap cleanup_and_exit SIGINT I think INT is preffered over SIGINT. You may also add QUIT and TERM. With QUIT, you can replace cleanup_and_exit calls by a simple exit. > + CURRENT_BRANCH=`git log --pretty=format:%H HEAD~1..HEAD` May be simpler "git log -1 --format=%H" > +log "INFO" "We're going to check and make sure that applications built" > +log "INFO" "against DPDK DSOs from tag $TAG1 will still run when executed" > +log "INFO" "against DPDK DSOs built from tag $TAG2." I think it may be removed as no app is run. > +# Make sure we configure SHARED libraries > +# Also turn off IGB and KNI as those require kernel headers to build > +sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET > +sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET > +sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET So you prefer modifying defconfig instead of .config, right? (you sent it while I was answering on v2) > +# Checking abi compliance relies on using the dwarf information in > +# The shared objects. Thats only included in the DSO's if we build > +# with -g > +export EXTRA_CFLAGS=-g > +export EXTRA_LDFLAGS=-g [...] > +export EXTRA_CFLAGS=-g > +export EXTRA_LDFLAGS=-g Already exported. > + OLDNAME=`basename $i | sed -e"s/1.dump/0.dump/"` Could be OLDNAME=$(basename $i 1.dump)0.dump > + LIBNAME=`basename $i | sed -e"s/-ABI-1.dump//"` Could be LIBNAME=$(basename $i -ABI-1.dump) Thanks
next prev parent reply other threads:[~2015-03-04 16:50 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-30 21:16 [dpdk-dev] [PATCH] " Neil Horman 2015-02-02 18:18 ` [dpdk-dev] [PATCH v2] " Neil Horman 2015-02-27 13:48 ` Neil Horman 2015-02-27 13:55 ` Thomas Monjalon 2015-03-03 22:18 ` Thomas Monjalon 2015-03-04 11:49 ` Neil Horman 2015-03-04 12:54 ` Thomas Monjalon 2015-03-04 14:39 ` Neil Horman 2015-03-04 15:15 ` Thomas Monjalon 2015-03-04 15:42 ` Neil Horman 2015-03-04 16:15 ` Thomas Monjalon 2015-03-04 16:26 ` [dpdk-dev] [PATCH v3] " Neil Horman 2015-03-04 16:49 ` Thomas Monjalon [this message] 2015-03-05 16:57 ` Neil Horman 2015-03-11 19:36 ` Neil Horman 2015-03-13 8:51 ` Thomas Monjalon 2015-03-13 11:56 ` Kavanagh, Mark B 2015-03-13 14:10 ` Neil Horman 2015-03-13 14:25 ` Kavanagh, Mark B 2015-03-13 14:58 ` Neil Horman 2015-03-13 15:49 ` Kavanagh, Mark B 2015-03-13 14:09 ` [dpdk-dev] [PATCH v4] " Neil Horman 2015-03-17 15:42 ` Thomas Monjalon 2015-03-17 16:47 ` Thomas Monjalon 2015-03-17 18:08 ` Neil Horman 2015-03-17 18:08 ` [dpdk-dev] [PATCH v5] " Neil Horman 2015-03-17 21:17 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4566278.scup7l1psc@xps13 \ --to=thomas.monjalon@6wind.com \ --cc=dev@dpdk.org \ --cc=nhorman@tuxdriver.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git