From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 03A96A6A for ; Wed, 4 Mar 2015 17:50:26 +0100 (CET) Received: by wibhm9 with SMTP id hm9so8952260wib.2 for ; Wed, 04 Mar 2015 08:50:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=buPAwB9/9V8dCX+7Q2axeFJOROrgc9N12XOrsXlTqw0=; b=fmlJlxfKBoGfvZ8xFd+r46uAV7kuo8kB1oYM9UCgNgflaCF0kWgOCOQrSecLyV4WDM DwL20Mnavy9rjTfEiu2hXmFn3Z+eMRHq0qNsbKVUPKk25MCshub9r7k9qC2F5QjKbOOy oiLNQuU3Sj/xtjKst1gymI/cY4HOfw6vlSrIJucghVaM3VcM2x1gZDHvnnHqNH0bamKE U4gA/R8HpKHiqUNJMp/cfoGeqD1UIlUEH9Xz211UwV28mcIqOEZNH643L4FXPc0o/QXb L0DXdb5ra/3tHckyiG+BKNjfEh4hh+OXwwdcqcmeS1kZiAO5EsJlTbLa3h4Y1bfs1snE /WGw== X-Gm-Message-State: ALoCoQnbCOsPlcxAxSxbvFyKcxOn1aR5xpXZYseLewsX+J82Ar4aCBfddf03E1s6tm6Rl/O92Pdt X-Received: by 10.194.174.164 with SMTP id bt4mr9680068wjc.7.1425487825815; Wed, 04 Mar 2015 08:50:25 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id t9sm25943863wia.15.2015.03.04.08.50.23 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Mar 2015 08:50:24 -0800 (PST) From: Thomas Monjalon To: Neil Horman Date: Wed, 04 Mar 2015 17:49:50 +0100 Message-ID: <4566278.scup7l1psc@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: <1425486419-12508-1-git-send-email-nhorman@tuxdriver.com> References: <1422652596-12777-1-git-send-email-nhorman@tuxdriver.com> <1425486419-12508-1-git-send-email-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] ABI: Add abi checking utility X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Mar 2015 16:50:26 -0000 2015-03-04 11:26, Neil Horman: > +#trap on ctrl-c to clean up > +trap cleanup_and_exit SIGINT I think INT is preffered over SIGINT. You may also add QUIT and TERM. With QUIT, you can replace cleanup_and_exit calls by a simple exit. > + CURRENT_BRANCH=`git log --pretty=format:%H HEAD~1..HEAD` May be simpler "git log -1 --format=%H" > +log "INFO" "We're going to check and make sure that applications built" > +log "INFO" "against DPDK DSOs from tag $TAG1 will still run when executed" > +log "INFO" "against DPDK DSOs built from tag $TAG2." I think it may be removed as no app is run. > +# Make sure we configure SHARED libraries > +# Also turn off IGB and KNI as those require kernel headers to build > +sed -i -e"$ a\CONFIG_RTE_BUILD_SHARED_LIB=y" config/defconfig_$TARGET > +sed -i -e"$ a\CONFIG_RTE_EAL_IGB_UIO=n" config/defconfig_$TARGET > +sed -i -e"$ a\CONFIG_RTE_LIBRTE_KNI=n" config/defconfig_$TARGET So you prefer modifying defconfig instead of .config, right? (you sent it while I was answering on v2) > +# Checking abi compliance relies on using the dwarf information in > +# The shared objects. Thats only included in the DSO's if we build > +# with -g > +export EXTRA_CFLAGS=-g > +export EXTRA_LDFLAGS=-g [...] > +export EXTRA_CFLAGS=-g > +export EXTRA_LDFLAGS=-g Already exported. > + OLDNAME=`basename $i | sed -e"s/1.dump/0.dump/"` Could be OLDNAME=$(basename $i 1.dump)0.dump > + LIBNAME=`basename $i | sed -e"s/-ABI-1.dump//"` Could be LIBNAME=$(basename $i -ABI-1.dump) Thanks