From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 5DB86C438 for ; Wed, 29 Jul 2015 17:09:57 +0200 (CEST) Received: by wibud3 with SMTP id ud3so224941975wib.1 for ; Wed, 29 Jul 2015 08:09:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=g+Qo+s2ckW5vojWjbd/GdBmZGsTsE3QhLodr2igFo3I=; b=hLye/RQhW2cQKJ7YACFO6SmoXjCZSPz+0oe5X0iwY4d4FhAXvwJL945BSqzAbugVe7 c0QbPAX2Qe9xpA1VmB0wg+kk4w93CKoZ7OovHwfXxkBYNjnOxx0Oj/1AXbxkvDB3MS0q osyfcUlreSS7PFTaS7c1LGJLT5H6tmFpuW0OuOWhhnKyDi7vPONiTpnrOJ/HNYdsj5Fp C8nX0BZUG0u6j6pUb4g+l5v2scUOryf7cpF4xfxzlokxLz2cm+1xba9bvh9u0O+7LXBe DUsCe1UasPL2rgNvTStLPtofig1Va0QSI1aY37ynwXN9wnWsrC9/h2q4YGnJbCOmq0FG avHw== X-Gm-Message-State: ALoCoQk474aQp4jmaJdOc7yniJhd1JCMYuFRYAPU1gv09VdXSXUKOtkNzJbklczyRubAhpBm8MON X-Received: by 10.194.178.1 with SMTP id cu1mr78308268wjc.59.1438182597194; Wed, 29 Jul 2015 08:09:57 -0700 (PDT) Received: from xps13.localnet (6wind.net2.nerim.net. [213.41.151.210]) by smtp.gmail.com with ESMTPSA id fq15sm1079626wjc.12.2015.07.29.08.09.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jul 2015 08:09:56 -0700 (PDT) From: Thomas Monjalon To: "Zhang, Helin" Date: Wed, 29 Jul 2015 17:08:42 +0200 Message-ID: <4566288.d5QVtI4JvI@xps13> Organization: 6WIND User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; ) In-Reply-To: References: <1438123707-26509-1-git-send-email-helin.zhang@intel.com> <4457109.BKbKVosbHQ@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] eal: fix build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jul 2015 15:09:57 -0000 2015-07-29 15:00, Zhang, Helin: > Hi Thomas >=20 > It was just an implicit declaration of function, when set > CONFIG_RTE_PCI_CONFIG=3Dy, as follows. Nobody else cares about it. Why do we have this config option? Please remove these useless ifdef's. > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_p= ci.c: In function =C3=A2=E2=82=AC?rte_eal_pci_probe_one_driver=C3=A2=E2= =82=AC=E2=84=A2: > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_p= ci.c:188:4: error: implicit declaration of function =C3=A2=E2=82=AC?pci= _config_space_set=C3=A2=E2=82=AC=E2=84=A2 [-Werror=3Dimplicit-function-= declaration] > pci_config_space_set(dev); > ^ > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_p= ci.c:188:4: error: nested extern declaration of =C3=A2=E2=82=AC?pci_con= fig_space_set=C3=A2=E2=82=AC=E2=84=A2 [-Werror=3Dnested-externs] > cc1: all warnings being treated as errors > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/linuxapp/eal/eal_pc= i.c:561:1: error: =C3=A2=E2=82=AC?pci_config_space_set=C3=A2=E2=82=AC=E2= =84=A2 defined but not used [-Werror=3Dunused-function] > pci_config_space_set(struct rte_pci_device *dev) > ^ > cc1: all warnings being treated as errors So I will change the title to: =09eal: fix build with pci config enabled and add this into the message: =09Build log: =09=09lib/librte_eal/common/eal_common_pci.c:188:4: error: =09=09implicit declaration of function pci_config_space_set > > -----Original Message----- > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > Sent: Wednesday, July 29, 2015 1:20 AM > > To: Zhang, Helin > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] eal: fix build > >=20 > > 2015-07-29 06:48, Helin Zhang: > > > It fixes the build error of implicit declaration of function. > >=20 > > What is the error? > > Please show the build log and describe the case when it happens (co= mpiler, > > version).